Uh oh!
There was an error while loading. Please reload this page.
Upgrade celery and use database backend for task results - #3332
Conversation
rtibbles
left a comment
There was a problem hiding this comment.
Looking good - one thing that seems like it might be a blocker from the read through, another that could do with some cleanup.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rtibbles
commented
Aug 3, 2022
Looks like we need to remove the |
rtibbles
left a comment
There was a problem hiding this comment.
Comments addressed and manual testing checks out. Just cleaning up the celery dashboard seems like the last TODO!
Summary
Description of the change(s) you made
celeryavailable for Python 3.6Taskmodel and usesTaskResultfromdjango-celery-results, which means this switches the celery result backend from redis to postgresManual verification steps performed
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)