Uh oh!
There was an error while loading. Please reload this page.
Edit modal - add accessibility field - #3366
Conversation
rtibbles
left a comment
There was a problem hiding this comment.
A couple of comments, but this is looking pretty damn close to perfect, code wise!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sairina
commented
Apr 14, 2022
Noting that there's a lag between when a user clicks on the checkbox and when the UI shows that the checkbox is checked. Not sure where this is coming from, but would appreciate any insight here. |
rtibbles
commented
Apr 14, 2022
My guess would be that it's an issue with data propagation, and the data not being as optimistically updated as we want. Can take a look locally. |
rtibbles
left a comment
There was a problem hiding this comment.
Manual testing checks out - the reported input lag seems to be a result of an 18 month old unreported bug, which I will fix in a follow up PR.
Summary
Description of the change(s) you made
Add metadata, strings, tests for accessibility field in the edit modal (
DetailsTabView)Manual verification steps performed
/syncendpoint that the checked items are being sent in astruewhen checked and the key is removed when a checkbox is uncheckedScreenshots (if applicable)
Does this introduce any tech-debt items?
This is the first of the new metadata fields to be included in the edit modal.
Reviewer guidance
How can a reviewer test these changes?
Run the tests:
AccessibilityOptionscomponent usingyarn run test-jest contentcuration/contentcuration/frontend/channelEdit/components/edit/__tests__/accessibilityOptions.spec.jsManually (see also the Gherkin stories for Accessibility here):
/syncendpoint that the checked items are being sent in astruewhen checked and the key is removed when a checkbox is unchecked:References
Contributor's Checklist
Studio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)