Uh oh!
There was an error while loading. Please reload this page.
Edit modal - add additional fields to "Basic info" section - #3370
Conversation
5b35db1 to
13b58abCompare
rtibbles
left a comment
There was a problem hiding this comment.
A couple of things that could be tweaked, but nothing alarming. I have not yet manually tested.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
13b58ab to
d6a0d94Compare| return Object.entries(ContentLevels).map(level => { | ||
| let translationKey; | ||
| if (level[0] === 'PROFESSIONAL') { | ||
| translationKey = 'specializedProfessionalTraining'; |
There was a problem hiding this comment.
cc @marcellamaki we might want to consolidate this logic somewhere like I think we did on Kolibri?
There was a problem hiding this comment.
I think I stole that from Kolibri: https://github.com/learningequality/kolibri/blob/develop/kolibri/plugins/learn/assets/src/views/EmbeddedSidePanel/SelectGroup.vue#L139
rtibbles
left a comment
There was a problem hiding this comment.
Test could still do more guarantee of behaviour.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Description of the change(s) you made
Note, this PR does not cover the "Categories" field, and the following issues are to address some specifics with regards to the "Learning Activity" dropdown field and setting defaults based on content kind, which is not covered in this PR.
DetailsTabView: Set default values on file upload #3373learning_activitiesfield: Data migration needed for historic data in backend #3374Manual verification steps performed
In the edit modal:
Screenshots
Does this introduce any tech-debt items?
This is a continuation of this issue #3205
Reviewer guidance
How can a reviewer test these changes? Please see Gherkin scenarios for additional, specific user interactions
In the edit modal:
References
Comments
Contributor's Checklist
Studio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)