Skip to content

Update django-cte to resolve query issue preventing access to API key - #3442

Merged
rtibbles merged 4 commits into
learningequality:hotfixesfrom
bjester:update-django-cte
Jul 7, 2022
Merged

Update django-cte to resolve query issue preventing access to API key#3442
rtibbles merged 4 commits into
learningequality:hotfixesfrom
bjester:update-django-cte

Conversation

@bjester

Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made


Reviewer guidance

How can a reviewer test these changes?

Follow the issue's reproduce steps

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester
bjesterforce-pushed the update-django-cte branch from b21c974 to 487c052CompareJuly 7, 2022 14:40
@bjester
bjester marked this pull request as ready for review July 7, 2022 15:26

@rtibblesrtibbles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@rtibbles
rtibbles merged commit b6a81e0 into learningequality:hotfixesJul 7, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pythonPull requests that update Python codeTAG: dependenciesTODO: needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bjester@rtibbles