Skip to content

Add stream parsing fallback for duration setting. - #3443

Merged
bjester merged 3 commits into
learningequality:hotfixesfrom
rtibbles:duration_set
Jul 6, 2022
Merged

Add stream parsing fallback for duration setting.#3443
bjester merged 3 commits into
learningequality:hotfixesfrom
rtibbles:duration_set

Conversation

@rtibbles

@rtibblesrtibbles commented Jul 5, 2022

Copy link
Copy Markdown
Member

Adds a fallback using ffmpeg in cases where the container header parsing with ffprobe does not produce a valid value.

This is somewhat intensive as it actually decodes the entire stream in order to get the duration, but should be relatively foolproof.

bjester
bjester reviewed Jul 6, 2022
View reviewed changes
Comment threadcontentcuration/contentcuration/management/commands/set_file_duration.py Outdated
bjester
bjester reviewed Jul 6, 2022
View reviewed changes
Comment threadcontentcuration/contentcuration/management/commands/set_file_duration.py
bjester
bjester approved these changes Jul 6, 2022
View reviewed changes

@bjesterbjester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bjester
bjester merged commit 365f077 into learningequality:hotfixesJul 6, 2022
@bjesterbjester mentioned this pull request Jul 6, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aronasormanaronasormanaronasorman approved these changes
@bjesterbjesterbjester approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rtibbles@aronasorman@bjester