Skip to content

Ensure file duration is an integer - #3477

Merged
rtibbles merged 2 commits into
learningequality:unstablefrom
bjester:duration-ceiling
Aug 3, 2022
Merged

Ensure file duration is an integer#3477
rtibbles merged 2 commits into
learningequality:unstablefrom
bjester:duration-ceiling

Conversation

@bjester

@bjesterbjester commented Aug 2, 2022

Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Calls ceiling on the file duration on both the frontend and the backend to ensure it's an integer

Manual verification steps performed

  1. Ran tests
  2. Uploaded a file to studio and ensured it still works

References

Fixes#3454

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester
bjester requested a review from rtibblesAugust 2, 2022 21:08
@bjesterbjester added TODO: needs review python Pull requests that update Python code labels Aug 2, 2022
Comment threadcontentcuration/contentcuration/viewsets/file.py Outdated
@rtibblesrtibbles self-assigned this Aug 2, 2022
@rtibbles
rtibbles merged commit 9d4923c into learningequality:unstableAug 3, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pythonPull requests that update Python codeTODO: needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValueError: Field 'duration' expected a number but got '175.033000\n'.

2 participants

@bjester@rtibbles