Uh oh!
There was an error while loading. Please reload this page.
Remove unused pycountry dependency. - #3580
Conversation
bjester
commented
Aug 25, 2022
I don't really understand the significance of adding
What about template translations? They use |
rtibbles
commented
Aug 25, 2022
Can double check! |
rtibbles
commented
Aug 25, 2022
As far as I can tell from the pycountry repo, the locale files contain internationalized names for countries and languages. We use Django's internal naming registry for language names to do this for interface languages, and le-utils names for content languages, so I am sure we're not leveraging it for displaying language names anywhere. |
rtibbles
commented
Aug 25, 2022
Have double checked all the template translations too, none there that are not regular interface text (no country or language names). |
Summary
Description of the change(s) you made
_(...)gettextthat would require strings that don't already exist in Django or are our own internal strings.Manual verification steps performed
Check that the server still runs fine.
Check that all language names are properly translated in the frontend language changing interfaces.