Skip to content

Learning Activity and Completion Criteria logic on when bulk editable#3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtibbles merged 1 commit into from
Oct 24, 2022
+16 −12
Merged

Learning Activity and Completion Criteria logic on when bulk editable #3763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions contentcuration/contentcuration/frontend/channelEdit/components/edit/DetailsTabView.vue
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@
<LearningActivityOptions
ref="learning_activities"
v-model="contentLearningActivities"
:disabled="isTopic"
:disabled="anyIsTopic"
@focus="trackClick('Learning activities')"
/>
<!-- Level -->
Expand DownExpand Up@@ -125,7 +125,7 @@
</VLayout>

<!-- Completion section for all resources -->
<VLayout v-if="!isTopic" row wrap class="section">
<VLayout v-if="!anyIsTopic && allSameKind" row wrap class="section">
<VFlex xs12>
<h1 class="subheading">
{{ $tr('completionLabel') }}
Expand All@@ -143,7 +143,7 @@
v-model="completionAndDuration"
:kind="firstNode.kind"
:fileDuration="fileDuration"
:required="!isDocument"
:required="!anyIsDocument || !allSameKind"
/>
</VFlex>
</VLayout>
Expand DownExpand Up@@ -528,9 +528,22 @@
allResources() {
return !this.nodes.some(node => node.kind === ContentKindsNames.TOPIC);
},
allSameKind() {
const kind = this.firstNode.kind;
return !this.nodes.some(node => node.kind !== kind);
},
anyIsDocument() {
return this.nodes.some(n => n.kind === ContentKindsNames.DOCUMENT);
},
anyIsTopic() {
return this.nodes.some(n => n.kind === ContentKindsNames.TOPIC);
},
isImported() {
return isImportedContent(this.firstNode);
},
newContent() {
return !this.nodes.some(n => n[NEW_OBJECT]);
},
importedChannelLink() {
return importedChannelLink(this.firstNode, this.$router);
},
Expand DownExpand Up@@ -706,15 +719,6 @@
videoSelected() {
return this.oneSelected && this.firstNode.kind === ContentKindsNames.VIDEO;
},
newContent() {
return !this.nodes.some(n => n[NEW_OBJECT]);
},
isDocument() {
return this.firstNode.kind === ContentKindsNames.DOCUMENT;
},
isTopic() {
return this.firstNode.kind === ContentKindsNames.TOPIC;
},
},
watch: {
nodes: {
Expand Down