Skip to content

Add task helpers and stop enqueuing storage calculation tasks for admins - #3852

Merged
rtibbles merged 5 commits into
learningequality:hotfixesfrom
bjester:angry-tasks
Nov 30, 2022
Merged

Add task helpers and stop enqueuing storage calculation tasks for admins#3852
rtibbles merged 5 commits into
learningequality:hotfixesfrom
bjester:angry-tasks

Conversation

@bjester

@bjesterbjester commented Nov 30, 2022

Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Adds method to CeleryTask class that help manage tasks in production using the celery control interface, and ensure task result is marked accordingly
  • Prevents storage calculation tasks from being enqueued for admins
  • Adds delay of storage calculation to cheffing API endpoint which handles bulk node creation
  • Adds management command that reconciles queued and active tasks with what's in the DB and any unapplied changes

Manual verification steps performed

  • Ran tests
  • Ran management command
  • Ran server and made a change to channel

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester
bjester marked this pull request as ready for review November 30, 2022 18:34
@bjesterbjester changed the title Add celery helpers and stop enqueuing storage calculation tasks for adminsAdd task helpers and stop enqueuing storage calculation tasks for adminsNov 30, 2022
@rtibbles
rtibbles merged commit 9d84374 into learningequality:hotfixesNov 30, 2022
@bjesterbjester mentioned this pull request Dec 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bjester@rtibbles