Uh oh!
There was an error while loading. Please reload this page.
Add caption support with new models, vuex, and edit modal integration - #4151
Add caption support with new models, vuex, and edit modal integration#4151akash5100 wants to merge 264 commits into
Conversation
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [fonttools](https://github.com/fonttools/fonttools) from 4.27.1 to 4.40.0. - [Release notes](https://github.com/fonttools/fonttools/releases) - [Changelog](https://github.com/fonttools/fonttools/blob/main/NEWS.rst) - [Commits](fonttools/fonttools@4.27.1...4.40.0) --- updated-dependencies: - dependency-name: fonttools dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [workbox-precaching](https://github.com/googlechrome/workbox) from 6.5.4 to 7.0.0. - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v6.5.4...v7.0.0) --- updated-dependencies: - dependency-name: workbox-precaching dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| queryset = queryset.filter(file_id__in=file_ids) | ||
| if file_id: | ||
| queryset = queryset.filter(file_id=file_id) |
There was a problem hiding this comment.
Similarly to the above comment, could you also check File.filter_edit_queryset here
There was a problem hiding this comment.
iffile_id:
allowed_file_id=set(
File.filter_edit_queryset(
File.objects.get(pk=file_id), self.request.user
)
.values_list("id", flat=True)
)
queryset=queryset.filter(file_id=allowed_file_id)Please check this.
I think there won't be comma seperated file_ids. (we don't actually use this query for now)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Description of the change(s) you made
This PR adds caption files and cues models leveraging the change event architecture. It also:
Frontend
Captionstab to the edit modal for managing and generating captions, visually controlled byfeature flagsvuexto manage the state for captions. Which is integrated into theEditModalandEditListcomponents.Backend
CaptionFileandCaptionCuemodels. The models leverage the change event architecture to track changes.Manual verification steps
TODO
References
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)