Uh oh!
There was an error while loading. Please reload this page.
added text truncate in import channel dropdown - #4186
Conversation
MisRob
commented
Jul 7, 2023
Thanks @Jaspreet-singh-1032 for another contribution, this is very helpful |
| } | ||
| .text-truncate-ellipsis { | ||
| max-width: 200px; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Hey @LianaHarris360, Thanks for the review. I have some queries. Without setting fixed width this does not seem to work because using ellipsis needs a specific width. What I am thinking is to pass a prop to the MultiSelect component that whether it should use ellipsis or not and if yes then what should be the max-width Let me know if you have any other suggestions!
There was a problem hiding this comment.
@Jaspreet-singh-1032 Good idea, that sounds like it should work!
LianaHarris360
left a comment
There was a problem hiding this comment.
The code changes all make sense and it looks great!

Summary
Fixes#4166
Screenshots (if applicable)
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)