Uh oh!
There was an error while loading. Please reload this page.
Fix channel revision overwrite on frontend user session - #4897
Merged
marcellamaki merged 2 commits intoFeb 5, 2025
Conversation
rtibbles
reviewed
Feb 5, 2025
rtibbles
left a comment
Member
There was a problem hiding this comment.
No concerns codewise - @marcellamaki has said she will do a quick manual test to confirm.
marcellamaki
approved these changes
Feb 5, 2025
marcellamaki
left a comment
Member
There was a problem hiding this comment.
After reviewing the steps to reproduce and some additional discussion with Blaine, manual QA confirms that the revs are either consistent or incrementing, and there isn't a 0 returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes#4896
Reviewer guidance
See STR in issue