Skip to content

Fix node details must be defined reference error - #4993

Merged
bjester merged 3 commits into
learningequality:hotfixesfrom
ozer550:fix-node-details-must-be-defined-error
Apr 16, 2025
Merged

Fix node details must be defined reference error#4993
bjester merged 3 commits into
learningequality:hotfixesfrom
ozer550:fix-node-details-must-be-defined-error

Conversation

@ozer550

@ozer550ozer550 commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

Summary

  • Fixed node undefined error by implementing retry loop to wait for vuex store to get populated.

References

closes#4763

Reviewer guidance

  • Open a channel and create a new exercise
  • Observe there are no reference error in the console anymore.

@ozer550
ozer550 requested review from bjester and rtibblesApril 8, 2025 07:17
@bjester

bjester commented Apr 8, 2025

Copy link
Copy Markdown
Member

@ozer550 Could you rebase this to hotfixes?

@bjesterbjester self-assigned this Apr 8, 2025
@ozer550
ozer550force-pushed the fix-node-details-must-be-defined-error branch from 40fced5 to 2d02768CompareApril 8, 2025 16:36
@ozer550
ozer550 changed the base branch from unstable to hotfixesApril 8, 2025 16:37
bjester
bjester approved these changes Apr 15, 2025
View reviewed changes

@bjesterbjester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and it works, but I think a code comment is warranted. I won't merge yet

Comment threadcontentcuration/contentcuration/frontend/channelEdit/vuex/assessmentItem/actions.js
@bjester
bjester merged commit ab12eab into learningequality:hotfixesApr 16, 2025
@bjesterbjester mentioned this pull request Apr 16, 2025
Closed
@pcenov

pcenov commented Apr 24, 2025

Copy link
Copy Markdown
Member

Tested at Hotfixes - the error described in #4763 is no longer happening. No regressions observed while regression testing.

@radinamaticradinamatic mentioned this pull request Apr 24, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjesterbjesterbjester approved these changes
@rtibblesrtibblesAwaiting requested review from rtibbles

Assignees

@bjesterbjester

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unstable - Create new exercise - ReferenceError: node details must be defined

3 participants

@ozer550@bjester@pcenov