Uh oh!
There was an error while loading. Please reload this page.
Make 'updateDescendants' true by default - #5075
Merged
rtibbles merged 1 commit intoNov 25, 2025
Merged
Conversation
marcellamakiforce-pushed
the
descendants-by-default
branch
from
May 27, 2025 14:29
60b23e3 to
71a4dc3Comparemarcellamaki
marked this pull request as draft
June 3, 2025 13:45
marcellamakiforce-pushed
the
descendants-by-default
branch
from
October 13, 2025 20:01
71a4dc3 to
bd2730bComparemarcellamaki
marked this pull request as ready for review
October 14, 2025 13:51
rtibbles
left a comment
Member
There was a problem hiding this comment.
Changes look correct, tests look fine - my only thought would be, don't we want this targeted to hotfixes, not unstable?
…fault in bulk/quick editing
marcellamakiforce-pushed
the
descendants-by-default
branch
from
November 24, 2025 14:20
bd2730b to
8311bdeComparertibbles
approved these changes
Nov 25, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets the default data value of
updateDescendantsto true, so that when bulk/quick editing, the checkbox is checked by default. This makes it less likely to get "missed" be editors.Tests were written by me for content and reviewed by claude to get the syntax right
References
Fixes#5043
Screen.Recording.2025-05-23.at.10.40.58.AM.mov
Reviewer guidance
Navigate into a channel and check each bulk editing action modal:
For each, the checkbox for applying to the resources and folders within a folder should be checked by default.