Add focus trapping to resource preview side panel - #5505

Merged

akolson merged 6 commits into

learningequality:hotfixesfrom

AllanOXDi:focus-on-me

Oct 30, 2025

AllanOXDi commented Oct 23, 2025

Contributor

Summary

This PR fixes focus trapping to resource preview side panel

Before

focus-resource-preview-sidebar.mp4

After

Screen.Recording.2025-10-23.at.21.54.00.mov

References

Reviewer guidance

Sign in to Hotfixes with an account with enabled search recommendations
Go to a channel and try to import resources from other channels
Open the side panel for a selected resource

AllanOXDi requested review from AlexVelezLl and akolson

October 23, 2025 19:02

pcenov commented Oct 27, 2025

Member

Hi @AllanOXDi and @AlexVelezLl, noticed that this PR is with status 'Needs QA' but we can only test it either at unstable or hotfixes so I'm changing the status to "In review" instead.

akolson commented Oct 27, 2025

Member

Hi @pcenov! This should be testable once merged to the hotfixes. We'll let you know once its ready for QA review. Thanks

akolson reviewed

View reviewed changes

contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue Outdated

akolson reviewed

View reviewed changes

contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue Outdated

akolson reviewed

View reviewed changes

contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue Outdated

akolson reviewed

View reviewed changes

akolson left a comment

Member

Hey Allan! Manual QA and code LGTM! Just a few suggestions on clean up and we should be good. Thanks!

AllanOXDi requested a review from akolson

October 28, 2025 15:09

akolson reviewed

View reviewed changes

contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue Outdated

akolson reviewed

View reviewed changes

contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue Outdated

akolson reviewed

View reviewed changes

contentcuration/contentcuration/frontend/channelEdit/components/ResourcePanel.vue Outdated

AllanOXDi requested a review from akolson

October 28, 2025 16:01

akolson approved these changes

View reviewed changes

akolson left a comment

Member

LGTM! Thanks @AllanOXDi

akolson requested changes

View reviewed changes

akolson left a comment

Member

Not sure why the build is failing, will add a blocker to avoid an accidental merge. Has nothing to do with the code. Seems like some python dependency is failing for some reason!

akolson commented Oct 28, 2025

Member

@rtibbles any idea why this build is failing?

akolson commented Oct 30, 2025

Member

Hey @AllanOXDi! could you please rebase this pr? Thanks

AllanOXDi force-pushed the focus-on-me branch from ceca3e8 to 546cd43Compare

October 30, 2025 12:09

AllanOXDi commented Oct 30, 2025

ContributorAuthor

Done!

akolson approved these changes

View reviewed changes

akolson left a comment •
edited
Loading

Member

LGTM! Merging into hotfixes next patch release. Thanks @AllanOXDi

akolson merged commit c49d767 into learningequality:hotfixes

13 checks passed

akolson mentioned this pull request

Hotfixes - Follow-up to "add focus trapping to resource preview side panel" #5406

Closed

marcellamaki mentioned this pull request

Studio patch release v2025.12.02 #5557

Merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment