Uh oh!
There was an error while loading. Please reload this page.
Revert "Temporarily hide draft button." - #5856
Merged
Merged
Conversation
rtibblesforce-pushed
the
show_me_button
branch
2 times, most recently
from
April 21, 2026 22:57
b45fd6a to
fa0a6c4Compare
AlexVelezLl
left a comment
Member
There was a problem hiding this comment.
Code changes make sense, and manual QA checks out! Just a little question regarding the waitForPublishingDraft method.
| this.isPublishingDraft = true; | ||
| this.publishStagingChannel() | ||
| .then(publishDraftchange => Channel.waitForPublishingDraft(publishDraftchange)) |
Member
There was a problem hiding this comment.
Was there a reason to remove this line? It was kind of helpful to know that draft publishing was still in progress.
MemberAuthor
There was a problem hiding this comment.
The method doesn't exist any more - the publish method now includes this wait (I deleted it because otherwise the publish showed an error immediately, trying to invoke a non-existent method).
…ging draft publishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit 9564806.
Reverts the PR that temporarily hid the "Publish draft" button on staging channels
Adds toggle by feature flag instead
Removes call to deleted function that had been absorbed into the draft publish function that was already being called.
References
Reverts #5652
Reviewer guidance
Did I delete
v-if="false"correctly?AI usage
None - crafted with my own two hands!