Skip to content

Added emojis - #58

Open
Rudra-Choubey wants to merge 11 commits into
leopardslab:masterfrom
Rudra-Choubey:added-emojis
Open

Added emojis#58
Rudra-Choubey wants to merge 11 commits into
leopardslab:masterfrom
Rudra-Choubey:added-emojis

Conversation

@Rudra-Choubey

Copy link
Copy Markdown

I have added emojis to the cli

@TRomeshTRomesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not put import statements here like this they should be done on the top. Refactor the code.

Comment threadlib/compute.js Outdated
this._compute = ncProviders.azure.compute(options);
} else {
throw new Error("Please specify a provider by flag -p --provider");
const emoji = require("node-emoji");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not put import statements here like this they should be done on the top.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since its a common thing you can move it to helper.js and import it as a function

Comment threadlib/database.js Outdated
this._database = nodecloud.azure.compute(options);
} else {
throw new Error("Please specify a provider by flag -p --provider");
const emoji = require("node-emoji");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not put import statements here like this they should be done on the top.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since its a common thing you can move it to helper.js and import it as a function

Comment threadlib/network.js Outdated
@@ -1,26 +1,27 @@
class Network {
constructor(program, nodecloud, options) {
const emoji = require("node-emoji");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not put import statements here like this they should be done on the top.

Comment threadREADME.md Outdated

nodecloud-cli is an unified command line interface for open cloud based on [nodecloud](https://github.com/cloudlibz/nodecloud). nodecloud-cli supports cloud providers like AWS, Azure, GCP and many more.

Very Simple to Use.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the change to README.md

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Rudra-Choubey@JaDogg@TRomesh@Ajaychoubey