PYL-26 software design improvement separate domain code from cli - #13
Merged
lesaint merged 4 commits intoApr 29, 2024
Conversation
lesaintforce-pushed
the
sebastienlesaint/pyl-26-software-design-improvement-separate-domain-code-from-cli
branch
from
April 29, 2024 21:25
6f3372c to
f3c0e3bCompare
|
lesaint
deleted the
sebastienlesaint/pyl-26-software-design-improvement-separate-domain-code-from-cli
branch
April 29, 2024 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
Currently, domain code is mix with code related to console interaction (ie. calls to print and input).
This creates complexity in both readability and testing. It also prevents future improvements where a User Interface will be used instead of a Command Line Interface.
WHAT
No more call to input and printshould exist in module pylms.pylms
HOW