Uh oh!
There was an error while loading. Please reload this page.
CI: Bump allow-list pin and quieten repeat summaries - #92
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Four release example workflows still explicitly use the superseded v0.16.0 allow-list pin.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates CI workflow allow-list references and reduces duplicate job summaries.
Changes:
- Pins the shared allow-list to v0.16.1.
- Suppresses repeated allow-list summaries after each workflow’s first invocation.
- Leaves four release examples on the stale v0.16.0 pin.
File summaries
| File | Description |
|---|---|
.github/workflows/release-drafter.yaml | Updates the direct allow-list reference. |
.github/workflows/build-test.yaml | Updates the default pin and suppresses repeated summaries. |
.github/workflows/build-test-multiarch.yaml | Updates the default pin and suppresses repeated summaries. |
.github/workflows/build-test-release.yaml | Updates release workflow configuration. |
.github/workflows/build-test-release-multiarch.yaml | Updates multi-architecture release configuration. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
1f79bd6 to
dbcf9c7CompareThere was a problem hiding this comment.
🟡 Changes recommended
Each release example still emits duplicate local allow-list summaries from its two publishing jobs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 4
- Review effort level: Balanced
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Two unrelated pieces of workflow housekeeping. The harden-runner allow-list now points at v0.16.1 of the shared lfreleng-actions/.github list. Both forms that carry the reference move together: the harden_runner_allowlist input default and the literal config pin in the workflows that do not take that input. Every job also loaded the allow-list and wrote the same static block to the job summary, so a caller of one of these workflows saw it once per job rather than once per run. The action already exposes allow_list_summary for this, so the block is suppressed everywhere except the first invocation in each file: what a job hardened against is worth stating, but only the first time anyone reads it. Reusable workflows cannot see beyond themselves, so this is once per workflow rather than once per run. A caller invoking several still gets one block from each, which is a large reduction on one per job and as far as a workflow can enforce on its own behalf. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
dbcf9c7 to
e5f146bCompare
zxiiro
left a comment
There was a problem hiding this comment.
🤖 Auto-approved by agent: code-reviewed low risk. Same allow-list pin bump (v0.16.0→v0.16.1) + allow_list_summary:false as the noon series; Multi-Arch CI now green.
51bf5cd
into
lfreleng-actions:mainUh oh!
There was an error while loading. Please reload this page.
CI: Bump allow-list pin and quieten repeat summaries
Two pieces of workflow housekeeping, applied identically across the
*-workflowsestate.1. Allow-list pin → v0.16.1
Repoints the shared
lfreleng-actions/.githuballow-list atec0736244fc776e326283c6af6840e30f316f63c(v0.16.1), up from v0.16.0.Both forms that carry the reference move together:
allow_list.txt@harden_runner_allowlistinput defaultconfig: '@'release-drafter.yaml)The four release examples under
examples/carry their own copy of thepin in a
HARDEN_RUNNER_ALLOWLISTenv var, which their publishing jobspass to the loader. Those move too, so a caller copying an example does
not inherit a stale pin.
2. One allow-list summary per workflow
Every job loads the allow-list, and each invocation wrote the same static
block to the job summary — once per job rather than once per run,
crowding out the build, test and audit output a reader came for.
The action already exposes
allow_list_summaryfor exactly this, so thisis configuration rather than a change to it. Suppressed everywhere except
the first invocation in each file.
The most invocations in the estate. Per file:
build-test-release-multiarch.yamlgoes from 10 blocks to 1,build-test-release.yamlfrom 9 to 1, and bothbuild-test.yamlandbuild-test-multiarch.yamlfrom 6 to 1.The release examples get the same treatment: each has two local loader
invocations (
test-pypithenpypi), so the second is suppressed anda copied caller emits one local block rather than two.
Scope note: once per workflow, not once per run
These are
workflow_callreusable workflows, so they cannot see beyondthemselves. A caller invoking several still receives one block from each.
That is as far as a reusable workflow can enforce on its own behalf — a
large reduction on one per job, but not literally one per run, so worth
stating rather than implying.
Validation
actionlintclean on every workflow;zizmorreports no findings; allprekhooks pass;aislop ci --changes --base upstream/main→ 0 errors,0 warnings. Verified that no stale allow-list SHA remains and that
exactly one invocation per file still emits.