Skip to content

Fixes #1217 - #1218

Closed
golsby wants to merge 7 commits into
libgit2:vNextfrom
golsby:vNext
Closed

Fixes #1217#1218
golsby wants to merge 7 commits into
libgit2:vNextfrom
golsby:vNext

Conversation

@golsby

Copy link
Copy Markdown
Contributor

Added CustomHeaders member to GitPushOptions to match underlying c struct for marshalling.
Added tests suggested by @nulltoken to PushFixture.cs

Added CustomHeaders member to GitPushOptions to match underlying c struct for marshalling.
Added tests suggested by @nulltoken to PushFixture.cs
@nulltoken

Copy link
Copy Markdown
Member

Awesome!!

@golsby Actually, even if that seems a bit strange, I'd be in favor of dropping the test. Those kind of tests cannot be relied on as we need to run them manually (because of creds one wouldn't see to be committed).

Could you please rewrite your commit and remove the test from it?

While you're at it, I'd really prefer if you could put what the commit does in the first line (as this is what is being shown when doing a git log)

Maybe something like this?

Add CustomHeaders member to GitPushOptions
Fix #1217

Vogel612and others added 6 commits November 12, 2015 08:31
The default prettifying behabiour now is: do not prettify
Documentation for the new property of RewriteHistoryOptions
Added CustomHeaders member to GitPushOptions to match underlying c struct for marshalling.
Added tests suggested by @nulltoken to PushFixture.cs
@pearswj

Copy link
Copy Markdown

Tidied up and resubmitted in #1233 on behalf of @golsby. @nulltoken, please close this PR.

@nulltoken

Copy link
Copy Markdown
Member

Supersed by #1233.

Cheers!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@golsby@nulltoken@pearswj@Vogel612