Uh oh!
There was an error while loading. Please reload this page.
Update NativeBinaries to libgit2 0.27.7 - #1639
Conversation
ethomson
commented
Nov 6, 2018
sigh |
bording
commented
Nov 6, 2018
Uh oh, any idea what the caused the failures? |
ethomson
commented
Nov 7, 2018
Not exactly. I encountered this over in #1618, which is that our smart subtransport implementation wasn't quite complete. (In particular, libgit2 can provide a null URL to indicate that you should reconnect.) What's not clear to me is why this suddenly started. I suspect something changed subtly in 0.27.7 - that seems more likely than suddenly a change to GitHub triggering an existing bug in LibGit2Sharp - but I'm not sure what changed yet. In the meantime, I'll cherry-pick the fixes that I made in the other branch. |
ethomson
commented
Nov 7, 2018
I'm going to hold off on merging this until I do track down the root cause tonight, in case it's a behavior change that we think should be addressed in libgit2. |
10aa8c2 to
4271690Compareethomson
commented
Nov 7, 2018
Yep, was a change in behavior that I accidentally introduced in libgit2 and made it into 0.27.7. Fixing that change over there, then I'll do a proper native binaries build. Oops. |
4271690 to
e7e41d7Compare
No description provided.