Skip to content

Adjust GitStatusOptions to match structure of native libgit2 - #1884

Merged
bording merged 1 commit into
libgit2:masterfrom
Molytho:master
Jun 17, 2021
Merged

Adjust GitStatusOptions to match structure of native libgit2#1884
bording merged 1 commit into
libgit2:masterfrom
Molytho:master

Conversation

@Molytho

Copy link
Copy Markdown
Contributor

This fixes a marshaling bug that causes a segmentation fault

This mismatch caused dotdevelop's git module to crash.
More about this can be found here:
dotdevelop#2

This fixes a marshaling bug that causes a segmentation fault
@codecov-commenter

codecov-commenter commented May 25, 2021

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (df3b22a) to head (b78b290).
Report is 187 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #1884 +/- ##
=======================================
Coverage 84.60% 84.61% =======================================
Files 231 231 Lines 9174 9175 +1 =======================================
+ Hits 7762 7763 +1 
Misses 1412 1412 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefanloerwald

Copy link
Copy Markdown

Can we get this merged soon? Turns out this is the reason every status query fails with the most recent dotnet runtime (5.0.7).

Thanks!
Stefan

@stefanloerwald

Copy link
Copy Markdown

Hi @bording, I'm tagging you here, because you seem to be the member of libgit2 who most recently interacted with this repository. Quite a few people are affected by this issue here. Any chance you can release a new (preview) version after merging this PR?

Thanks
Stefan

@bording
bording merged commit 689dcf2 into libgit2:masterJun 17, 2021
@bording

Copy link
Copy Markdown
Member

This change has been published as 0.27.0-preview-0100.

@stefanloerwald

Copy link
Copy Markdown

Thank you so much, @bording. Now libgit2sharp is working again with the most recent dotnet runtime. Awesome!

ddunkin added a commit to FacilityApi/FacilityJavaScript that referenced this pull request Jun 21, 2021
ddunkin added a commit to ddunkin/FaithlifeBuild that referenced this pull request Jun 21, 2021
Includes a fixlibgit2/libgit2sharp#1884 for `AccessViolationException` on .NET SDK 5.0.7.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Molytho@codecov-commenter@stefanloerwald@bording