Uh oh!
There was an error while loading. Please reload this page.
Adds Depth to FetchOptions allowing for shallow cloning - #2070
Conversation
twltwk
commented
Feb 21, 2024
Hello, what's next for this pull request ? |
andersklepaker
commented
Feb 22, 2024
Someone needs to review and approve it I guess. Not sure if this is something @bording could do? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
andersklepaker
commented
Apr 10, 2024
@amirvenus Do you have write-access and can get this merged? |
goaaats
commented
May 26, 2024
Do the unresolved comments block this PR? If the original creator is not around to address them, would it be acceptable for someone else to take over and create a new PR? |
YanisThePie
commented
Jul 2, 2024
so what are the news about this PR? |
dcworldwide
commented
Aug 14, 2024
If practical or required, I'm available to help. Just LMK what I can do. We are streaming git repo state across a distributed CD/CI system and shallow clones dramatically reduce our bandwidth needs. |
sureshkk
commented
Aug 29, 2024
Is there any updates on this PR? |
karlschriek
commented
Sep 4, 2024
Just to repeat @YanisThePie 's question from earlier. Are any of the comments on the PR actually blocking the merge? I think there may be some arguments that this could go through as it is. If a maintainer could provide feedback and clarify whether adjustments are needed that would be great. If indeed necessary I would be happy to open up a new PR if @andersklepaker is no longer dealing with this. |
andersklepaker
commented
Sep 4, 2024
Thanks for the comments @karlschriek
Yeah that would be great, and if so happens I'll finish up the work needed for this PR. I did not prioritize investing time here since this repo seems mostly inactive, sadly :( |
IEDAWHI
commented
Sep 12, 2024
Are there any further updates? It would be greatly appreciated if this PR could be merged soon assuming there are no open comments or code changes required. |
Please, can someone do something about this forgotten PR?... @amirvenus could you merge this please? |
YanisThePie
commented
Oct 29, 2024
thanks @amirvenus for your approval! Are there still steps to go through before the PR is merge? |
PulsarFX
commented
Oct 30, 2024
@karlschriek I think this PR can now be completed? 🤞 |
akirayamamoto
commented
Nov 5, 2024
@bording can you merge this PR? |
kristianbjensen
commented
Nov 14, 2024
Please merge. We have been missing this feature :) |
jhested
commented
Nov 18, 2024
Would also appreciate if this can be merged |
gemolnar
commented
Nov 19, 2024
It would be great if this could be merged. |
YanisThePie
commented
Nov 19, 2024
Is this git repo still maintained? |
andersklepaker
commented
Nov 20, 2024
This repo is still maintained even tho it is moving very slow. It's a open source project and we can't demand anything. Maintainers are free to do whatever they like, and that is totallly fine. But i'll admit that some kind of feedback from the maintainers would probably not hurt, as a few people have spent time on this PR. |
bording
commented
Nov 20, 2024
Hey everyone. @andersklepaker gets to the heart of things. I'm pretty much the only one left who maintains this repo these days, and I just don't have much free time to devote to it. This PR does seem to be one that a lot of people are asking for, so I'll try and review it soon. |
DomKodes
commented
Nov 22, 2024
Thanks a lot @bording. This merge would enable some interesting scenarios, e.g. saving time and space fetching new repositories, so I'm looking forward to the review as well. |
bording
commented
Nov 23, 2024
Thanks for the PR and thanks for your patience! |
YanisThePie
commented
Nov 23, 2024
@bording thanks for your hard work on this amazing project ! |
Thanks to libgit2#2070, it is now possible to Clone with shallow depth. In some cases you'd want to unshallow. The current workaround is to delete the local repo and re-Clone with full depth. To avoid this un-necessary step, the Depth could be respected by Fetch, the same way it is doing it for Clone. This patch works for the cases I tested (don't forget to check `repo.Info.IsShallow`), but it seems too simple and I don't know what would be required to test and implement it properly. So I'd like to ask for help on this, thanks.
This PR adds
DepthtoFetchOptionsallowing for shallow cloning.Since I'm new to this repo and it's complexity it's possible i've missed some key information to why this have not been implemented, and if so I'm sorry for not reading up on it prior to submitting this PR.
Resolves#229