[Xcode 7] Add types to collections in GT headers by JrGoodle · Pull Request #516 · libgit2/objective-git

JrGoodle · 2015-08-28T07:25:56Z

This adds support for generics with typed collections added in Xcode 7. The .travis.yml is updated to use the Xcode 7 beta images.

phatblat · 2015-08-28T12:43:49Z

Awesome! As for Travis, the xcode7 image is only available for private repos. So this PR will need to wait to merge until that's available and we're ready to make this project require Xcode 7. I imagine both of these will happen on or shortly after September 9.

JrGoodle · 2015-08-28T15:04:29Z

That's totally fine to wait until the official Xcode 7 release before merging, I was kind of assuming that. The Travis CI folks actually made the xcode7 image available for OSS repos as well yesterday. I'm not sure why the build is failing. It was timing out during the Mac tests, but now when I added travis_wait it can't find that function. I'll remove that commit, and you can probably see the timeout failure once that build runs. Maybe you'll have some insight.

phatblat · 2015-08-29T19:15:05Z

Oh, nice! Missed that we can now use Xcode 7.

The build failed due to a 10m timeout waiting for the tests to finish. Seems like something got stuck as this build ran for 28m before being terminated while other builds take around ~20m. Looks like the tests typically take 2.5m.

We just recently got Travis builds going again. #495 resolved the original timeout issues, but it's possible that something is different now with Xcode 7 and/or the updated versions of Quick/Nimble.

I'm not sure what's going on so I've emailed Travis support to see if they can help.

JrGoodle · 2015-08-29T23:25:46Z

Thanks for emailing Travis about this. I'll keep checking for further updates to the Nimble/Quick projects in case those are related to the timeout.

FWIW, I ran the ObjectiveGit Mac tests locally in Xcode, and they passed. Figured I'd add that data point in case it helps narrow down the source of the issue.

phatblat · 2015-08-31T16:10:49Z

Got a response from Travis:

Sorry about the timeouts, we've received a few reports about this and I think we've found a workaround for it, which we're planning to apply to our image in the next few days. In the meantime, you could try adding these three files to the repository, and run the instruments-auth.sh file before running the tests, which in our experience has fixed the issue for everyone who has seen it.

JrGoodle · 2015-08-31T19:55:04Z

Awesome, thanks! Trying it out now.

JrGoodle · 2015-09-11T10:32:18Z

https://twitter.com/grayj_/status/623082333898313728

So with the updated Travis image using the Xcode 7 GM and a newer version of xctool, the tests aren't timing out anymore. It looks like the new exception being raised might not be fixed until xctool is officially updated for Xcode 7: facebookarchive/xctool#528

phatblat · 2015-09-14T14:59:47Z

It sounds like there may be a fix for Xcode 7 in the upcoming xctool 0.2.6, but I had trouble verifying whether it will address our issues. I built xctool using Xcode 7 GM, so that may have been the problem, but it just stalled out when the ObjectiveGit build started. @JrGoodle could you try building xctool from HEAD and see if the upcoming fixes will address these issues?

We either need to wait for xctool to resolve these issues with Xcode 7 or switch to just using xcodebuild for the build.

JrGoodle · 2015-09-14T15:14:32Z

sure thing. I'll give xctool from HEAD a go. if that doesn't work, I saw mention of xcodebuild + xcpretty elsewhere, so I can try that.

pietbrauer · 2015-09-14T15:43:47Z

I would definitely give xcodebuild + xcpretty a chance. I've only had problems with xctool in the past.

JrGoodle · 2015-09-14T16:32:37Z

After building xctool from HEAD, the tests are stalling out again. I started to look at moving to xcodebuild, but the cibuild script seems to be fairly dependent on xctool and I don't fully grok everything going on in it. I can continue to look into it, but it might be better for someone more familiar with this piece to migrate to xcodebuild and xcpretty in a separate PR, and I could just merge that change in here when it's in place upstream. thoughts?

phatblat · 2015-09-14T17:28:42Z

I can tackle the cibuild script changes unless @pietbrauer gets to it first.

pietbrauer · 2015-09-14T17:29:46Z

I could do it, you are more of a programmer than I am 😆

phatblat · 2015-09-14T17:32:05Z

LOL

I could do it, you are more of a programmer than I am 😆

JrGoodle · 2015-09-14T17:40:00Z

haha, sounds good. there's obviously no rush on this generics thing, so I'll just keep watch for the ci script changes for Xcode 7. seems like quite a few projects may be going the way of xcodebuild + xcpretty to get around this Xcode 7 issue. modularity ftw

Update Nimble to `master` branch and Quick to `swift-2.0` branch

Attempt to fix test timeouts with most recent commits on xctool's master branch

JrGoodle · 2015-09-22T12:18:24Z

@phatblat After updating xctool again to the latest from the master branch, and updating Quick for an Xcode7/xctool fix, the Travis build made it farther than previously. It still failed, but I'm not exactly sure why. I see that the iOS framework build fails early on due to code signing, but the Travis build still continues. The tests seem to have run, but I don't see a clear indicator at the end of why the overall build failed. You might want to take a look and see if anything jumps out at you.

Contains commit related to Xcode7/xctool

Attempting solution from: http://stackoverflow.com/questions/27671854/travis-ci-fails-to-build-with-a-code-signing-error

JrGoodle · 2015-09-23T11:03:51Z

phatblat · 2015-09-24T04:09:44Z

Woah, nice work! 🎉

Can we remove the custom xctool install from .travis.yml or is that still necessary?

JrGoodle · 2015-09-24T05:17:15Z

It's still necessary at this point. There was a commit after the last release that fixed the timeout when the tests were run (I believe it was this one: facebookarchive/xctool@0f3ab7b). If you want to wait until the next official release before merging this so that custom install step can be removed that would be fine.

phatblat · 2015-09-25T03:30:28Z

Yeah, I'm nervous about leaving --HEAD in there as we'll probably forget about it.

JrGoodle · 2015-09-25T03:35:40Z

ok, understandable. hopefully they'll come out with a new release soon to get that fix out. I'll keep my eyes peeled for it.

joshaber · 2015-09-25T14:06:51Z

Really great work!

joshaber · 2015-10-23T14:34:09Z

#yolo

[Xcode 7] Add types to collections in GT headers

joshaber · 2015-10-23T14:34:37Z

Thanks again! Fantastic work.

phatblat · 2015-10-28T04:29:06Z

💖

JrGoodle · 2015-10-28T05:31:48Z

cool, thanks for posting that. it's not too often that warnings and errors are actually a nice thing to see. 😻

phatblat self-assigned this Aug 28, 2015

phatblat added the enhancement label Aug 28, 2015

phatblat changed the title ~~Add types to collections in GT headers~~[Xcode 7] Add types to collections in GT headersSep 14, 2015

pietbrauer mentioned this pull request Sep 14, 2015
Switch CI script to xcodebuild + xcpretty #520
Closed

phatblat mentioned this pull request Sep 17, 2015
[Xcode 7] Switch cibuild to use xcodebuild and xcpretty #521
Closed

JrGoodle added 10 commits September 18, 2015 23:30

Update osx_image to xcode7 in .travis.yml
d930a5b

GTBlame typed collections
5e7801d

GTBranch typed collections
030c0d3

GTCommit typed collections
0baccf4

GTConfiguration typed collections
36618ff

GTEnumerator typed collections
16e404f

GTIndex typed collections
25490c0

GTRemote typed collections
6e5cb50

GTRepository typed collections
3fd3b21

GTTree typed collections
87b82c2

JrGoodle added 2 commits September 18, 2015 23:30

Update Nimble and Quick submodules
0932b06
Update Nimble to `master` branch and Quick to `swift-2.0` branch

Install xctool from master
e95cd59
Attempt to fix test timeouts with most recent commits on xctool's master branch

JrGoodle added 2 commits September 23, 2015 00:52

Update Quick submodule
0adedcd
Contains commit related to Xcode7/xctool

Disable code signing during build
dca46ad
Attempting solution from: http://stackoverflow.com/questions/27671854/travis-ci-fails-to-build-with-a-code-signing-error

phatblat mentioned this pull request Oct 6, 2015
Xcode 7 + silence stupid warning #523
Merged

joshaber added a commit that referenced this pull request Oct 23, 2015
Merge pull request#516from JrGoodle/generics-headers
9219175
[Xcode 7] Add types to collections in GT headers

joshaber merged commit 9219175 into libgit2:masterOct 23, 2015

JrGoodle deleted the generics-headers branch October 25, 2015 02:59

pietbrauer mentioned this pull request Dec 31, 2015
Release 0.9.0 #536
Closed

Uh oh!

Conversation

JrGoodle commented Aug 28, 2015

Uh oh!

phatblat commented Aug 28, 2015

Uh oh!

JrGoodle commented Aug 28, 2015

Uh oh!

phatblat commented Aug 29, 2015

Uh oh!

JrGoodle commented Aug 29, 2015

Uh oh!

phatblat commented Aug 31, 2015

Uh oh!

JrGoodle commented Aug 31, 2015

Uh oh!

JrGoodle commented Sep 11, 2015

Uh oh!

phatblat commented Sep 14, 2015

Uh oh!

JrGoodle commented Sep 14, 2015

Uh oh!

pietbrauer commented Sep 14, 2015

Uh oh!

JrGoodle commented Sep 14, 2015

Uh oh!

phatblat commented Sep 14, 2015

Uh oh!

pietbrauer commented Sep 14, 2015

Uh oh!

phatblat commented Sep 14, 2015

Uh oh!

JrGoodle commented Sep 14, 2015

Uh oh!

JrGoodle commented Sep 22, 2015

Uh oh!

JrGoodle commented Sep 23, 2015

Uh oh!

phatblat commented Sep 24, 2015

Uh oh!

JrGoodle commented Sep 24, 2015

Uh oh!

phatblat commented Sep 25, 2015

Uh oh!

JrGoodle commented Sep 25, 2015

Uh oh!

joshaber commented Sep 25, 2015

Uh oh!

joshaber commented Oct 23, 2015

Uh oh!

joshaber commented Oct 23, 2015

Uh oh!

phatblat commented Oct 28, 2015

Uh oh!

JrGoodle commented Oct 28, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants