Uh oh!
There was an error while loading. Please reload this page.
Ds 5114 update the aws secrets provider to aws sdk v2 - #76
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
adityadani
left a comment
There was a problem hiding this comment.
looks good once the integration tests are fixed.
| } | ||
| providers = append(providers, ec2RoleProvider) | ||
| } else if runningOnEc2 { |
There was a problem hiding this comment.
Curious, does AWS not allow chaining of providers anymore? Previously we were able to add EnvProvider and RoleProvider together. With this change we won't since each provider is in its own if condition.
| // Delete of a key that exists should succeed | ||
| err := a.s.DeleteSecret(a.secretIdWithData, nil) | ||
| keyContext := make(map[string]string) | ||
| keyContext[SecretRetentionPeriodInDaysKey] = "7" |
There was a problem hiding this comment.
If you ad a retention period then the subsequent GetSecret check is going to fail ? The integration tests are failing for SecretsManager. Can you check?
What this PR does / why we need it:
In this PR we have updated the packages used from aws sdk version 1 to aws sdk version 2. This has been made to maintain consistency in using the same aws sdk version across libopenstorage/secrets and portworx/pds-api repositories.
Which issue(s) this PR fixes (optional)
Closes #DS-5114
Special notes for your reviewer: