Skip to content

add: yamux - #268

Merged
salmad3 merged 9 commits into
masterfrom
mux/yamux
Jan 31, 2023
Merged

add: yamux#268
salmad3 merged 9 commits into
masterfrom
mux/yamux

Conversation

@salmad3

@salmad3salmad3 commented Dec 7, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Context

Notes

  • Section this document lives under will become populated with corresponding PRs

Latest preview

Please view the latest Fleek preview here.

@salmad3salmad3 added the ready for review PR is ready for review label Dec 7, 2022
marten-seemann
marten-seemann reviewed Dec 7, 2022
View reviewed changes

@marten-seemannmarten-seemann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a paragraph saying that yamux is the better choice than mplex, similar to what I suggested adding to mplex?

We've had people in the past use mplex instead of yamux, just because they weren't aware of the differences, and it would be nice if we could point them into the right direction.

Comment threadcontent/concepts/multiplex/yamux.md Outdated
Comment threadcontent/concepts/multiplex/yamux.md Outdated
@salmad3salmad3 added change request PR requires changes. and removed ready for review PR is ready for review labels Dec 8, 2022
@salmad3salmad3 added ready for review PR is ready for review and removed change request PR requires changes. labels Dec 12, 2022
marten-seemann
marten-seemann reviewed Dec 12, 2022
View reviewed changes
Comment threadcontent/concepts/multiplex/yamux.md Outdated
Comment threadcontent/concepts/multiplex/yamux.md Outdated
Comment threadcontent/concepts/multiplex/yamux.md Outdated
Comment threadcontent/concepts/multiplex/yamux.md Outdated
Comment threadcontent/concepts/multiplex/yamux.md Outdated
@salmad3

salmad3 commented Dec 19, 2022

Copy link
Copy Markdown
ContributorAuthor

@marten-seemann can be checked again.

marten-seemann
marten-seemann reviewed Jan 11, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/yamux.md Outdated
Comment threadcontent/concepts/multiplex/yamux.md Outdated
@salmad3@marten-seemann
Apply suggestions from code review
4bf2281
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
marten-seemann reviewed Jan 24, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/yamux.md
Comment threadcontent/concepts/multiplex/yamux.md
Comment threadcontent/concepts/multiplex/yamux.md Outdated
Comment threadcontent/concepts/multiplex/yamux.md Outdated
salmad3and others added 2 commits January 24, 2023 06:38
@salmad3@marten-seemann
Apply suggestions from code review
8abb607
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@salmad3
incorporate PR feedback + edits
643faf6
@aschmahmannaschmahmann mentioned this pull request Jan 25, 2023
Closed
@salmad3salmad3 added the P1 High label Jan 26, 2023
marten-seemann
marten-seemann approved these changes Jan 31, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/yamux.md Outdated
Comment threadcontent/concepts/multiplex/yamux.md Outdated
@salmad3salmad3 removed P1 High ready for review PR is ready for review labels Jan 31, 2023
@salmad3@marten-seemann
Apply suggestions from code review
2536a9a
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@salmad3
salmad3 merged commit 6837d95 into masterJan 31, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marten-seemannmarten-seemannmarten-seemann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Populate yamux stream muxer doc

2 participants

@salmad3@marten-seemann