Skip to content

add: mplex - #269

Merged
salmad3 merged 7 commits into
masterfrom
mux/mplex
Jan 31, 2023
Merged

add: mplex#269
salmad3 merged 7 commits into
masterfrom
mux/mplex

Conversation

@salmad3

@salmad3salmad3 commented Dec 7, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Context

Notes

  • Section this document lives under will become populated with corresponding PRs

Latest preview

Please view the latest Fleek preview here.

@salmad3salmad3 added the ready for review PR is ready for review label Dec 7, 2022
marten-seemann
marten-seemann reviewed Dec 7, 2022
View reviewed changes

@marten-seemannmarten-seemann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a section saying that until recently, the reason mplex was still supported was compatibility with js-libp2p, which didn't have yamux support yet. Now that js-libp2p has gained yamux support (link to the release), there's really no good reason to still support mplex, unless you need to deal with legacy nodes. For all other use cases, yamux would be the better choice.

Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
@salmad3salmad3 added change request PR requires changes. and removed ready for review PR is ready for review labels Dec 9, 2022
@salmad3salmad3 added ready for review PR is ready for review and removed change request PR requires changes. labels Dec 12, 2022
marten-seemann
marten-seemann reviewed Dec 12, 2022
View reviewed changes
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
salmad3and others added 3 commits December 12, 2022 17:08
@salmad3@marten-seemann
Apply suggestions from code review
a26bd78
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@salmad3
incorporate pr feedback
01fd625
@salmad3
edits
45d865f
@salmad3

salmad3 commented Dec 19, 2022

Copy link
Copy Markdown
ContributorAuthor

@marten-seemann can be checked again.

marten-seemann
marten-seemann reviewed Jan 24, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
@salmad3salmad3 added the P1 High label Jan 26, 2023
marten-seemann
marten-seemann approved these changes Jan 31, 2023
View reviewed changes

@marten-seemannmarten-seemann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to go once the suggestions have been incorporated :)

Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
Comment threadcontent/concepts/multiplex/mplex.md Outdated
@salmad3@marten-seemann
Apply suggestions from code review
b23c61a
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@salmad3salmad3 removed P1 High ready for review PR is ready for review labels Jan 31, 2023
@salmad3
salmad3 merged commit 4645648 into masterJan 31, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marten-seemannmarten-seemannmarten-seemann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Populate mplex stream muxer doc

2 participants

@salmad3@marten-seemann