Skip to content

add: quic muxer - #271

Merged
salmad3 merged 6 commits into
masterfrom
mux/quic
Jan 24, 2023
Merged

add: quic muxer#271
salmad3 merged 6 commits into
masterfrom
mux/quic

Conversation

@salmad3

@salmad3salmad3 commented Dec 7, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Context

Notes

  • Section this document lives under will become populated with corresponding PRs

Latest preview

Please view the latest Fleek preview here.

@salmad3salmad3 added the ready for review PR is ready for review label Dec 7, 2022
marten-seemann
marten-seemann reviewed Dec 7, 2022
View reviewed changes

@marten-seemannmarten-seemann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved to the QUIC document? Describing it there would make more sense logically, since there's no separate QUIC muxer, it's just part of the QUIC protocol.

@salmad3

salmad3 commented Dec 9, 2022

Copy link
Copy Markdown
ContributorAuthor

Indeed it could. The idea is to create a section to introduce "native stream multiplexing"

marten-seemann
marten-seemann reviewed Dec 9, 2022
View reviewed changes

@marten-seemannmarten-seemann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure if this belongs here or in the QUIC document.

Comment threadcontent/concepts/multiplex/quic.md Outdated
Comment threadcontent/concepts/multiplex/quic.md Outdated
salmad3and others added 2 commits December 12, 2022 16:56
@salmad3

salmad3 commented Dec 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Based on the nature of the doc, moved the content to the quic transport doc.

@salmad3

salmad3 commented Dec 19, 2022

Copy link
Copy Markdown
ContributorAuthor

@marten-seemann can be checked again.

@salmad3

salmad3 commented Jan 10, 2023

Copy link
Copy Markdown
ContributorAuthor

@marten-seemann

marten-seemann
marten-seemann reviewed Jan 11, 2023
View reviewed changes
Comment threadcontent/concepts/transports/quic.md Outdated
@salmad3@marten-seemann
Apply suggestions from code review
cbf9454
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
marten-seemann reviewed Jan 24, 2023
View reviewed changes
Comment threadcontent/concepts/transports/quic.md Outdated
Comment threadcontent/concepts/transports/quic.md Outdated
@salmad3@marten-seemann
Apply suggestions from code review
d37b346
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@salmad3salmad3 removed the ready for review PR is ready for review label Jan 24, 2023
@salmad3
salmad3 merged commit 4b768a4 into masterJan 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marten-seemannmarten-seemannmarten-seemann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

libp2p Product
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add additional QUIC muxer to QUIC transport doc

2 participants

@salmad3@marten-seemann