Skip to content

feat: early muxer negotiation - #274

Merged
salmad3 merged 7 commits into
masterfrom
early-mux
Jan 11, 2023
Merged

feat: early muxer negotiation#274
salmad3 merged 7 commits into
masterfrom
early-mux

Conversation

@salmad3

@salmad3salmad3 commented Dec 12, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Context

  • Adds content for early muxer negotiation

Not sure where the best place for this would be with the current structure. It is a new document under the general "multiplexer" section.

Latest preview

Please view the latest Fleek preview here.

@salmad3salmad3 added the ready for review PR is ready for review label Dec 12, 2022
p-shahi
p-shahi reviewed Jan 11, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/early-negotiation.md Outdated
Comment threadcontent/concepts/multiplex/early-negotiation.md Outdated
Comment threadcontent/concepts/multiplex/early-negotiation.md Outdated
Comment threadcontent/concepts/multiplex/early-negotiation.md
p-shahi
p-shahi reviewed Jan 11, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/early-negotiation.md Outdated
marten-seemann
marten-seemann reviewed Jan 11, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/early-negotiation.md Outdated
Comment threadcontent/concepts/multiplex/early-negotiation.md Outdated
Comment threadcontent/concepts/multiplex/early-negotiation.md
Multistream-select will run again on top of
the secure channel to negotiate a steam muxer, like [yamux](yamux).

<!-- ADD DIAGRAM -->

@marten-seemannmarten-seemannJan 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to merge without resolving this TODO? Should we create an issue so we don't forget?

@salmad3salmad3Jan 11, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have them noted down, and will also add to the issue open about unified diagrams.

Comment threadcontent/concepts/multiplex/early-negotiation.md Outdated
Comment threadcontent/concepts/multiplex/early-negotiation.md Outdated
@salmad3@p-shahi@marten-seemann
Apply suggestions from code review
6d1f5be
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
salmad3
salmad3 commented Jan 11, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/early-negotiation.md
@marten-seemann

marten-seemann commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Looks like there are still a bunch of comments to address, please request another review when done.

@salmad3

salmad3 commented Jan 11, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Looks like there are still a bunch of comments to address, please request another review when done.

I had replied to the comments or added counter suggestions.

salmad3and others added 2 commits January 10, 2023 23:56
@salmad3@p-shahi
Apply suggestions from code review
5bbc446
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
@salmad3
lint, formatting
ca7a545
@salmad3
salmad3 removed the request for review from MarcoPoloJanuary 11, 2023 05:05
@salmad3salmad3 removed the ready for review PR is ready for review label Jan 11, 2023
@salmad3
salmad3 merged commit 221595c into masterJan 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-shahip-shahip-shahi approved these changes
@marten-seemannmarten-seemannAwaiting requested review from marten-seemann

Assignees

No one assigned

Labels

None yet

Projects

go-libp2p
Archived in project
libp2p Product
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document "Early Muxer Negotiation"

3 participants

@salmad3@marten-seemann@p-shahi