Skip to content

feat: peer discovery and routing section - #294

Merged
p-shahi merged 18 commits into
masterfrom
init/discovery-sec
Mar 3, 2023
Merged

feat: peer discovery and routing section#294
p-shahi merged 18 commits into
masterfrom
init/discovery-sec

Conversation

@salmad3

@salmad3salmad3 commented Jan 15, 2023•
edited by p-shahi
Loading

Copy link
Copy Markdown
Contributor

Docs this PR introduces that were already approved

Context

@salmad3
salmad3 marked this pull request as draft January 15, 2023 18:19
@salmad3salmad3 linked an issue Jan 16, 2023 that may be closed by this pull request
Write concept doc about peer routing #13
Closed
@salmad3
salmad3 marked this pull request as ready for review January 17, 2023 10:33
@salmad3salmad3 added ready for review PR is ready for review Epic DNM do not merge labels Jan 17, 2023
@salmad3

salmad3 commented Jan 26, 2023

Copy link
Copy Markdown
ContributorAuthor

Link fixes and potential conflicts will be addressed in this PR once all associated material has been added.

@salmad3salmad3 added the P1 High label Jan 26, 2023
p-shahi
p-shahi reviewed Feb 2, 2023
View reviewed changes
Comment threadcontent/concepts/discovery-routing/overview.md Outdated
Comment threadcontent/concepts/discovery-routing/pubsub.md Outdated
Comment on lines +2 to +5
title: "PubSub"
description: "."
weight: 225
---

@p-shahip-shahiFeb 2, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move PubSub out of the discovery and routing section and instead place it a section like messaging. Pubsub can be employed for routing/discovery but it's more for message dissemination imo

@salmad3salmad3Feb 2, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intended to remove this (and didn't create another doc as a result), thanks!

@salmad3salmad3 added change request PR requires changes. and removed ready for review PR is ready for review DNM do not merge labels Feb 2, 2023
@salmad3
salmad3 marked this pull request as draft February 2, 2023 20:18
@salmad3
salmad3 requested a review from p-shahiFebruary 2, 2023 20:18
@salmad3salmad3 added ready for review PR is ready for review and removed change request PR requires changes. labels Feb 2, 2023
@p-shahip-shahi changed the title feat: peer discovery and routing section[do not merge] feat: peer discovery and routing sectionFeb 23, 2023
@p-shahip-shahi closed this Feb 23, 2023
@p-shahip-shahi reopened this Feb 25, 2023
@p-shahip-shahi removed P1 High ready for review PR is ready for review Epic labels Feb 25, 2023
@mxinden

mxinden commented Mar 1, 2023

Copy link
Copy Markdown
Member

@p-shahi is this still planned to merge eventually? If so, I would push a couple of changes to the mdns document.

@p-shahi

p-shahi commented Mar 1, 2023

Copy link
Copy Markdown
Member

@mxinden please push your changes. I will merge by end of week

mxinden
mxinden reviewed Mar 1, 2023
View reviewed changes
Comment threadcontent/concepts/discovery-routing/mdns.md Outdated
@p-shahip-shahi changed the title [do not merge] feat: peer discovery and routing sectionfeat: peer discovery and routing sectionMar 1, 2023
@p-shahi
p-shahiforce-pushed the init/discovery-sec branch from df8a52a to a2f5e7fCompareMarch 1, 2023 22:56
@p-shahi
p-shahi marked this pull request as ready for review March 1, 2023 22:57
@p-shahi
p-shahi removed their request for review March 1, 2023 22:57
mxinden
mxinden approved these changes Mar 3, 2023
View reviewed changes

@mxindenmxinden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge from my end.

@p-shahi
p-shahi merged commit 37935bc into masterMar 3, 2023
@p-shahi
p-shahi deleted the init/discovery-sec branch March 3, 2023 18:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-shahip-shahip-shahi left review comments
@mxindenmxindenmxinden approved these changes
@MarcoPoloMarcoPoloAwaiting requested review from MarcoPolo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create and populate discovery & routing section Write concept doc about peer routing

3 participants

@salmad3@mxinden@p-shahi