Uh oh!
There was an error while loading. Please reload this page.
ozone: the mouse highlight goes where the mouse is - #19493
Open
KrisEnigma wants to merge 1 commit into
Open
Conversation
The sidebar cached a hovered category for the next click without showing it, so the cursor sat on the active tab while the pointer was somewhere else. It now follows the pointer down the sidebar; the tab in use is still legible through its highlighted label, which is how it already reads when focus is in the entry list. Both lists also drew a highlight while the pointer rested between rows, over the header, the footer or the thumbnail bar, pointing at something the next click would not reach. Nothing is drawn there now. And because the entry cursor comes from ozone->selection, which the hover auto select only reaches on the following frame, the box could sit a frame behind the pointer, or several while the accel guard held it back. It stays hidden until it would land under the pointer, and the crossfade from the previous entry is skipped when a mouse is driving, since that row has already been left. A keypress clears cursor mode, and every highlight returns with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ozone: the mouse highlight goes where the mouse is
The Ozone sidebar cached a hovered category for the next click and drew nothing. So the cursor sat on the active tab while the pointer was on another row. The entry list already follows the mouse. The sidebar now does too.
The tab you are actually on stays readable through its highlighted label, which is the same cue you get when focus is in the entry list. The box itself follows the pointer.
Both lists also drew a highlight while the pointer sat between rows, over the header, the footer, or the thumbnail bar, pointing at something the next click would not reach. Nothing is drawn there now.
The entry cursor comes from
ozone->selection, which the hover auto select only reaches on the following frame, and not at all while the accel guard holds it back. The box stays hidden until it would land under the pointer. The crossfade from the previous entry is skipped when a mouse is driving, since that row has already been left.A keypress clears cursor mode. Every highlight returns with it.
How to verify
Ozone, mouse or a TV pointer: