Uh oh!
There was an error while loading. Please reload this page.
menu: show Load Content > Downloads without installed cores - #19495
Open
4RH1T3CT0R7 wants to merge 1 commit into
Open
menu: show Load Content > Downloads without installed cores#194954RH1T3CT0R7 wants to merge 1 commit into
4RH1T3CT0R7 wants to merge 1 commit into
Conversation
The Downloads entry was only listed when at least one core info file was loaded, so an empty or unreadable core directory hid the folder from Load Content even though its files were on disk. The check dates from when the entry was added next to Favorites in 2017 and is not needed: picking a file with no cores already lands on the "No cores available" list with a Download Core entry. Gate the entry on the Downloads directory being set instead, like the Favorites entry right above it, and drop the core list lookup that only served the old check. Fixeslibretro#19405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load Content only listed the Downloads entry when at least one core info file was loaded, so with an empty or unreadable core directory the folder vanished from the menu even though its files were on disk. The check has been there since the entry was added next to Favorites in 2017 and survived the move out of the per-driver list_push functions in #17517. It is not needed for safety: picking a file with no cores installed already lands on the "No cores available" list with a Download Core entry.
This gates the entry on the Downloads directory being set instead, like the Favorites entry right above, and drops the core list lookup that only served the old check. menu_displaylist.o builds with the MSYS2 MinGW toolchain after a fresh ./configure.
Fixes#19405