Upgrade to LDK 0.0.116

[tnull]

This is a draft PR which will be regularly rebased on upstream HEAD to incorporate and test the made changes.

[tnull]

Rebased on current main and updated to use LDK 0.0.116-alpha1.

[tnull]

Switched to 0.0.116 after release and split out anchor support to a dedicated follow-up PR #141.

[tnull]

Rebased on main to fix CI builds.

[wpaulino]

LGTM but needs a rebase

[tnull]

LGTM but needs a rebase

Rebased on main and took the liberty of squashing fixups including minimal changes:

> git range-diff 2023-05-upgrade-to-LDK-0.0.116-backup~1..2023-05-upgrade-to-LDK-0.0.116-backup 2023-05-upgrade-to-LDK-0.0.116~1..2023-05-upgrade-to-LDK-0.0.116
1: 12c5086 ! 1: 972afcb Update to LDK 0.0.116
@@ bindings/ldk_node.udl: interface LDKNode {
[Throws=NodeError]
PaymentHash send_spontaneous_payment(u64 amount_msat, PublicKey node_id);
[Throws=NodeError]
+- void send_payment_probe([ByRef]Invoice invoice);
++ void send_payment_probe([ByRef]Bolt11Invoice invoice);
+ [Throws=NodeError]
+ void send_spontaneous_payment_probe(u64 amount_msat, PublicKey node_id);
+ [Throws=NodeError]
- Invoice receive_payment(u64 amount_msat, [ByRef]string description, u32 expiry_secs);
+ Bolt11Invoice receive_payment(u64 amount_msat, [ByRef]string description, u32 expiry_secs);
[Throws=NodeError]
@@ src/lib.rs: pub use error::Error as NodeError;
pub use io::utils::generate_entropy_mnemonic;
@@ src/lib.rs: use wallet::Wallet;
- use logger::{log_error, log_info, log_trace, FilesystemLogger, Logger};
+ use logger::{log_debug, log_error, log_info, log_trace, FilesystemLogger, Logger};
-use lightning::chain::keysinterface::EntropySource;
use lightning::chain::Confirm;
@@ src/lib.rs: use wallet::Wallet;
@@ src/lib.rs: use lightning_background_processor::process_events_async;
use lightning_transaction_sync::EsploraSyncClient;
- use lightning::routing::router::{PaymentParameters, RouteParameters};
+ use lightning::routing::router::{PaymentParameters, RouteParameters, Router as LdkRouter};
-use lightning_invoice::{payment, Currency, Invoice};
+use lightning_invoice::{payment, Bolt11Invoice, Currency};
@@ src/lib.rs: impl<K: KVStore + Sync + Send + 'static> Node<K> {
.map_err(|_| Error::ChannelConfigUpdateFailed)
}
- /// Send a payement given an invoice.
+ /// Send a payment given an invoice.
- pub fn send_payment(&self, invoice: &Invoice) -> Result<PaymentHash, Error> {
+ pub fn send_payment(&self, invoice: &Bolt11Invoice) -> Result<PaymentHash, Error> {
let rt_lock = self.runtime.read().unwrap();
@@ src/lib.rs: impl<K: KVStore + Sync + Send + 'static> Node<K> {
}
let route_params = RouteParameters { payment_params, final_value_msat: amount_msat };
+@@ src/lib.rs: impl<K: KVStore + Sync + Send + 'static> Node<K> {
+ /// the actual payment. Note this is only useful if there likely is sufficient time for the
+ /// probe to settle before sending out the actual payment, e.g., when waiting for user
+ /// confirmation in a wallet UI.
+- pub fn send_payment_probe(&self, invoice: &Invoice) -> Result<(), Error> {
++ pub fn send_payment_probe(&self, invoice: &Bolt11Invoice) -> Result<(), Error> {
+ let rt_lock = self.runtime.read().unwrap();
+ if rt_lock.is_none() {
+ return Err(Error::NotRunning);
+@@ src/lib.rs: impl<K: KVStore + Sync + Send + 'static> Node<K> {
+ invoice.min_final_cltv_expiry_delta() as u32,
+ )
+ .with_expiry_time(expiry_time.as_secs())
+- .with_route_hints(invoice.route_hints());
++ .with_route_hints(invoice.route_hints())
++ .map_err(|_| Error::InvalidInvoice)?;
+ if let Some(features) = invoice.features() {
+- payment_params = payment_params.with_features(features.clone());
++ payment_params = payment_params
++ .with_bolt11_features(features.clone())
++ .map_err(|_| Error::InvalidInvoice)?;
+ }
+ let route_params = RouteParameters { payment_params, final_value_msat: amount_msat };
+
+@@ src/lib.rs: impl<K: KVStore + Sync + Send + 'static> Node<K> {
+ &payer,
+ &route_params,
+ Some(&first_hops.iter().collect::<Vec<_>>()),
+- &inflight_htlcs,
++ inflight_htlcs,
+ )
+ .map_err(|e| {
+ log_error!(self.logger, "Failed to find path for payment probe: {:?}", e);
@@ src/lib.rs: impl<K: KVStore + Sync + Send + 'static> Node<K> {
/// given.
pub fn receive_payment(