Uh oh!
There was an error while loading. Please reload this page.
Prefer returning errors over panicking where possible - #119
Merged
Conversation
tnull
marked this pull request as draft
June 6, 2023 10:40
tnullforce-pushed
the
2023-06-dont-panic
branch
3 times, most recently
from
June 14, 2023 07:39
8d85649 to
eae4d06Comparetnull
marked this pull request as ready for review
June 14, 2023 10:01
tnullforce-pushed
the
2023-06-dont-panic
branch
2 times, most recently
from
June 14, 2023 10:39
ea7f0e0 to
d37923aComparetnull
commented
Jun 16, 2023
CollaboratorAuthor
Rebased after #115 was merged. |
While it's not strictly necessary for us internally, it's nice to add to allow the Node itself to be used in tokio context.
jkczyz
reviewed
Jun 20, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jkczyz
reviewed
Jun 21, 2023
jkczyz
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please squash fixups.
While we cannot get rid of the panics here, we can make sure the errors are logged before we (explicitly) panic.
Which we'll be using in the next commit.
While we cannot get rid of the panics here, we can make sure the errors are logged before we (explicitly) panic.
tnull
commented
Jun 21, 2023
CollaboratorAuthor
Squashed without further changes. |
While we cannot get rid of the panics here, we can make sure the errors are logged before we (explicitly) panic.
As we now block `start()` on updating fees anyways we don't have to call `sync_wallets` manually to check we're successfully connected to the testnet esplora. We here remove this as it can be flaky dependent how many requests the Esplora server is accepting and how often our CI runs from the same machines...
tnull
commented
Jun 21, 2023
CollaboratorAuthor
Now included another commit cleaning up a unit test that was flaky in CI, depending if Esplora server quotas were hit. |
jkczyz
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #115.Fixes#50.