Uh oh!
There was an error while loading. Please reload this page.
Allow to specify and update ChannelConfig - #122
Merged
tnull merged 3 commits intoJun 15, 2023
Conversation
ChannelConfigChannelConfig... as by now `ChannelHandshakeLimits::their_to_self_delay` defaults to 2016 anyways.
tnullforce-pushed
the
2023-05-expose-update-channel-config
branch
from
June 13, 2023 18:52
057065a to
ff59bc0Comparetnull
commented
Jun 13, 2023
CollaboratorAuthor
Rebased. |
jkczyz
reviewed
Jun 15, 2023
Uh oh!
There was an error while loading. Please reload this page.
tnullforce-pushed
the
2023-05-expose-update-channel-config
branch
from
June 15, 2023 17:56
ff59bc0 to
ba05dbfComparejkczyz
reviewed
Jun 15, 2023
jkczyz
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please squash fixups.
This is useful/necessary to set forwarding fee rates, as well as allowing for overriding the dust HTLC exposure limit.
tnullforce-pushed
the
2023-05-expose-update-channel-config
branch
from
June 15, 2023 18:00
ba05dbf to
831a330Comparetnull
commented
Jun 15, 2023
CollaboratorAuthor
Squashed. |
jkczyz
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful/necessary to set forwarding fee rates, as well as allowing for overriding the dust HTLC exposure limit.