Uh oh!
There was an error while loading. Please reload this page.
Add is_running function to Node - #169
Conversation
| Ok(()) | ||
| } | ||
| /// Checks if [`Node`] runtime is available. |
There was a problem hiding this comment.
indentation is a bit off, will fix it.
anything else I should mention in the comment?
because this check is more "codey" check and not really has anything to do with the network, should we mention this?
There was a problem hiding this comment.
Thanks! Seems fine, although we could maybe just make it "Returns whether the [Node] is running." (as mentioning the runtime feels a bit like we're leaking internals that the user doesn't need to care about).
0570a96 to
0212d21Compare
tnull
left a comment
There was a problem hiding this comment.
LGTM, can we also expose that in bindings, i.e., add it to ldk_node.udl?
- Expose in bindings
0212d21 to
0a95d72Comparejbesraa
commented
Oct 2, 2023
looks like we need to pin some crate(s) here? |
tnull
commented
Oct 5, 2023
Yeah, fixed that in #151. |
resolves#164