Skip to content

Allow to listen on and advertise multiple SocketAddr - #187

Merged
tnull merged 2 commits into
lightningdevkit:mainfrom
alexanderwiederin:92-allow-multiple-listen
Nov 15, 2023
Merged

Allow to listen on and advertise multiple SocketAddr#187
tnull merged 2 commits into
lightningdevkit:mainfrom
alexanderwiederin:92-allow-multiple-listen

Conversation

@alexanderwiederin

@alexanderwiederinalexanderwiederin commented Nov 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves#92

  • Allows nodes to listen and advertise on multiple SocketAddr.
  • Changes random_config in testing to set two listening addresses.

Also fixes a small typo in an error message

@alexanderwiederin
alexanderwiederin marked this pull request as draft November 10, 2023 14:54
@alexanderwiederin
alexanderwiederinforce-pushed the 92-allow-multiple-listen branch 3 times, most recently from 4c401fc to fd3e74aCompareNovember 12, 2023 16:43
@alexanderwiederin
alexanderwiederin marked this pull request as ready for review November 12, 2023 17:31
@alexanderwiederin
alexanderwiederin marked this pull request as draft November 13, 2023 10:56
tnull
tnull reviewed Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs Outdated
Comment threadsrc/lib.rs Outdated
tnull
tnull reviewed Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs Outdated
tnull
tnull reviewed Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs Outdated
Comment threadsrc/lib.rs Outdated
@alexanderwiederin
alexanderwiederinforce-pushed the 92-allow-multiple-listen branch 3 times, most recently from dec253a to 758e614CompareNovember 13, 2023 15:34
@alexanderwiederin
alexanderwiederin marked this pull request as ready for review November 13, 2023 23:00
tnull
tnull reviewed Nov 14, 2023
View reviewed changes
Comment threadsrc/builder.rs Outdated
Comment threadsrc/lib.rs Outdated
Comment threadsrc/lib.rs Outdated
Comment threadsrc/lib.rs Outdated
Comment threadsrc/lib.rs Outdated
Comment threadsrc/lib.rs Outdated
Comment threadsrc/test/utils.rs Outdated
@alexanderwiederin
alexanderwiederinforce-pushed the 92-allow-multiple-listen branch 2 times, most recently from 7d52e50 to 6d40944CompareNovember 14, 2023 11:39
tnull
tnull reviewed Nov 15, 2023
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much looks good to me, only 1-2 comments and some nits.

Also, could you rebase the branch on current main to see if CI passes?

Comment threadsrc/lib.rs Outdated
Comment threadsrc/builder.rs Outdated
Comment threadsrc/test/utils.rs Outdated
Comment threadsrc/lib.rs Outdated
@alexanderwiederin
alexanderwiederinforce-pushed the 92-allow-multiple-listen branch 4 times, most recently from c3549f9 to 18f567cCompareNovember 15, 2023 14:27
@alexanderwiederin

alexanderwiederin commented Nov 15, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Rebased and adapted python tests to set a list of listening_addresses.

Running the tests in the CI, we get:

TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.

Will continue to look into this, but if you have an idea, let me know!

tnull
tnull reviewed Nov 15, 2023
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and adapted python tests to set multiple listening_addresses.

Running the tests in the CI, we get:

TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.

Will continue looking into this, but if you have an idea, let me know!

Yes, this is what the Python tests put out when they panic (essentially we panic, shutdown, write some logs, while the Python test env already tries to cleanup the temporary folder). See the comment on why it fails.

Comment threadbindings/python/src/ldk_node/test_ldk_node.py
tnull
tnull approved these changes Nov 15, 2023
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tnull
tnull merged commit beb2345 into lightningdevkit:mainNov 15, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow to listen on and advertise multiple NetAddresses

2 participants

@alexanderwiederin@tnull
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Allow to listen on and advertise multiple `SocketAddr` by alexanderwiederin · Pull Request #187 · lightningdevkit/ldk-node · GitHub
Skip to content
Allow to listen on and advertise multiple SocketAddr - #187
Merged
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Nov 15, 2023
Merged
Allow to listen on and advertise multiple SocketAddr#187
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Conversation
@alexanderwiederin
@alexanderwiederinalexanderwiederin
commented
Nov 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#92
  • Allows nodes to listen and advertise on multiple SocketAddr.
  • Changes random_config in testing to set two listening addresses.
Also fixes a small typo in an error message
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 10, 2023 14:54
@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
4c401fc to
fd3e74aCompareNovember 12, 2023 16:43
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 12, 2023 17:31
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 13, 2023 10:56
tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
dec253a to
758e614CompareNovember 13, 2023 15:34
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 13, 2023 23:00
tnull
tnull
reviewed
Nov 14, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
2 times, most recently
from
7d52e50 to
6d40944CompareNovember 14, 2023 11:39
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much looks good to me, only 1-2 comments and some nits.
Also, could you rebase the branch on current main to see if CI passes?
Comment threadsrc/lib.rs
Outdated

Comment threadsrc/builder.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
4 times, most recently
from
c3549f9 to
18f567cCompareNovember 15, 2023 14:27
@alexanderwiederin
alexanderwiederin
commented
Nov 15, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased and adapted python tests to set a list of listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue to look into this, but if you have an idea, let me know!
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and adapted python tests to set multiple listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue looking into this, but if you have an idea, let me know!
Yes, this is what the Python tests put out when they panic (essentially we panic, shutdown, write some logs, while the Python test env already tries to cleanup the temporary folder). See the comment on why it fails.
Comment threadbindings/python/src/ldk_node/test_ldk_node.py
tnull
tnull
approved these changes
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@tnull
tnull
merged commit beb2345
into
lightningdevkit:mainNov 15, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow to listen on and advertise multiple NetAddresses

2 participants

@alexanderwiederin@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow to listen on and advertise multiple `SocketAddr` by alexanderwiederin · Pull Request #187 · lightningdevkit/ldk-node · GitHub
Skip to content
Allow to listen on and advertise multiple SocketAddr - #187
Merged
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Nov 15, 2023
Merged
Allow to listen on and advertise multiple SocketAddr#187
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Conversation
@alexanderwiederin
@alexanderwiederinalexanderwiederin
commented
Nov 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#92
  • Allows nodes to listen and advertise on multiple SocketAddr.
  • Changes random_config in testing to set two listening addresses.
Also fixes a small typo in an error message
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 10, 2023 14:54
@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
4c401fc to
fd3e74aCompareNovember 12, 2023 16:43
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 12, 2023 17:31
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 13, 2023 10:56
tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
dec253a to
758e614CompareNovember 13, 2023 15:34
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 13, 2023 23:00
tnull
tnull
reviewed
Nov 14, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
2 times, most recently
from
7d52e50 to
6d40944CompareNovember 14, 2023 11:39
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much looks good to me, only 1-2 comments and some nits.
Also, could you rebase the branch on current main to see if CI passes?
Comment threadsrc/lib.rs
Outdated

Comment threadsrc/builder.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
4 times, most recently
from
c3549f9 to
18f567cCompareNovember 15, 2023 14:27
@alexanderwiederin
alexanderwiederin
commented
Nov 15, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased and adapted python tests to set a list of listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue to look into this, but if you have an idea, let me know!
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and adapted python tests to set multiple listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue looking into this, but if you have an idea, let me know!
Yes, this is what the Python tests put out when they panic (essentially we panic, shutdown, write some logs, while the Python test env already tries to cleanup the temporary folder). See the comment on why it fails.
Comment threadbindings/python/src/ldk_node/test_ldk_node.py
tnull
tnull
approved these changes
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@tnull
tnull
merged commit beb2345
into
lightningdevkit:mainNov 15, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow to listen on and advertise multiple NetAddresses

2 participants

@alexanderwiederin@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow to listen on and advertise multiple `SocketAddr` by alexanderwiederin · Pull Request #187 · lightningdevkit/ldk-node · GitHub
Skip to content
Allow to listen on and advertise multiple SocketAddr - #187
Merged
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Nov 15, 2023
Merged
Allow to listen on and advertise multiple SocketAddr#187
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Conversation
@alexanderwiederin
@alexanderwiederinalexanderwiederin
commented
Nov 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#92
  • Allows nodes to listen and advertise on multiple SocketAddr.
  • Changes random_config in testing to set two listening addresses.
Also fixes a small typo in an error message
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 10, 2023 14:54
@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
4c401fc to
fd3e74aCompareNovember 12, 2023 16:43
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 12, 2023 17:31
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 13, 2023 10:56
tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
dec253a to
758e614CompareNovember 13, 2023 15:34
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 13, 2023 23:00
tnull
tnull
reviewed
Nov 14, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
2 times, most recently
from
7d52e50 to
6d40944CompareNovember 14, 2023 11:39
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much looks good to me, only 1-2 comments and some nits.
Also, could you rebase the branch on current main to see if CI passes?
Comment threadsrc/lib.rs
Outdated

Comment threadsrc/builder.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
4 times, most recently
from
c3549f9 to
18f567cCompareNovember 15, 2023 14:27
@alexanderwiederin
alexanderwiederin
commented
Nov 15, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased and adapted python tests to set a list of listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue to look into this, but if you have an idea, let me know!
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and adapted python tests to set multiple listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue looking into this, but if you have an idea, let me know!
Yes, this is what the Python tests put out when they panic (essentially we panic, shutdown, write some logs, while the Python test env already tries to cleanup the temporary folder). See the comment on why it fails.
Comment threadbindings/python/src/ldk_node/test_ldk_node.py
tnull
tnull
approved these changes
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@tnull
tnull
merged commit beb2345
into
lightningdevkit:mainNov 15, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow to listen on and advertise multiple NetAddresses

2 participants

@alexanderwiederin@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Allow to listen on and advertise multiple `SocketAddr` by alexanderwiederin · Pull Request #187 · lightningdevkit/ldk-node · GitHub
Skip to content
Allow to listen on and advertise multiple SocketAddr - #187
Merged
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Nov 15, 2023
Merged
Allow to listen on and advertise multiple SocketAddr#187
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Conversation
@alexanderwiederin
@alexanderwiederinalexanderwiederin
commented
Nov 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#92
  • Allows nodes to listen and advertise on multiple SocketAddr.
  • Changes random_config in testing to set two listening addresses.
Also fixes a small typo in an error message
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 10, 2023 14:54
@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
4c401fc to
fd3e74aCompareNovember 12, 2023 16:43
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 12, 2023 17:31
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 13, 2023 10:56
tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
dec253a to
758e614CompareNovember 13, 2023 15:34
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 13, 2023 23:00
tnull
tnull
reviewed
Nov 14, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
2 times, most recently
from
7d52e50 to
6d40944CompareNovember 14, 2023 11:39
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much looks good to me, only 1-2 comments and some nits.
Also, could you rebase the branch on current main to see if CI passes?
Comment threadsrc/lib.rs
Outdated

Comment threadsrc/builder.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
4 times, most recently
from
c3549f9 to
18f567cCompareNovember 15, 2023 14:27
@alexanderwiederin
alexanderwiederin
commented
Nov 15, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased and adapted python tests to set a list of listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue to look into this, but if you have an idea, let me know!
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and adapted python tests to set multiple listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue looking into this, but if you have an idea, let me know!
Yes, this is what the Python tests put out when they panic (essentially we panic, shutdown, write some logs, while the Python test env already tries to cleanup the temporary folder). See the comment on why it fails.
Comment threadbindings/python/src/ldk_node/test_ldk_node.py
tnull
tnull
approved these changes
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@tnull
tnull
merged commit beb2345
into
lightningdevkit:mainNov 15, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow to listen on and advertise multiple NetAddresses

2 participants

@alexanderwiederin@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow to listen on and advertise multiple `SocketAddr` by alexanderwiederin · Pull Request #187 · lightningdevkit/ldk-node · GitHub
Skip to content
Allow to listen on and advertise multiple SocketAddr - #187
Merged
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Nov 15, 2023
Merged
Allow to listen on and advertise multiple SocketAddr#187
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Conversation
@alexanderwiederin
@alexanderwiederinalexanderwiederin
commented
Nov 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#92
  • Allows nodes to listen and advertise on multiple SocketAddr.
  • Changes random_config in testing to set two listening addresses.
Also fixes a small typo in an error message
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 10, 2023 14:54
@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
4c401fc to
fd3e74aCompareNovember 12, 2023 16:43
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 12, 2023 17:31
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 13, 2023 10:56
tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
dec253a to
758e614CompareNovember 13, 2023 15:34
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 13, 2023 23:00
tnull
tnull
reviewed
Nov 14, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
2 times, most recently
from
7d52e50 to
6d40944CompareNovember 14, 2023 11:39
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much looks good to me, only 1-2 comments and some nits.
Also, could you rebase the branch on current main to see if CI passes?
Comment threadsrc/lib.rs
Outdated

Comment threadsrc/builder.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
4 times, most recently
from
c3549f9 to
18f567cCompareNovember 15, 2023 14:27
@alexanderwiederin
alexanderwiederin
commented
Nov 15, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased and adapted python tests to set a list of listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue to look into this, but if you have an idea, let me know!
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and adapted python tests to set multiple listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue looking into this, but if you have an idea, let me know!
Yes, this is what the Python tests put out when they panic (essentially we panic, shutdown, write some logs, while the Python test env already tries to cleanup the temporary folder). See the comment on why it fails.
Comment threadbindings/python/src/ldk_node/test_ldk_node.py
tnull
tnull
approved these changes
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@tnull
tnull
merged commit beb2345
into
lightningdevkit:mainNov 15, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow to listen on and advertise multiple NetAddresses

2 participants

@alexanderwiederin@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow to listen on and advertise multiple `SocketAddr` by alexanderwiederin · Pull Request #187 · lightningdevkit/ldk-node · GitHub
Skip to content
Allow to listen on and advertise multiple SocketAddr - #187
Merged
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Nov 15, 2023
Merged
Allow to listen on and advertise multiple SocketAddr#187
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Conversation
@alexanderwiederin
@alexanderwiederinalexanderwiederin
commented
Nov 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#92
  • Allows nodes to listen and advertise on multiple SocketAddr.
  • Changes random_config in testing to set two listening addresses.
Also fixes a small typo in an error message
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 10, 2023 14:54
@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
4c401fc to
fd3e74aCompareNovember 12, 2023 16:43
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 12, 2023 17:31
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 13, 2023 10:56
tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
dec253a to
758e614CompareNovember 13, 2023 15:34
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 13, 2023 23:00
tnull
tnull
reviewed
Nov 14, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
2 times, most recently
from
7d52e50 to
6d40944CompareNovember 14, 2023 11:39
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much looks good to me, only 1-2 comments and some nits.
Also, could you rebase the branch on current main to see if CI passes?
Comment threadsrc/lib.rs
Outdated

Comment threadsrc/builder.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
4 times, most recently
from
c3549f9 to
18f567cCompareNovember 15, 2023 14:27
@alexanderwiederin
alexanderwiederin
commented
Nov 15, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased and adapted python tests to set a list of listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue to look into this, but if you have an idea, let me know!
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and adapted python tests to set multiple listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue looking into this, but if you have an idea, let me know!
Yes, this is what the Python tests put out when they panic (essentially we panic, shutdown, write some logs, while the Python test env already tries to cleanup the temporary folder). See the comment on why it fails.
Comment threadbindings/python/src/ldk_node/test_ldk_node.py
tnull
tnull
approved these changes
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@tnull
tnull
merged commit beb2345
into
lightningdevkit:mainNov 15, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow to listen on and advertise multiple NetAddresses

2 participants

@alexanderwiederin@tnull

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Allow to listen on and advertise multiple `SocketAddr` by alexanderwiederin · Pull Request #187 · lightningdevkit/ldk-node · GitHub
Skip to content
Allow to listen on and advertise multiple SocketAddr - #187
Merged
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Nov 15, 2023
Merged
Allow to listen on and advertise multiple SocketAddr#187
tnull merged 2 commits into
lightningdevkit:mainfrom 
alexanderwiederin:92-allow-multiple-listen
Conversation
@alexanderwiederin
@alexanderwiederinalexanderwiederin
commented
Nov 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#92
  • Allows nodes to listen and advertise on multiple SocketAddr.
  • Changes random_config in testing to set two listening addresses.
Also fixes a small typo in an error message
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 10, 2023 14:54
@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
4c401fc to
fd3e74aCompareNovember 12, 2023 16:43
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 12, 2023 17:31
@alexanderwiederin
alexanderwiederin
marked this pull request as draft
November 13, 2023 10:56
tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

tnull
tnull
reviewed
Nov 13, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
dec253a to
758e614CompareNovember 13, 2023 15:34
@alexanderwiederin
alexanderwiederin
marked this pull request as ready for review
November 13, 2023 23:00
tnull
tnull
reviewed
Nov 14, 2023
View reviewed changes
Comment threadsrc/builder.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/lib.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
2 times, most recently
from
7d52e50 to
6d40944CompareNovember 14, 2023 11:39
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much looks good to me, only 1-2 comments and some nits.
Also, could you rebase the branch on current main to see if CI passes?
Comment threadsrc/lib.rs
Outdated

Comment threadsrc/builder.rs
Outdated

Comment threadsrc/test/utils.rs
Outdated

Comment threadsrc/lib.rs
Outdated

@alexanderwiederin
alexanderwiederinforce-pushed
the
92-allow-multiple-listen
branch
4 times, most recently
from
c3549f9 to
18f567cCompareNovember 15, 2023 14:27
@alexanderwiederin
alexanderwiederin
commented
Nov 15, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased and adapted python tests to set a list of listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue to look into this, but if you have an idea, let me know!
tnull
tnull
reviewed
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and adapted python tests to set multiple listening_addresses.
Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1
Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e
TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2
E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'>
_warnings.warn(warn_message, ResourceWarning)
thread '<unnamed>' panicked at src/logger.rs:70:14:
Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_node

Running the test locally, returns a similar error, but on a different line.
Will continue looking into this, but if you have an idea, let me know!
Yes, this is what the Python tests put out when they panic (essentially we panic, shutdown, write some logs, while the Python test env already tries to cleanup the temporary folder). See the comment on why it fails.
Comment threadbindings/python/src/ldk_node/test_ldk_node.py
tnull
tnull
approved these changes
Nov 15, 2023
View reviewed changes
@tnulltnull
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@tnull
tnull
merged commit beb2345
into
lightningdevkit:mainNov 15, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow to listen on and advertise multiple NetAddresses

2 participants

@alexanderwiederin@tnull