Skip to content

Upgrade UniFFI to 0.26.0 - #230

Merged
tnull merged 3 commits into
lightningdevkit:mainfrom
tnull:2024-01-upgrade-uniffi-to-0.26
Feb 2, 2024
Merged

Upgrade UniFFI to 0.26.0#230
tnull merged 3 commits into
lightningdevkit:mainfrom
tnull:2024-01-upgrade-uniffi-to-0.26

Conversation

@tnull

Copy link
Copy Markdown
Collaborator

.. which notably features support for async methods and non_exhaustive enums.

@tnull
tnullforce-pushed the 2024-01-upgrade-uniffi-to-0.26 branch 3 times, most recently from 1610e94 to c58189eCompareJanuary 24, 2024 12:30
.. which features `async` support.
It also requires us to bump `jna` to 5.12 and the
`kotlinx-coroutines-core` test dependency to `1.6.4`.
@tnull
tnullforce-pushed the 2024-01-upgrade-uniffi-to-0.26 branch from c58189e to 735a38fCompareJanuary 24, 2024 12:48
We use Android's `SystemCleaner` when available, which should increase
overall GC performance.
See description here: https://developer.android.com/reference/android/system/SystemCleaner
We previously (re-)introduced a newtype with the most-recent
`rust-bitcoin` update as it added the `non_exhaustive` attribute to the
`Network` enum.
However, we can now drop this newtype again as UniFFI 0.26.0 added
support for `non_exhaustive` enums.
@thunderbiscuit

Copy link
Copy Markdown

Hey thanks for pointing out to us that you were doing the upgrade!

Question for ya: do you know if the uniffi-android.toml file now called by the --config flag simply adds to the configurations already defined in uniffi.toml, or if it becomes the only configurations read by the build process?

@tnull

Copy link
Copy Markdown
CollaboratorAuthor

Hey thanks for pointing out to us that you were doing the upgrade!

Question for ya: do you know if the uniffi-android.toml file now called by the --config flag simply adds to the configurations already defined in uniffi.toml, or if it becomes the only configurations read by the build process?

It's additive, see https://mozilla.github.io/uniffi-rs/bindings.html#customizing-the-binding-generation:

--config option can be used to specify additional uniffi config file. This config is merged with the uniffi.toml config present in each crate, with its values taking precedence.

@thunderbiscuit

Copy link
Copy Markdown

Oh thanks! They keep adding pages and I try to make sure I see all the new ones but totally missed that. 👍

@tnull

tnull commented Feb 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Going ahead and merging this.

@tnull
tnull merged commit e335f0b into lightningdevkit:mainFeb 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tnull@thunderbiscuit