Uh oh!
There was an error while loading. Please reload this page.
Drop KVStore type parameter from Node - #244
Merged
Merged
Conversation
tnull
marked this pull request as draft
February 7, 2024 12:41
tnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
3 times, most recently
from
February 7, 2024 13:06
3ed2d02 to
53f22d9CompareKVStore generic from NodeKVStore type parameter from Nodetnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
2 times, most recently
from
February 21, 2024 10:53
b80a1be to
8d1b497Compare Merged
tnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
March 4, 2024 10:07
8d1b497 to
abd8d1dComparetnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
March 4, 2024 14:52
abd8d1d to
e9cad46Comparetnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
March 5, 2024 08:47
e9cad46 to
4f4904dComparetnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
2 times, most recently
from
March 8, 2024 07:40
d9e9f2e to
8508d6cComparetnull
commented
Mar 8, 2024
CollaboratorAuthor
Rebased to resolve minor conflicts. |
tnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
March 8, 2024 07:56
8508d6c to
618aab5Compare Merged
tnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
March 12, 2024 10:02
618aab5 to
42c3644Comparetnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
March 28, 2024 14:44
42c3644 to
24614deComparetnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
April 22, 2024 13:41
24614de to
d1a33ceComparetnull
marked this pull request as ready for review
April 22, 2024 13:50
jkczyz
reviewed
Apr 22, 2024
Uh oh!
There was an error while loading. Please reload this page.
tnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
April 23, 2024 07:22
d1a33ce to
8b1a4c2Compare.. switching to `dyn KVStore + Send + Sync`
... now that we don't have any generic to hide, we can just use the `Node` type directly.
.. now that we can.
tnullforce-pushed
the
2024-02-switch-to-dyn-kvstore
branch
from
April 25, 2024 18:03
8b1a4c2 to
c566fd5Comparetnull
commented
Apr 25, 2024
CollaboratorAuthor
Rebased on main after #243 landed. |
jkczyz
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #243, depends on lightningdevkit/rust-lightning#2883
Previously, LDK Node's main object has a generic trait bound on
KVStore, i.e.,Node<K: KVStore + Send + Sync + 'static>. However, this has always been a painful issue as our bindings generator UniFFI doesn't have generic support, so we were required to type-def and expose only a concrete type, i.e.,Node<SqliteStore>, in bindings. This will now become even more painful and borderline infeasible with the upcoming introduction of theVssStorealternative.Here we therefore finally drop the generic trait bound, allowing us expose a cleaner
Nodeobject everywhere.Draft as blocked on upstream for now.