Skip to content

Expose unified list_balances interface method - #250

Merged
tnull merged 4 commits into
lightningdevkit:mainfrom
tnull:2024-02-unified-balance-interface
Feb 23, 2024
Merged

Expose unified list_balances interface method#250
tnull merged 4 commits into
lightningdevkit:mainfrom
tnull:2024-02-unified-balance-interface

Conversation

@tnull

@tnulltnull commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

Fixes#212.

@tnull
tnull marked this pull request as draft February 15, 2024 10:42
@tnull
tnullforce-pushed the 2024-02-unified-balance-interface branch 5 times, most recently from 122fd00 to d765fb6CompareFebruary 15, 2024 14:51
@tnulltnull changed the title Expose unified list_balance interface methodExpose unified list_balances interface methodFeb 15, 2024
@tnulltnull mentioned this pull request Feb 15, 2024
Closed
19 tasks
@tnulltnull added this to the 0.3 milestone Feb 15, 2024
@tnull
tnullforce-pushed the 2024-02-unified-balance-interface branch from d765fb6 to 8495bc7CompareFebruary 15, 2024 15:04
@tnull
tnull requested a review from wpaulinoFebruary 16, 2024 14:20
@tnull
tnull marked this pull request as ready for review February 16, 2024 14:20
@tnull

tnull commented Feb 16, 2024•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Should be good for review. Will rebase #141 on top of this as BalanceDetails should also reflect the Anchor channel reserve.

wpaulino
wpaulino reviewed Feb 16, 2024
View reviewed changes
Comment threadsrc/balance.rs Outdated
Comment threadsrc/balance.rs Outdated
Comment threadsrc/balance.rs Outdated
Comment threadsrc/balance.rs
@tnull
tnullforce-pushed the 2024-02-unified-balance-interface branch from 17a6c9f to 1a893e7CompareFebruary 19, 2024 09:22
This was referenced Feb 20, 2024
Merged
Merged
wpaulino
wpaulino reviewed Feb 20, 2024
View reviewed changes
Comment threadsrc/balance.rs
@tnull
tnullforce-pushed the 2024-02-unified-balance-interface branch from 49fd02b to 7d88944CompareFebruary 22, 2024 10:56
@wpaulino

wpaulino commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

LGTM after squash

@tnull
tnullforce-pushed the 2024-02-unified-balance-interface branch from 7d88944 to 6883949CompareFebruary 23, 2024 08:02
@tnull

tnull commented Feb 23, 2024

Copy link
Copy Markdown
CollaboratorAuthor

LGTM after squash

Squashed fixups and rebased to resolve minor conflicts.

@tnull
Expose LightningBalance/BalanceDetails newtypes
47a20b0
@tnull
Expose onchain balances via BalanceDetails
8e45c2a
@tnull
Expose sweeper balances via BalanceDetails
0b901fc
@tnull
Drop balance_msat from ChannelDetails
e809b23
This was discussed upstream but reverted for now. The field is very
confusing and misleading, and we can finally drop it now that we have a
better `list_balances` interface.
@tnull
tnullforce-pushed the 2024-02-unified-balance-interface branch from 6883949 to e809b23CompareFebruary 23, 2024 16:54
@tnull

tnull commented Feb 23, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Rebased to resolve minor conflicts (rustfmt).

@tnull
tnull merged commit d6aa27c into lightningdevkit:mainFeb 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpaulinowpaulinowpaulino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3

Development

Successfully merging this pull request may close these issues.

Unified interface listing all available balances

2 participants

@tnull@wpaulino