Uh oh!
There was an error while loading. Please reload this page.
Expose NetworkGraph accessors - #293
Merged
Merged
Conversation
tnullforce-pushed
the
2024-05-expose-network-graph
branch
from
June 1, 2024 08:01
44596dc to
cdc3622Comparetnull
commented
Jun 1, 2024
CollaboratorAuthor
Rebased on #281 to resolve minor conflicts with main. |
tnullforce-pushed
the
2024-05-expose-network-graph
branch
2 times, most recently
from
June 11, 2024 08:16
6f2d1ad to
862d7fdCompareCollaboratorAuthor
Rebased on top of main to reduce stack height and allow parallel review. |
tnullforce-pushed
the
2024-05-expose-network-graph
branch
from
June 11, 2024 08:40
862d7fd to
350c3a9Compare.. as we're about to expose a new `NetworkGraph` wrapper type.
Previously, we omitted exposing details for the sake of simplicity. However, querying the network graph has a lot of utility, and is also very useful for debugging purposes. Here, we therefore give users access to the network graph, and expose slightly simplified versions of `ChannelInfo`/`NodeInfo` in bindings.
tnullforce-pushed
the
2024-05-expose-network-graph
branch
from
June 11, 2024 18:52
350c3a9 to
35e4968Comparetnull
commented
Jun 11, 2024
CollaboratorAuthor
Rebased on main to resolve minor conflict after #141 landed. |
arik-so
reviewed
Jun 11, 2024
Uh oh!
There was an error while loading. Please reload this page.
arik-so
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #281.Based on #141.Previously, we omitted exposing details for the sake of simplicity. However, querying the network graph has a lot of utility, and is also very useful for debugging purposes.
Here, we therefore give users access to the network graph, and expose slightly simplified versions of
ChannelInfo/NodeInfoin bindings.