Refactor `FeeEstimator` to introduce local target variants by tnull · Pull Request #352 · lightningdevkit/ldk-node

tnull · 2024-08-29T10:10:11Z

.. previously we used LDK's FeeEstimator and ConfirmationTarget and ~misused some of the latter's variants for our non-Lightning operations.

Here, we introduce our own FeeEstimator and ConfirmationTarget allowing to add specific variants for ChannelFunding and OnchainPayments, for example.

(This is can also be viewed as a prefactor to #176, which we'll do as part of / after the upcoming rust-bitcoin/BDK upgrade)

jkczyz · 2024-08-29T16:07:04Z

+ ConfirmationTarget::OnchainPayment => 6,
+ ConfirmationTarget::ChannelFunding => 12,


Seems like in practice the values are the same as before. Is this change to allow us to vary them in the future?

Yes, I intentionally left the behavior unchanged for now. This is really only an overdue refactor and also prepares for the LDK upgrade where we'll get more ConfirmationTargets and in particular will split OnChainSweep.
At some point in the future (probably when tackling #176), we'll revisit if the chosen defaults could be improved in any way, or if they are fine as is.

jkczyz · 2024-08-29T16:20:22Z

 }

-pub struct Wallet<D, B: Deref, E: Deref, L: Deref>
+pub(crate) struct Wallet<D, B: Deref, E: Deref, L: Deref>


Visibility control for Wallet and WalletKeysManager (below) seem unrelated to to the commits purpose.

I thought so, too, but rustc 1.63 seemed to think otherwise (as the new FeeEstimator is pub(crate), it complained that I couldn't leak a pub(crate) trait in a pub struct, nevermind that in fact the module itself is pub(crate)). I now split the visibility changes out to their own commit though.

jkczyz

LGTM. Please squash.

.. previously we used LDK's `FeeEstimator` and `ConfirmationTarget` and ~misused some of the latter's variants for our non-Lightning operations. Here, we introduce our own `FeeEstimator` and `ConfirmationTarget` allowing to add specific variants for `ChannelFunding` and `OnchainPayment`s, for example.

tnull · 2024-08-30T14:58:22Z

LGTM. Please squash.

Squashed without further changes.

tnull · 2024-08-29T10:10:11Z

.. previously we used LDK's FeeEstimator and ConfirmationTarget and ~misused some of the latter's variants for our non-Lightning operations.

Here, we introduce our own FeeEstimator and ConfirmationTarget allowing to add specific variants for ChannelFunding and OnchainPayments, for example.

(This is can also be viewed as a prefactor to #176, which we'll do as part of / after the upcoming rust-bitcoin/BDK upgrade)

jkczyz · 2024-08-29T16:07:04Z

+ ConfirmationTarget::OnchainPayment => 6,
+ ConfirmationTarget::ChannelFunding => 12,


Seems like in practice the values are the same as before. Is this change to allow us to vary them in the future?

Yes, I intentionally left the behavior unchanged for now. This is really only an overdue refactor and also prepares for the LDK upgrade where we'll get more ConfirmationTargets and in particular will split OnChainSweep.
At some point in the future (probably when tackling #176), we'll revisit if the chosen defaults could be improved in any way, or if they are fine as is.

jkczyz · 2024-08-29T16:20:22Z

 }

-pub struct Wallet<D, B: Deref, E: Deref, L: Deref>
+pub(crate) struct Wallet<D, B: Deref, E: Deref, L: Deref>


Visibility control for Wallet and WalletKeysManager (below) seem unrelated to to the commits purpose.

I thought so, too, but rustc 1.63 seemed to think otherwise (as the new FeeEstimator is pub(crate), it complained that I couldn't leak a pub(crate) trait in a pub struct, nevermind that in fact the module itself is pub(crate)). I now split the visibility changes out to their own commit though.

jkczyz

LGTM. Please squash.

.. previously we used LDK's `FeeEstimator` and `ConfirmationTarget` and ~misused some of the latter's variants for our non-Lightning operations. Here, we introduce our own `FeeEstimator` and `ConfirmationTarget` allowing to add specific variants for `ChannelFunding` and `OnchainPayment`s, for example.

tnull · 2024-08-30T14:58:22Z

LGTM. Please squash.

Squashed without further changes.

tnull · 2024-08-29T10:10:11Z

.. previously we used LDK's FeeEstimator and ConfirmationTarget and ~misused some of the latter's variants for our non-Lightning operations.

Here, we introduce our own FeeEstimator and ConfirmationTarget allowing to add specific variants for ChannelFunding and OnchainPayments, for example.

(This is can also be viewed as a prefactor to #176, which we'll do as part of / after the upcoming rust-bitcoin/BDK upgrade)

jkczyz · 2024-08-29T16:07:04Z

+ ConfirmationTarget::OnchainPayment => 6,
+ ConfirmationTarget::ChannelFunding => 12,


Seems like in practice the values are the same as before. Is this change to allow us to vary them in the future?

Yes, I intentionally left the behavior unchanged for now. This is really only an overdue refactor and also prepares for the LDK upgrade where we'll get more ConfirmationTargets and in particular will split OnChainSweep.
At some point in the future (probably when tackling #176), we'll revisit if the chosen defaults could be improved in any way, or if they are fine as is.

jkczyz · 2024-08-29T16:20:22Z

 }

-pub struct Wallet<D, B: Deref, E: Deref, L: Deref>
+pub(crate) struct Wallet<D, B: Deref, E: Deref, L: Deref>


Visibility control for Wallet and WalletKeysManager (below) seem unrelated to to the commits purpose.

I thought so, too, but rustc 1.63 seemed to think otherwise (as the new FeeEstimator is pub(crate), it complained that I couldn't leak a pub(crate) trait in a pub struct, nevermind that in fact the module itself is pub(crate)). I now split the visibility changes out to their own commit though.

jkczyz

LGTM. Please squash.

.. previously we used LDK's `FeeEstimator` and `ConfirmationTarget` and ~misused some of the latter's variants for our non-Lightning operations. Here, we introduce our own `FeeEstimator` and `ConfirmationTarget` allowing to add specific variants for `ChannelFunding` and `OnchainPayment`s, for example.

tnull · 2024-08-30T14:58:22Z

LGTM. Please squash.

Squashed without further changes.

tnull · 2024-08-29T10:10:11Z

.. previously we used LDK's FeeEstimator and ConfirmationTarget and ~misused some of the latter's variants for our non-Lightning operations.

Here, we introduce our own FeeEstimator and ConfirmationTarget allowing to add specific variants for ChannelFunding and OnchainPayments, for example.

(This is can also be viewed as a prefactor to #176, which we'll do as part of / after the upcoming rust-bitcoin/BDK upgrade)

jkczyz · 2024-08-29T16:07:04Z

+ ConfirmationTarget::OnchainPayment => 6,
+ ConfirmationTarget::ChannelFunding => 12,


Seems like in practice the values are the same as before. Is this change to allow us to vary them in the future?

Yes, I intentionally left the behavior unchanged for now. This is really only an overdue refactor and also prepares for the LDK upgrade where we'll get more ConfirmationTargets and in particular will split OnChainSweep.
At some point in the future (probably when tackling #176), we'll revisit if the chosen defaults could be improved in any way, or if they are fine as is.

jkczyz · 2024-08-29T16:20:22Z

 }

-pub struct Wallet<D, B: Deref, E: Deref, L: Deref>
+pub(crate) struct Wallet<D, B: Deref, E: Deref, L: Deref>


Visibility control for Wallet and WalletKeysManager (below) seem unrelated to to the commits purpose.

I thought so, too, but rustc 1.63 seemed to think otherwise (as the new FeeEstimator is pub(crate), it complained that I couldn't leak a pub(crate) trait in a pub struct, nevermind that in fact the module itself is pub(crate)). I now split the visibility changes out to their own commit though.

jkczyz

LGTM. Please squash.

.. previously we used LDK's `FeeEstimator` and `ConfirmationTarget` and ~misused some of the latter's variants for our non-Lightning operations. Here, we introduce our own `FeeEstimator` and `ConfirmationTarget` allowing to add specific variants for `ChannelFunding` and `OnchainPayment`s, for example.

tnull · 2024-08-30T14:58:22Z

LGTM. Please squash.

Squashed without further changes.

tnull · 2024-08-29T10:10:11Z

.. previously we used LDK's FeeEstimator and ConfirmationTarget and ~misused some of the latter's variants for our non-Lightning operations.

Here, we introduce our own FeeEstimator and ConfirmationTarget allowing to add specific variants for ChannelFunding and OnchainPayments, for example.

(This is can also be viewed as a prefactor to #176, which we'll do as part of / after the upcoming rust-bitcoin/BDK upgrade)

jkczyz · 2024-08-29T16:07:04Z

+ ConfirmationTarget::OnchainPayment => 6,
+ ConfirmationTarget::ChannelFunding => 12,


Seems like in practice the values are the same as before. Is this change to allow us to vary them in the future?

Yes, I intentionally left the behavior unchanged for now. This is really only an overdue refactor and also prepares for the LDK upgrade where we'll get more ConfirmationTargets and in particular will split OnChainSweep.
At some point in the future (probably when tackling #176), we'll revisit if the chosen defaults could be improved in any way, or if they are fine as is.

jkczyz · 2024-08-29T16:20:22Z

 }

-pub struct Wallet<D, B: Deref, E: Deref, L: Deref>
+pub(crate) struct Wallet<D, B: Deref, E: Deref, L: Deref>


Visibility control for Wallet and WalletKeysManager (below) seem unrelated to to the commits purpose.

I thought so, too, but rustc 1.63 seemed to think otherwise (as the new FeeEstimator is pub(crate), it complained that I couldn't leak a pub(crate) trait in a pub struct, nevermind that in fact the module itself is pub(crate)). I now split the visibility changes out to their own commit though.

jkczyz

LGTM. Please squash.

.. previously we used LDK's `FeeEstimator` and `ConfirmationTarget` and ~misused some of the latter's variants for our non-Lightning operations. Here, we introduce our own `FeeEstimator` and `ConfirmationTarget` allowing to add specific variants for `ChannelFunding` and `OnchainPayment`s, for example.

tnull · 2024-08-30T14:58:22Z

LGTM. Please squash.

Squashed without further changes.

tnull · 2024-08-29T10:10:11Z

.. previously we used LDK's FeeEstimator and ConfirmationTarget and ~misused some of the latter's variants for our non-Lightning operations.

Here, we introduce our own FeeEstimator and ConfirmationTarget allowing to add specific variants for ChannelFunding and OnchainPayments, for example.

(This is can also be viewed as a prefactor to #176, which we'll do as part of / after the upcoming rust-bitcoin/BDK upgrade)

jkczyz · 2024-08-29T16:07:04Z

+ ConfirmationTarget::OnchainPayment => 6,
+ ConfirmationTarget::ChannelFunding => 12,


Seems like in practice the values are the same as before. Is this change to allow us to vary them in the future?

Yes, I intentionally left the behavior unchanged for now. This is really only an overdue refactor and also prepares for the LDK upgrade where we'll get more ConfirmationTargets and in particular will split OnChainSweep.
At some point in the future (probably when tackling #176), we'll revisit if the chosen defaults could be improved in any way, or if they are fine as is.

jkczyz · 2024-08-29T16:20:22Z

 }

-pub struct Wallet<D, B: Deref, E: Deref, L: Deref>
+pub(crate) struct Wallet<D, B: Deref, E: Deref, L: Deref>


Visibility control for Wallet and WalletKeysManager (below) seem unrelated to to the commits purpose.

I thought so, too, but rustc 1.63 seemed to think otherwise (as the new FeeEstimator is pub(crate), it complained that I couldn't leak a pub(crate) trait in a pub struct, nevermind that in fact the module itself is pub(crate)). I now split the visibility changes out to their own commit though.

jkczyz

LGTM. Please squash.

.. previously we used LDK's `FeeEstimator` and `ConfirmationTarget` and ~misused some of the latter's variants for our non-Lightning operations. Here, we introduce our own `FeeEstimator` and `ConfirmationTarget` allowing to add specific variants for `ChannelFunding` and `OnchainPayment`s, for example.

tnull · 2024-08-30T14:58:22Z

LGTM. Please squash.

Squashed without further changes.

tnull · 2024-08-29T10:10:11Z

.. previously we used LDK's FeeEstimator and ConfirmationTarget and ~misused some of the latter's variants for our non-Lightning operations.

Here, we introduce our own FeeEstimator and ConfirmationTarget allowing to add specific variants for ChannelFunding and OnchainPayments, for example.

(This is can also be viewed as a prefactor to #176, which we'll do as part of / after the upcoming rust-bitcoin/BDK upgrade)

jkczyz · 2024-08-29T16:07:04Z

+ ConfirmationTarget::OnchainPayment => 6,
+ ConfirmationTarget::ChannelFunding => 12,


Seems like in practice the values are the same as before. Is this change to allow us to vary them in the future?

Yes, I intentionally left the behavior unchanged for now. This is really only an overdue refactor and also prepares for the LDK upgrade where we'll get more ConfirmationTargets and in particular will split OnChainSweep.
At some point in the future (probably when tackling #176), we'll revisit if the chosen defaults could be improved in any way, or if they are fine as is.

jkczyz · 2024-08-29T16:20:22Z

 }

-pub struct Wallet<D, B: Deref, E: Deref, L: Deref>
+pub(crate) struct Wallet<D, B: Deref, E: Deref, L: Deref>


Visibility control for Wallet and WalletKeysManager (below) seem unrelated to to the commits purpose.

I thought so, too, but rustc 1.63 seemed to think otherwise (as the new FeeEstimator is pub(crate), it complained that I couldn't leak a pub(crate) trait in a pub struct, nevermind that in fact the module itself is pub(crate)). I now split the visibility changes out to their own commit though.

jkczyz

LGTM. Please squash.

.. previously we used LDK's `FeeEstimator` and `ConfirmationTarget` and ~misused some of the latter's variants for our non-Lightning operations. Here, we introduce our own `FeeEstimator` and `ConfirmationTarget` allowing to add specific variants for `ChannelFunding` and `OnchainPayment`s, for example.

tnull · 2024-08-30T14:58:22Z

LGTM. Please squash.

Squashed without further changes.

tnull · 2024-08-29T10:10:11Z

.. previously we used LDK's FeeEstimator and ConfirmationTarget and ~misused some of the latter's variants for our non-Lightning operations.

Here, we introduce our own FeeEstimator and ConfirmationTarget allowing to add specific variants for ChannelFunding and OnchainPayments, for example.

(This is can also be viewed as a prefactor to #176, which we'll do as part of / after the upcoming rust-bitcoin/BDK upgrade)

jkczyz · 2024-08-29T16:07:04Z

+ ConfirmationTarget::OnchainPayment => 6,
+ ConfirmationTarget::ChannelFunding => 12,


Seems like in practice the values are the same as before. Is this change to allow us to vary them in the future?

Yes, I intentionally left the behavior unchanged for now. This is really only an overdue refactor and also prepares for the LDK upgrade where we'll get more ConfirmationTargets and in particular will split OnChainSweep.
At some point in the future (probably when tackling #176), we'll revisit if the chosen defaults could be improved in any way, or if they are fine as is.

jkczyz · 2024-08-29T16:20:22Z

 }

-pub struct Wallet<D, B: Deref, E: Deref, L: Deref>
+pub(crate) struct Wallet<D, B: Deref, E: Deref, L: Deref>


Visibility control for Wallet and WalletKeysManager (below) seem unrelated to to the commits purpose.

I thought so, too, but rustc 1.63 seemed to think otherwise (as the new FeeEstimator is pub(crate), it complained that I couldn't leak a pub(crate) trait in a pub struct, nevermind that in fact the module itself is pub(crate)). I now split the visibility changes out to their own commit though.

jkczyz

LGTM. Please squash.

.. previously we used LDK's `FeeEstimator` and `ConfirmationTarget` and ~misused some of the latter's variants for our non-Lightning operations. Here, we introduce our own `FeeEstimator` and `ConfirmationTarget` allowing to add specific variants for `ChannelFunding` and `OnchainPayment`s, for example.

tnull · 2024-08-30T14:58:22Z

LGTM. Please squash.

Squashed without further changes.

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 1930aad to a007882Compare August 29, 2024 11:00

tnull requested a review from jkczyz August 29, 2024 11:01

tnull mentioned this pull request Aug 29, 2024
Allow honoring reserve in send_all_to_address#345
Merged

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from ecfa9f6 to cebf11bCompare August 29, 2024 11:10

jkczyz reviewed Aug 29, 2024
View reviewed changes

Make Wallet and WalletKeysManagerpub(crate)
7202c83

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from 138bf61 to 9b1ea5aCompare August 30, 2024 06:38

jkczyz reviewed Aug 30, 2024
View reviewed changes

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 9b1ea5a to 42a695eCompare August 30, 2024 14:58

jkczyz approved these changes Aug 30, 2024
View reviewed changes

tnull merged commit 4535c5f into lightningdevkit:mainAug 30, 2024

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 1930aad to a007882Compare August 29, 2024 11:00

tnull requested a review from jkczyz August 29, 2024 11:01

tnull mentioned this pull request Aug 29, 2024
Allow honoring reserve in send_all_to_address#345
Merged

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from ecfa9f6 to cebf11bCompare August 29, 2024 11:10

jkczyz reviewed Aug 29, 2024
View reviewed changes

Make Wallet and WalletKeysManagerpub(crate)
7202c83

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from 138bf61 to 9b1ea5aCompare August 30, 2024 06:38

jkczyz reviewed Aug 30, 2024
View reviewed changes

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 9b1ea5a to 42a695eCompare August 30, 2024 14:58

jkczyz approved these changes Aug 30, 2024
View reviewed changes

tnull merged commit 4535c5f into lightningdevkit:mainAug 30, 2024

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 1930aad to a007882Compare August 29, 2024 11:00

tnull requested a review from jkczyz August 29, 2024 11:01

tnull mentioned this pull request Aug 29, 2024
Allow honoring reserve in send_all_to_address#345
Merged

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from ecfa9f6 to cebf11bCompare August 29, 2024 11:10

jkczyz reviewed Aug 29, 2024
View reviewed changes

Make Wallet and WalletKeysManagerpub(crate)
7202c83

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from 138bf61 to 9b1ea5aCompare August 30, 2024 06:38

jkczyz reviewed Aug 30, 2024
View reviewed changes

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 9b1ea5a to 42a695eCompare August 30, 2024 14:58

jkczyz approved these changes Aug 30, 2024
View reviewed changes

tnull merged commit 4535c5f into lightningdevkit:mainAug 30, 2024

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 1930aad to a007882Compare August 29, 2024 11:00

tnull requested a review from jkczyz August 29, 2024 11:01

tnull mentioned this pull request Aug 29, 2024
Allow honoring reserve in send_all_to_address#345
Merged

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from ecfa9f6 to cebf11bCompare August 29, 2024 11:10

jkczyz reviewed Aug 29, 2024
View reviewed changes

Make Wallet and WalletKeysManagerpub(crate)
7202c83

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from 138bf61 to 9b1ea5aCompare August 30, 2024 06:38

jkczyz reviewed Aug 30, 2024
View reviewed changes

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 9b1ea5a to 42a695eCompare August 30, 2024 14:58

jkczyz approved these changes Aug 30, 2024
View reviewed changes

tnull merged commit 4535c5f into lightningdevkit:mainAug 30, 2024

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 1930aad to a007882Compare August 29, 2024 11:00

tnull requested a review from jkczyz August 29, 2024 11:01

tnull mentioned this pull request Aug 29, 2024
Allow honoring reserve in send_all_to_address#345
Merged

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from ecfa9f6 to cebf11bCompare August 29, 2024 11:10

jkczyz reviewed Aug 29, 2024
View reviewed changes

Make Wallet and WalletKeysManagerpub(crate)
7202c83

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from 138bf61 to 9b1ea5aCompare August 30, 2024 06:38

jkczyz reviewed Aug 30, 2024
View reviewed changes

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 9b1ea5a to 42a695eCompare August 30, 2024 14:58

jkczyz approved these changes Aug 30, 2024
View reviewed changes

tnull merged commit 4535c5f into lightningdevkit:mainAug 30, 2024

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 1930aad to a007882Compare August 29, 2024 11:00

tnull requested a review from jkczyz August 29, 2024 11:01

tnull mentioned this pull request Aug 29, 2024
Allow honoring reserve in send_all_to_address#345
Merged

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from ecfa9f6 to cebf11bCompare August 29, 2024 11:10

jkczyz reviewed Aug 29, 2024
View reviewed changes

Make Wallet and WalletKeysManagerpub(crate)
7202c83

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from 138bf61 to 9b1ea5aCompare August 30, 2024 06:38

jkczyz reviewed Aug 30, 2024
View reviewed changes

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 9b1ea5a to 42a695eCompare August 30, 2024 14:58

jkczyz approved these changes Aug 30, 2024
View reviewed changes

tnull merged commit 4535c5f into lightningdevkit:mainAug 30, 2024

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 1930aad to a007882Compare August 29, 2024 11:00

tnull requested a review from jkczyz August 29, 2024 11:01

tnull mentioned this pull request Aug 29, 2024
Allow honoring reserve in send_all_to_address#345
Merged

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from ecfa9f6 to cebf11bCompare August 29, 2024 11:10

jkczyz reviewed Aug 29, 2024
View reviewed changes

Make Wallet and WalletKeysManagerpub(crate)
7202c83

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from 138bf61 to 9b1ea5aCompare August 30, 2024 06:38

jkczyz reviewed Aug 30, 2024
View reviewed changes

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 9b1ea5a to 42a695eCompare August 30, 2024 14:58

jkczyz approved these changes Aug 30, 2024
View reviewed changes

tnull merged commit 4535c5f into lightningdevkit:mainAug 30, 2024

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 1930aad to a007882Compare August 29, 2024 11:00

tnull requested a review from jkczyz August 29, 2024 11:01

tnull mentioned this pull request Aug 29, 2024
Allow honoring reserve in send_all_to_address#345
Merged

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from ecfa9f6 to cebf11bCompare August 29, 2024 11:10

jkczyz reviewed Aug 29, 2024
View reviewed changes

Make Wallet and WalletKeysManagerpub(crate)
7202c83

tnull force-pushed the 2024-08-fee-estimator-refactor branch 2 times, most recently from 138bf61 to 9b1ea5aCompare August 30, 2024 06:38

jkczyz reviewed Aug 30, 2024
View reviewed changes

tnull force-pushed the 2024-08-fee-estimator-refactor branch from 9b1ea5a to 42a695eCompare August 30, 2024 14:58

jkczyz approved these changes Aug 30, 2024
View reviewed changes

tnull merged commit 4535c5f into lightningdevkit:mainAug 30, 2024

		ConfirmationTarget::OnchainPayment => 6,
		ConfirmationTarget::ChannelFunding => 12,

Uh oh!

Conversation

tnull commented Aug 29, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jkczyzAug 29, 2024

Choose a reason for hiding this comment

Uh oh!

tnullAug 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkczyzAug 29, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tnullAug 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkczyz left a comment

Choose a reason for hiding this comment

Uh oh!

tnull commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tnull commented Aug 29, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jkczyzAug 29, 2024

Choose a reason for hiding this comment

Uh oh!

tnullAug 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkczyzAug 29, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tnullAug 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkczyz left a comment

Choose a reason for hiding this comment

Uh oh!

tnull commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tnull commented Aug 29, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jkczyzAug 29, 2024

Choose a reason for hiding this comment

Uh oh!

tnullAug 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

tnull commented Aug 29, 2024•
edited
Loading

tnullAug 30, 2024•
edited
Loading

jkczyzAug 29, 2024•
edited
Loading

tnullAug 30, 2024•
edited
Loading

tnull commented Aug 29, 2024•
edited
Loading

tnullAug 30, 2024•
edited
Loading

jkczyzAug 29, 2024•
edited
Loading

tnullAug 30, 2024•
edited
Loading

tnull commented Aug 29, 2024•
edited
Loading

tnullAug 30, 2024•
edited
Loading

jkczyzAug 29, 2024•
edited
Loading

tnullAug 30, 2024•
edited
Loading

tnull commented Aug 29, 2024•
edited
Loading

tnullAug 30, 2024•
edited
Loading

jkczyzAug 29, 2024•
edited
Loading

tnullAug 30, 2024•
edited
Loading