Skip to content

Replay events on event handling failures due to persistence failures. - #374

Merged
tnull merged 11 commits into
lightningdevkit:mainfrom
G8XSU:replay-events
Oct 16, 2024
Merged

Replay events on event handling failures due to persistence failures.#374
tnull merged 11 commits into
lightningdevkit:mainfrom
G8XSU:replay-events

Conversation

@G8XSU

@G8XSUG8XSU commented Oct 14, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Handle 3 types of failures mainly:

  • Failed to update payment_store due to persistence failure.
  • Failed to push ldk_node event to event_queue due to persistence failure.
  • Output tracking failure in output_sweeper due to persistence failure.

@G8XSU
G8XSU requested a review from tnullOctober 14, 2024 19:41
@G8XSUG8XSU mentioned this pull request Oct 14, 2024
Merged
@G8XSUG8XSU changed the title Replay events when there are failures due to persistence failure.Replay events on event handling failures due to persistence issues.Oct 14, 2024
@G8XSUG8XSU changed the title Replay events on event handling failures due to persistence issues.Replay events on event handling failures due to persistence failures.Oct 14, 2024
tnull
tnull reviewed Oct 15, 2024
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good as a first step, two comments though.

In a follow-up (probably based on/after #365 landed) we should try to tackle as many of the remaining explicit panics on persistence failure as possible.

Comment threadsrc/event.rs Outdated
Comment threadsrc/event.rs Outdated
@tnull

tnull commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

Also needs a rebase to account for the yanked 0.0.124.

@G8XSU

G8XSU commented Oct 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Rebased and addressed comments.

@G8XSU
G8XSU requested a review from tnullOctober 15, 2024 22:56
tnull
tnull approved these changes Oct 16, 2024
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnull
tnull merged commit cffdf7e into lightningdevkit:mainOct 16, 2024
This was referenced Oct 16, 2024
Closed
Open
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@tnull