Cut v0.5.0 binary releases by tnull · Pull Request #533 · lightningdevkit/ldk-node

tnull · 2025-04-29T08:20:54Z

This updates the required files for/post the 0.5.0 binary releases.

Note the actual binary releases include the recent LDK 0.1.3 release, with a backport of lightningdevkit/rust-lightning#3587, i.e., is based on https://github.com/tnull/rust-lightning/tree/2025-02-bump-electrum-client-backport
as the aws-lc-rs dependency otherwise fails to build on aarch64-apple-ios.

ldk-reviews-bot · 2025-04-29T08:20:57Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

.. as `lightning-transaction-sync` now requires the `electrum` feature.

joostjager · 2025-05-05T08:12:44Z

-rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain 1.73.0
-rustup target add aarch64-apple-ios-sim --toolchain 1.73.0
-rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain 1.73.0
+rustup upgrade stable


Shouldn't this remain deterministic?

Clarified offline. Stable now surpassed 1.73.0

joostjager · 2025-05-05T08:13:28Z

 #lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["rpc-client", "tokio"] }
-#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "time"] }
+#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum", "time"] }


Total nit, but order "electrum, time" is different from uncommented version.

joostjager · 2025-05-05T08:14:56Z


 let tag = "v0.5.0"
-let checksum = "95ea5307eb3a99203e39cfa21d962bfe3e879e62429e8c7cdf5292cae5dc35cc"
+let checksum = "fd9eb84a478402af8f790519a463b6e1bf6ab3987f5951cd8375afb9d39e7a4b"


What is this checksum and/or where does it come from? Maybe add a code comment.

Clarified offline - this is the checksum of the released binary.

tnull · 2025-04-29T08:20:54Z

This updates the required files for/post the 0.5.0 binary releases.

Note the actual binary releases include the recent LDK 0.1.3 release, with a backport of lightningdevkit/rust-lightning#3587, i.e., is based on https://github.com/tnull/rust-lightning/tree/2025-02-bump-electrum-client-backport
as the aws-lc-rs dependency otherwise fails to build on aarch64-apple-ios.

ldk-reviews-bot · 2025-04-29T08:20:57Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

.. as `lightning-transaction-sync` now requires the `electrum` feature.

joostjager · 2025-05-05T08:12:44Z

-rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain 1.73.0
-rustup target add aarch64-apple-ios-sim --toolchain 1.73.0
-rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain 1.73.0
+rustup upgrade stable


Shouldn't this remain deterministic?

Clarified offline. Stable now surpassed 1.73.0

joostjager · 2025-05-05T08:13:28Z

 #lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["rpc-client", "tokio"] }
-#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "time"] }
+#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum", "time"] }


Total nit, but order "electrum, time" is different from uncommented version.

joostjager · 2025-05-05T08:14:56Z


 let tag = "v0.5.0"
-let checksum = "95ea5307eb3a99203e39cfa21d962bfe3e879e62429e8c7cdf5292cae5dc35cc"
+let checksum = "fd9eb84a478402af8f790519a463b6e1bf6ab3987f5951cd8375afb9d39e7a4b"


What is this checksum and/or where does it come from? Maybe add a code comment.

Clarified offline - this is the checksum of the released binary.

tnull · 2025-04-29T08:20:54Z

This updates the required files for/post the 0.5.0 binary releases.

Note the actual binary releases include the recent LDK 0.1.3 release, with a backport of lightningdevkit/rust-lightning#3587, i.e., is based on https://github.com/tnull/rust-lightning/tree/2025-02-bump-electrum-client-backport
as the aws-lc-rs dependency otherwise fails to build on aarch64-apple-ios.

ldk-reviews-bot · 2025-04-29T08:20:57Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

.. as `lightning-transaction-sync` now requires the `electrum` feature.

joostjager · 2025-05-05T08:12:44Z

-rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain 1.73.0
-rustup target add aarch64-apple-ios-sim --toolchain 1.73.0
-rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain 1.73.0
+rustup upgrade stable


Shouldn't this remain deterministic?

Clarified offline. Stable now surpassed 1.73.0

joostjager · 2025-05-05T08:13:28Z

 #lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["rpc-client", "tokio"] }
-#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "time"] }
+#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum", "time"] }


Total nit, but order "electrum, time" is different from uncommented version.

joostjager · 2025-05-05T08:14:56Z


 let tag = "v0.5.0"
-let checksum = "95ea5307eb3a99203e39cfa21d962bfe3e879e62429e8c7cdf5292cae5dc35cc"
+let checksum = "fd9eb84a478402af8f790519a463b6e1bf6ab3987f5951cd8375afb9d39e7a4b"


What is this checksum and/or where does it come from? Maybe add a code comment.

Clarified offline - this is the checksum of the released binary.

tnull · 2025-04-29T08:20:54Z

This updates the required files for/post the 0.5.0 binary releases.

Note the actual binary releases include the recent LDK 0.1.3 release, with a backport of lightningdevkit/rust-lightning#3587, i.e., is based on https://github.com/tnull/rust-lightning/tree/2025-02-bump-electrum-client-backport
as the aws-lc-rs dependency otherwise fails to build on aarch64-apple-ios.

ldk-reviews-bot · 2025-04-29T08:20:57Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

.. as `lightning-transaction-sync` now requires the `electrum` feature.

joostjager · 2025-05-05T08:12:44Z

-rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain 1.73.0
-rustup target add aarch64-apple-ios-sim --toolchain 1.73.0
-rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain 1.73.0
+rustup upgrade stable


Shouldn't this remain deterministic?

Clarified offline. Stable now surpassed 1.73.0

joostjager · 2025-05-05T08:13:28Z

 #lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["rpc-client", "tokio"] }
-#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "time"] }
+#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum", "time"] }


Total nit, but order "electrum, time" is different from uncommented version.

joostjager · 2025-05-05T08:14:56Z


 let tag = "v0.5.0"
-let checksum = "95ea5307eb3a99203e39cfa21d962bfe3e879e62429e8c7cdf5292cae5dc35cc"
+let checksum = "fd9eb84a478402af8f790519a463b6e1bf6ab3987f5951cd8375afb9d39e7a4b"


What is this checksum and/or where does it come from? Maybe add a code comment.

Clarified offline - this is the checksum of the released binary.

tnull · 2025-04-29T08:20:54Z

This updates the required files for/post the 0.5.0 binary releases.

Note the actual binary releases include the recent LDK 0.1.3 release, with a backport of lightningdevkit/rust-lightning#3587, i.e., is based on https://github.com/tnull/rust-lightning/tree/2025-02-bump-electrum-client-backport
as the aws-lc-rs dependency otherwise fails to build on aarch64-apple-ios.

ldk-reviews-bot · 2025-04-29T08:20:57Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

.. as `lightning-transaction-sync` now requires the `electrum` feature.

joostjager · 2025-05-05T08:12:44Z

-rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain 1.73.0
-rustup target add aarch64-apple-ios-sim --toolchain 1.73.0
-rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain 1.73.0
+rustup upgrade stable


Shouldn't this remain deterministic?

Clarified offline. Stable now surpassed 1.73.0

joostjager · 2025-05-05T08:13:28Z

 #lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["rpc-client", "tokio"] }
-#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "time"] }
+#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum", "time"] }


Total nit, but order "electrum, time" is different from uncommented version.

joostjager · 2025-05-05T08:14:56Z


 let tag = "v0.5.0"
-let checksum = "95ea5307eb3a99203e39cfa21d962bfe3e879e62429e8c7cdf5292cae5dc35cc"
+let checksum = "fd9eb84a478402af8f790519a463b6e1bf6ab3987f5951cd8375afb9d39e7a4b"


What is this checksum and/or where does it come from? Maybe add a code comment.

Clarified offline - this is the checksum of the released binary.

tnull · 2025-04-29T08:20:54Z

This updates the required files for/post the 0.5.0 binary releases.

Note the actual binary releases include the recent LDK 0.1.3 release, with a backport of lightningdevkit/rust-lightning#3587, i.e., is based on https://github.com/tnull/rust-lightning/tree/2025-02-bump-electrum-client-backport
as the aws-lc-rs dependency otherwise fails to build on aarch64-apple-ios.

ldk-reviews-bot · 2025-04-29T08:20:57Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

.. as `lightning-transaction-sync` now requires the `electrum` feature.

joostjager · 2025-05-05T08:12:44Z

-rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain 1.73.0
-rustup target add aarch64-apple-ios-sim --toolchain 1.73.0
-rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain 1.73.0
+rustup upgrade stable


Shouldn't this remain deterministic?

Clarified offline. Stable now surpassed 1.73.0

joostjager · 2025-05-05T08:13:28Z

 #lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["rpc-client", "tokio"] }
-#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "time"] }
+#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum", "time"] }


Total nit, but order "electrum, time" is different from uncommented version.

joostjager · 2025-05-05T08:14:56Z


 let tag = "v0.5.0"
-let checksum = "95ea5307eb3a99203e39cfa21d962bfe3e879e62429e8c7cdf5292cae5dc35cc"
+let checksum = "fd9eb84a478402af8f790519a463b6e1bf6ab3987f5951cd8375afb9d39e7a4b"


What is this checksum and/or where does it come from? Maybe add a code comment.

Clarified offline - this is the checksum of the released binary.

tnull · 2025-04-29T08:20:54Z

This updates the required files for/post the 0.5.0 binary releases.

Note the actual binary releases include the recent LDK 0.1.3 release, with a backport of lightningdevkit/rust-lightning#3587, i.e., is based on https://github.com/tnull/rust-lightning/tree/2025-02-bump-electrum-client-backport
as the aws-lc-rs dependency otherwise fails to build on aarch64-apple-ios.

ldk-reviews-bot · 2025-04-29T08:20:57Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

.. as `lightning-transaction-sync` now requires the `electrum` feature.

joostjager · 2025-05-05T08:12:44Z

-rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain 1.73.0
-rustup target add aarch64-apple-ios-sim --toolchain 1.73.0
-rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain 1.73.0
+rustup upgrade stable


Shouldn't this remain deterministic?

Clarified offline. Stable now surpassed 1.73.0

joostjager · 2025-05-05T08:13:28Z

 #lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["rpc-client", "tokio"] }
-#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "time"] }
+#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum", "time"] }


Total nit, but order "electrum, time" is different from uncommented version.

joostjager · 2025-05-05T08:14:56Z


 let tag = "v0.5.0"
-let checksum = "95ea5307eb3a99203e39cfa21d962bfe3e879e62429e8c7cdf5292cae5dc35cc"
+let checksum = "fd9eb84a478402af8f790519a463b6e1bf6ab3987f5951cd8375afb9d39e7a4b"


What is this checksum and/or where does it come from? Maybe add a code comment.

Clarified offline - this is the checksum of the released binary.

tnull · 2025-04-29T08:20:54Z

This updates the required files for/post the 0.5.0 binary releases.

Note the actual binary releases include the recent LDK 0.1.3 release, with a backport of lightningdevkit/rust-lightning#3587, i.e., is based on https://github.com/tnull/rust-lightning/tree/2025-02-bump-electrum-client-backport
as the aws-lc-rs dependency otherwise fails to build on aarch64-apple-ios.

ldk-reviews-bot · 2025-04-29T08:20:57Z

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

.. as `lightning-transaction-sync` now requires the `electrum` feature.

joostjager · 2025-05-05T08:12:44Z

-rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain 1.73.0
-rustup target add aarch64-apple-ios-sim --toolchain 1.73.0
-rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain 1.73.0
+rustup upgrade stable


Shouldn't this remain deterministic?

Clarified offline. Stable now surpassed 1.73.0

joostjager · 2025-05-05T08:13:28Z

 #lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["rpc-client", "tokio"] }
-#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "time"] }
+#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum", "time"] }


Total nit, but order "electrum, time" is different from uncommented version.

joostjager · 2025-05-05T08:14:56Z


 let tag = "v0.5.0"
-let checksum = "95ea5307eb3a99203e39cfa21d962bfe3e879e62429e8c7cdf5292cae5dc35cc"
+let checksum = "fd9eb84a478402af8f790519a463b6e1bf6ab3987f5951cd8375afb9d39e7a4b"


What is this checksum and/or where does it come from? Maybe add a code comment.

Clarified offline - this is the checksum of the released binary.

tnull marked this pull request as draft April 29, 2025 08:20

tnull added 4 commits May 5, 2025 09:28

Bump Kotlin/Swift/Python version numbers
5fc9f13

Use stable Rust toolchain for Swift builds
ef1e4b7

Make minor adjustments to commented-out LDK deps
35eba7b
.. as `lightning-transaction-sync` now requires the `electrum` feature.

Update Swift files for v0.5.0
682ed26

tnull force-pushed the 2025-04-cut-0.5.0-binaries branch from c8ff340 to 682ed26Compare May 5, 2025 07:58

tnull mentioned this pull request May 5, 2025
Cut v0.5.0 binary releases (main) #536
Merged

tnull marked this pull request as ready for review May 5, 2025 08:04

tnull requested a review from joostjager May 5, 2025 08:04

joostjager reviewed May 5, 2025
View reviewed changes

joostjager approved these changes May 5, 2025
View reviewed changes

tnull merged commit c0314d6 into lightningdevkit:release/0.5May 5, 2025

tnull marked this pull request as draft April 29, 2025 08:20

tnull added 4 commits May 5, 2025 09:28

Bump Kotlin/Swift/Python version numbers
5fc9f13

Use stable Rust toolchain for Swift builds
ef1e4b7

Make minor adjustments to commented-out LDK deps
35eba7b
.. as `lightning-transaction-sync` now requires the `electrum` feature.

Update Swift files for v0.5.0
682ed26

tnull force-pushed the 2025-04-cut-0.5.0-binaries branch from c8ff340 to 682ed26Compare May 5, 2025 07:58

tnull mentioned this pull request May 5, 2025
Cut v0.5.0 binary releases (main) #536
Merged

tnull marked this pull request as ready for review May 5, 2025 08:04

tnull requested a review from joostjager May 5, 2025 08:04

joostjager reviewed May 5, 2025
View reviewed changes

joostjager approved these changes May 5, 2025
View reviewed changes

tnull merged commit c0314d6 into lightningdevkit:release/0.5May 5, 2025

tnull marked this pull request as draft April 29, 2025 08:20

tnull added 4 commits May 5, 2025 09:28

Bump Kotlin/Swift/Python version numbers
5fc9f13

Use stable Rust toolchain for Swift builds
ef1e4b7

Make minor adjustments to commented-out LDK deps
35eba7b
.. as `lightning-transaction-sync` now requires the `electrum` feature.

Update Swift files for v0.5.0
682ed26

tnull force-pushed the 2025-04-cut-0.5.0-binaries branch from c8ff340 to 682ed26Compare May 5, 2025 07:58

tnull mentioned this pull request May 5, 2025
Cut v0.5.0 binary releases (main) #536
Merged

tnull marked this pull request as ready for review May 5, 2025 08:04

tnull requested a review from joostjager May 5, 2025 08:04

joostjager reviewed May 5, 2025
View reviewed changes

joostjager approved these changes May 5, 2025
View reviewed changes

tnull merged commit c0314d6 into lightningdevkit:release/0.5May 5, 2025

tnull marked this pull request as draft April 29, 2025 08:20

tnull added 4 commits May 5, 2025 09:28

Bump Kotlin/Swift/Python version numbers
5fc9f13

Use stable Rust toolchain for Swift builds
ef1e4b7

Make minor adjustments to commented-out LDK deps
35eba7b
.. as `lightning-transaction-sync` now requires the `electrum` feature.

Update Swift files for v0.5.0
682ed26

tnull force-pushed the 2025-04-cut-0.5.0-binaries branch from c8ff340 to 682ed26Compare May 5, 2025 07:58

tnull mentioned this pull request May 5, 2025
Cut v0.5.0 binary releases (main) #536
Merged

tnull marked this pull request as ready for review May 5, 2025 08:04

tnull requested a review from joostjager May 5, 2025 08:04

joostjager reviewed May 5, 2025
View reviewed changes

joostjager approved these changes May 5, 2025
View reviewed changes

tnull merged commit c0314d6 into lightningdevkit:release/0.5May 5, 2025

tnull marked this pull request as draft April 29, 2025 08:20

tnull added 4 commits May 5, 2025 09:28

Bump Kotlin/Swift/Python version numbers
5fc9f13

Use stable Rust toolchain for Swift builds
ef1e4b7

Make minor adjustments to commented-out LDK deps
35eba7b
.. as `lightning-transaction-sync` now requires the `electrum` feature.

Update Swift files for v0.5.0
682ed26

tnull force-pushed the 2025-04-cut-0.5.0-binaries branch from c8ff340 to 682ed26Compare May 5, 2025 07:58

tnull mentioned this pull request May 5, 2025
Cut v0.5.0 binary releases (main) #536
Merged

tnull marked this pull request as ready for review May 5, 2025 08:04

tnull requested a review from joostjager May 5, 2025 08:04

joostjager reviewed May 5, 2025
View reviewed changes

joostjager approved these changes May 5, 2025
View reviewed changes

tnull merged commit c0314d6 into lightningdevkit:release/0.5May 5, 2025

tnull marked this pull request as draft April 29, 2025 08:20

tnull added 4 commits May 5, 2025 09:28

Bump Kotlin/Swift/Python version numbers
5fc9f13

Use stable Rust toolchain for Swift builds
ef1e4b7

Make minor adjustments to commented-out LDK deps
35eba7b
.. as `lightning-transaction-sync` now requires the `electrum` feature.

Update Swift files for v0.5.0
682ed26

tnull force-pushed the 2025-04-cut-0.5.0-binaries branch from c8ff340 to 682ed26Compare May 5, 2025 07:58

tnull mentioned this pull request May 5, 2025
Cut v0.5.0 binary releases (main) #536
Merged

tnull marked this pull request as ready for review May 5, 2025 08:04

tnull requested a review from joostjager May 5, 2025 08:04

joostjager reviewed May 5, 2025
View reviewed changes

joostjager approved these changes May 5, 2025
View reviewed changes

tnull merged commit c0314d6 into lightningdevkit:release/0.5May 5, 2025

tnull marked this pull request as draft April 29, 2025 08:20

tnull added 4 commits May 5, 2025 09:28

Bump Kotlin/Swift/Python version numbers
5fc9f13

Use stable Rust toolchain for Swift builds
ef1e4b7

Make minor adjustments to commented-out LDK deps
35eba7b
.. as `lightning-transaction-sync` now requires the `electrum` feature.

Update Swift files for v0.5.0
682ed26

tnull force-pushed the 2025-04-cut-0.5.0-binaries branch from c8ff340 to 682ed26Compare May 5, 2025 07:58

tnull mentioned this pull request May 5, 2025
Cut v0.5.0 binary releases (main) #536
Merged

tnull marked this pull request as ready for review May 5, 2025 08:04

tnull requested a review from joostjager May 5, 2025 08:04

joostjager reviewed May 5, 2025
View reviewed changes

joostjager approved these changes May 5, 2025
View reviewed changes

tnull merged commit c0314d6 into lightningdevkit:release/0.5May 5, 2025

tnull marked this pull request as draft April 29, 2025 08:20

tnull added 4 commits May 5, 2025 09:28

Bump Kotlin/Swift/Python version numbers
5fc9f13

Use stable Rust toolchain for Swift builds
ef1e4b7

Make minor adjustments to commented-out LDK deps
35eba7b
.. as `lightning-transaction-sync` now requires the `electrum` feature.

Update Swift files for v0.5.0
682ed26

tnull force-pushed the 2025-04-cut-0.5.0-binaries branch from c8ff340 to 682ed26Compare May 5, 2025 07:58

tnull mentioned this pull request May 5, 2025
Cut v0.5.0 binary releases (main) #536
Merged

tnull marked this pull request as ready for review May 5, 2025 08:04

tnull requested a review from joostjager May 5, 2025 08:04

joostjager reviewed May 5, 2025
View reviewed changes

joostjager approved these changes May 5, 2025
View reviewed changes

tnull merged commit c0314d6 into lightningdevkit:release/0.5May 5, 2025

Uh oh!

Conversation

tnull commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tnull commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tnull commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tnull commented Apr 29, 2025•
edited
Loading

ldk-reviews-bot commented Apr 29, 2025•
edited
Loading

tnull commented Apr 29, 2025•
edited
Loading

ldk-reviews-bot commented Apr 29, 2025•
edited
Loading

tnull commented Apr 29, 2025•
edited
Loading

ldk-reviews-bot commented Apr 29, 2025•
edited
Loading

tnull commented Apr 29, 2025•
edited
Loading

ldk-reviews-bot commented Apr 29, 2025•
edited
Loading

tnull commented Apr 29, 2025•
edited
Loading