') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); (draft) feat: add `PaymentFailureReason` to `PaymentStatus` by reez · Pull Request #566 · lightningdevkit/ldk-node · GitHub
Skip to content

(draft) feat: add PaymentFailureReason to PaymentStatus - #566

Closed
reez wants to merge 1 commit into
lightningdevkit:mainfrom
reez:paymentstatus-failed
Closed

(draft) feat: add PaymentFailureReason to PaymentStatus#566
reez wants to merge 1 commit into
lightningdevkit:mainfrom
reez:paymentstatus-failed

Conversation

@reez

@reezreez commented Jun 8, 2025•
edited
Loading

Copy link
Copy Markdown

Add reason to PaymentStatusfailure#567

Probably some nuance I'm missing in my implementation, and a lot of spots I didn't use reason, but tried to use reason in the location where had the PaymentFailureReason to attach to the payment status.

Tried to build the swift bindings to test this in Monday app but was getting this error at the moment (aws-lc-sys is building Kyber code for iOS but that code isn’t compatible with iOS due to missing platform symbols? Not totally sure though):

Undefined symbols for architecture arm64:
"___chkstk_darwin", referenced from:
_aws_lc_0_25_0_pqcrystals_kyber512_ref_indcpa_keypair_derand in libaws_lc_sys-c89d8e1fcc00660b.rlib[102](kyber512r3_ref.c.o)
... (other Kyber-related symbols)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@ldk-reviews-bot

ldk-reviews-bot commented Jun 8, 2025•
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@reezreez mentioned this pull request Jun 8, 2025
Open
@tnull
tnull self-requested a review June 9, 2025 07:19
tnull
tnull reviewed Jun 9, 2025
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably some nuance I'm missing in my implementation, and a lot of spots I didn't use reason, but tried to use reason in the location where had the PaymentFailureReason to attach to the payment status.

Hmm, so at least in this PR we won't have a reason to set, as we mark payments as failed. I honestly also like the simplicity of the PaymentStatus enum previously, but if we'd want to go this way, we should probably introduce our own reason object that is a superset of LDK's PaymentFailureReason and have it cover all cases to always describe why we failed the payment.

tnull
tnull reviewed Jun 9, 2025
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to build the swift bindings to test this in Monday app but was getting this error at the moment (aws-lc-sys is building Kyber code for iOS but that code isn’t compatible with iOS due to missing platform symbols? Not totally sure though):

Yes, currently Swift builds are broken on main due to aws-lc-sys not building. Post LDK 0.2 we'll be able to use lightningdevkit/rust-lightning#3587 to switch on the ring feature for electrum-client for Swift builds, until then we use a patched backport of that PR for the Swift binary builds as a woraround. All other builds work fine with the otherwise-preferable aws-lc-rs.

@reez

reez commented Jun 9, 2025

Copy link
Copy Markdown
Author

Yes, currently Swift builds are broken on main due to aws-lc-sys not building. Post LDK 0.2 we'll be able to use lightningdevkit/rust-lightning#3587 to switch on the ring feature for electrum-client for Swift builds, until then we use a patched backport of that PR for the Swift binary builds as a woraround. All other builds work fine with the otherwise-preferable aws-lc-rs.

Got it, thanks for this info about the patched backport

@reez

reez commented Jun 9, 2025

Copy link
Copy Markdown
Author

Probably some nuance I'm missing in my implementation, and a lot of spots I didn't use reason, but tried to use reason in the location where had the PaymentFailureReason to attach to the payment status.

Hmm, so at least in this PR we won't have a reason to set, as we mark payments as failed. I honestly also like the simplicity of the PaymentStatus enum previously, but if we'd want to go this way, we should probably introduce our own reason object that is a superset of LDK's PaymentFailureReason and have it cover all cases to always describe why we failed the payment.

Ah yes, I didn't fully flesh it out once I got stuck at the swift bindings part, this makes sense.

I like the simplicity of PaymentStatus enum too, but also was running into spots where I wish I had some associated data/reason for when the case was a failure.

@reez

reez commented Jun 9, 2025•
edited
Loading

Copy link
Copy Markdown
Author

Closing the PR part of this (keeping Issue open), thanks for the comments!

@reezreez closed this Jun 9, 2025
@tnulltnull mentioned this pull request Jun 11, 2025
Open
@reez
reez deleted the paymentstatus-failed branch August 14, 2025 20:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reez@ldk-reviews-bot@tnull