Uh oh!
There was an error while loading. Please reload this page.
Export trait impls in FFI - #573
Merged
Merged
Conversation
I've assigned @valentinewallace as a reviewer! |
This was referenced Jun 10, 2025
valentinewallace
commented
Jun 10, 2025
Contributor
Needs rebase |
valentinewallace
commented
Jun 10, 2025
Contributor
I think the test failure is just a flake? |
Previously, we moved from a `String` representation to a 'full' `Bolt11Invoice` type. However, we forgot to expose the `Display` implementation in the FFI, leaving now way to retrieve the invoice string. Here, we fix this oversight, and also make a few related changes.
tnullforce-pushed
the
2025-06-add-ffi-trait-exports
branch
from
June 11, 2025 08:27
4790f6c to
520e5aaComparetnull
commented
Jun 11, 2025
CollaboratorAuthor
Rebased
Yes, it is, see #527 |
valentinewallace
commented
Jun 11, 2025
Contributor
CI sad? |
tnull
commented
Jun 11, 2025
CollaboratorAuthor
Kicked it. |
valentinewallace
approved these changes
Jun 11, 2025
This was referenced Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we moved from a
Stringrepresentation to a 'full'Bolt11Invoicetype. However, we forgot to expose theDisplayimplementation in the FFI, leaving now way to retrieve the invoice string.Here, we fix this oversight, and also make a few related changes.
(cc @alexanderwiederin)