Skip to content

Update main post-0.6.1 release#582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 3 commits into from
Jun 19, 2025
Merged

Update main post-0.6.1 release #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b9751b
Fix test code after `Bolt11Invoice::invoice_description` rename
tnull Jun 19, 2025
efa5b73
Update `CHANGELOG.md` for v0.6.1
tnull Jun 19, 2025
ec2b24d
Update Swift files for v0.6.1
tnull Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,21 @@
# 0.6.1 - Jun. 19, 2025
This patch release fixes minor issues with the recently-exposed `Bolt11Invoice`
type in bindings.

## Feature and API updates
- The `Bolt11Invoice::description` method is now exposed as
`Bolt11Invoice::invoice_description` in bindings, to avoid collisions with a
Swift standard method of same name (#576)

@joostjagerjoostjagerJun 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention the "main" versions of these prs?

@tnulltnullJun 19, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no, I think it still makes sense to cite the 'original' PRs, but we should probably settle on where PRs go first.


## Bug Fixes and Improvements
- The `Display` implementation of `Bolt11Invoice` is now exposed in bindings,
(re-)allowing to render the invoice as a string. (#574)

In total, this release features 9 files changed, 549 insertions, 83 deletions,
in 8 commits from 1 author in alphabetical order:

- Elias Rohrer

# 0.6.0 - Jun. 9, 2025
This sixth minor release mainly fixes an issue that could have left the
on-chain wallet unable to spend funds if transactions that had previously been
Expand Down
4 changes: 2 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,8 @@

import PackageDescription

let tag = "v0.6.0"
let checksum = "8bda396624134e0b592bfcc2f977b9aa5ce8c2ee359c032ae3520869ece8851c"
let tag = "v0.6.1"
let checksum = "73f53b615d5bfdf76f2e7233bde17a2a62631292ce506763a7150344230859c8"
let url = "https://github.com/lightningdevkit/ldk-node/releases/download/\(tag)/LDKNodeFFI.xcframework.zip"

let package = Package(
Expand Down
52 changes: 40 additions & 12 deletions bindings/swift/Sources/LDKNode/LDKNode.swift
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -517,12 +517,12 @@ public protocol Bolt11InvoiceProtocol : AnyObject {

func currency() -> Currency

func description() -> Bolt11InvoiceDescription

func expiryTimeSeconds() -> UInt64

func fallbackAddresses() -> [Address]

func invoiceDescription() -> Bolt11InvoiceDescription

func isExpired() -> Bool

func minFinalCltvExpiryDelta() -> UInt64
Expand All@@ -548,6 +548,9 @@ public protocol Bolt11InvoiceProtocol : AnyObject {
}

open class Bolt11Invoice:
CustomDebugStringConvertible,
CustomStringConvertible,
Equatable,
Bolt11InvoiceProtocol {
fileprivate let pointer: UnsafeMutableRawPointer!

Expand DownExpand Up@@ -610,13 +613,6 @@ open func currency() -> Currency {
})
}

open func description() -> Bolt11InvoiceDescription {
return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
uniffi_ldk_node_fn_method_bolt11invoice_description(self.uniffiClonePointer(),$0
)
})
}

open func expiryTimeSeconds() -> UInt64 {
return try! FfiConverterUInt64.lift(try! rustCall() {
uniffi_ldk_node_fn_method_bolt11invoice_expiry_time_seconds(self.uniffiClonePointer(),$0
Expand All@@ -631,6 +627,13 @@ open func fallbackAddresses() -> [Address] {
})
}

open func invoiceDescription() -> Bolt11InvoiceDescription {
return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
uniffi_ldk_node_fn_method_bolt11invoice_invoice_description(self.uniffiClonePointer(),$0
)
})
}

open func isExpired() -> Bool {
return try! FfiConverterBool.lift(try! rustCall() {
uniffi_ldk_node_fn_method_bolt11invoice_is_expired(self.uniffiClonePointer(),$0
Expand DownExpand Up@@ -709,6 +712,31 @@ open func wouldExpire(atTimeSeconds: UInt64) -> Bool {
})
}

open var debugDescription: String {
return try! FfiConverterString.lift(
try! rustCall() {
uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_debug(self.uniffiClonePointer(),$0
)
}
)
}
open var description: String {
return try! FfiConverterString.lift(
try! rustCall() {
uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_display(self.uniffiClonePointer(),$0
)
}
)
}
public static func == (self: Bolt11Invoice, other: Bolt11Invoice) -> Bool {
return try! FfiConverterBool.lift(
try! rustCall() {
uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_eq_eq(self.uniffiClonePointer(),
FfiConverterTypeBolt11Invoice.lower(other),$0
)
}
)
}

}

Expand DownExpand Up@@ -9451,15 +9479,15 @@ private var initializationResult: InitializationResult {
if (uniffi_ldk_node_checksum_method_bolt11invoice_currency() != 32179) {
return InitializationResult.apiChecksumMismatch
}
if (uniffi_ldk_node_checksum_method_bolt11invoice_description() != 9887) {
return InitializationResult.apiChecksumMismatch
}
if (uniffi_ldk_node_checksum_method_bolt11invoice_expiry_time_seconds() != 23625) {
return InitializationResult.apiChecksumMismatch
}
if (uniffi_ldk_node_checksum_method_bolt11invoice_fallback_addresses() != 55276) {
return InitializationResult.apiChecksumMismatch
}
if (uniffi_ldk_node_checksum_method_bolt11invoice_invoice_description() != 395) {
return InitializationResult.apiChecksumMismatch
}
if (uniffi_ldk_node_checksum_method_bolt11invoice_is_expired() != 15932) {
return InitializationResult.apiChecksumMismatch
}
Expand Down
2 changes: 1 addition & 1 deletion src/ffi/types.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1262,7 +1262,7 @@ mod tests {
let (ldk_invoice, wrapped_invoice) = create_test_bolt11_invoice();

let ldk_description = ldk_invoice.description();
let wrapped_description = wrapped_invoice.description();
let wrapped_description = wrapped_invoice.invoice_description();

match (ldk_description, &wrapped_description) {
(
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update `main` post-0.6.1 release by tnull · Pull Request #582 · lightningdevkit/ldk-node · GitHub
Skip to content
Update main post-0.6.1 release#582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 3 commits into

from

Jun 19, 2025
 Merged


Update main post-0.6.1 release
#582
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
6b9751b

Fix test code after `Bolt11Invoice::invoice_description` rename


tnull Jun 19, 2025
efa5b73

Update `CHANGELOG.md` for v0.6.1


tnull Jun 19, 2025
ec2b24d

Update Swift files for v0.6.1


tnull Jun 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,21 @@
# 0.6.1 - Jun. 19, 2025
This patch release fixes minor issues with the recently-exposed `Bolt11Invoice`
type in bindings.

## Feature and API updates
- The `Bolt11Invoice::description` method is now exposed as
 `Bolt11Invoice::invoice_description` in bindings, to avoid collisions with a
 Swift standard method of same name (#576)
@joostjagerjoostjagerJun 19, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention the "main" versions of these prs?
@tnulltnullJun 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no, I think it still makes sense to cite the 'original' PRs, but we should probably settle on where PRs go first.

## Bug Fixes and Improvements
- The `Display` implementation of `Bolt11Invoice` is now exposed in bindings,
 (re-)allowing to render the invoice as a string. (#574)

In total, this release features 9 files changed, 549 insertions, 83 deletions,
in 8 commits from 1 author in alphabetical order:

- Elias Rohrer

# 0.6.0 - Jun. 9, 2025
This sixth minor release mainly fixes an issue that could have left the
on-chain wallet unable to spend funds if transactions that had previously been
Expand Down

4 changes: 2 additions & 2 deletions
Package.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,8 @@

import PackageDescription

let tag = "v0.6.0"
let checksum = "8bda396624134e0b592bfcc2f977b9aa5ce8c2ee359c032ae3520869ece8851c"
let tag = "v0.6.1"
let checksum = "73f53b615d5bfdf76f2e7233bde17a2a62631292ce506763a7150344230859c8"
let url = "https://github.com/lightningdevkit/ldk-node/releases/download/\(tag)/LDKNodeFFI.xcframework.zip"

let package = Package(
Expand Down

52 changes: 40 additions & 12 deletions
bindings/swift/Sources/LDKNode/LDKNode.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -517,12 +517,12 @@ public protocol Bolt11InvoiceProtocol : AnyObject {

 func currency() -> Currency

 func description() -> Bolt11InvoiceDescription

 func expiryTimeSeconds() -> UInt64

 func fallbackAddresses() -> [Address]

 func invoiceDescription() -> Bolt11InvoiceDescription

 func isExpired() -> Bool

 func minFinalCltvExpiryDelta() -> UInt64
Expand All@@ -548,6 +548,9 @@ public protocol Bolt11InvoiceProtocol : AnyObject {
}

open class Bolt11Invoice:
 CustomDebugStringConvertible,
 CustomStringConvertible,
 Equatable,
 Bolt11InvoiceProtocol {
 fileprivate let pointer: UnsafeMutableRawPointer!

Expand DownExpand Up@@ -610,13 +613,6 @@ open func currency() -> Currency {
})
}

open func description() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func expiryTimeSeconds() -> UInt64 {
 return try! FfiConverterUInt64.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_expiry_time_seconds(self.uniffiClonePointer(),$0
Expand All@@ -631,6 +627,13 @@ open func fallbackAddresses() -> [Address] {
})
}

open func invoiceDescription() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func isExpired() -> Bool {
 return try! FfiConverterBool.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_is_expired(self.uniffiClonePointer(),$0
Expand DownExpand Up@@ -709,6 +712,31 @@ open func wouldExpire(atTimeSeconds: UInt64) -> Bool {
})
}

 open var debugDescription: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_debug(self.uniffiClonePointer(),$0
 )
}
 )
 }
 open var description: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_display(self.uniffiClonePointer(),$0
 )
}
 )
 }
 public static func == (self: Bolt11Invoice, other: Bolt11Invoice) -> Bool {
 return try! FfiConverterBool.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_eq_eq(self.uniffiClonePointer(),
 FfiConverterTypeBolt11Invoice.lower(other),$0
 )
}
 )
 }

}

Expand DownExpand Up@@ -9451,15 +9479,15 @@ private var initializationResult: InitializationResult {
 if (uniffi_ldk_node_checksum_method_bolt11invoice_currency() != 32179) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_description() != 9887) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_expiry_time_seconds() != 23625) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_fallback_addresses() != 55276) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_invoice_description() != 395) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_is_expired() != 15932) {
 return InitializationResult.apiChecksumMismatch
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/ffi/types.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1262,7 +1262,7 @@ mod tests {
 let (ldk_invoice, wrapped_invoice) = create_test_bolt11_invoice();

 let ldk_description = ldk_invoice.description();
 let wrapped_description = wrapped_invoice.description();
 let wrapped_description = wrapped_invoice.invoice_description();

 match (ldk_description, &wrapped_description) {
 (
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update `main` post-0.6.1 release by tnull · Pull Request #582 · lightningdevkit/ldk-node · GitHub
Skip to content
Update main post-0.6.1 release#582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 3 commits into

from

Jun 19, 2025
 Merged


Update main post-0.6.1 release
#582
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
6b9751b

Fix test code after `Bolt11Invoice::invoice_description` rename


tnull Jun 19, 2025
efa5b73

Update `CHANGELOG.md` for v0.6.1


tnull Jun 19, 2025
ec2b24d

Update Swift files for v0.6.1


tnull Jun 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,21 @@
# 0.6.1 - Jun. 19, 2025
This patch release fixes minor issues with the recently-exposed `Bolt11Invoice`
type in bindings.

## Feature and API updates
- The `Bolt11Invoice::description` method is now exposed as
 `Bolt11Invoice::invoice_description` in bindings, to avoid collisions with a
 Swift standard method of same name (#576)
@joostjagerjoostjagerJun 19, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention the "main" versions of these prs?
@tnulltnullJun 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no, I think it still makes sense to cite the 'original' PRs, but we should probably settle on where PRs go first.

## Bug Fixes and Improvements
- The `Display` implementation of `Bolt11Invoice` is now exposed in bindings,
 (re-)allowing to render the invoice as a string. (#574)

In total, this release features 9 files changed, 549 insertions, 83 deletions,
in 8 commits from 1 author in alphabetical order:

- Elias Rohrer

# 0.6.0 - Jun. 9, 2025
This sixth minor release mainly fixes an issue that could have left the
on-chain wallet unable to spend funds if transactions that had previously been
Expand Down

4 changes: 2 additions & 2 deletions
Package.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,8 @@

import PackageDescription

let tag = "v0.6.0"
let checksum = "8bda396624134e0b592bfcc2f977b9aa5ce8c2ee359c032ae3520869ece8851c"
let tag = "v0.6.1"
let checksum = "73f53b615d5bfdf76f2e7233bde17a2a62631292ce506763a7150344230859c8"
let url = "https://github.com/lightningdevkit/ldk-node/releases/download/\(tag)/LDKNodeFFI.xcframework.zip"

let package = Package(
Expand Down

52 changes: 40 additions & 12 deletions
bindings/swift/Sources/LDKNode/LDKNode.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -517,12 +517,12 @@ public protocol Bolt11InvoiceProtocol : AnyObject {

 func currency() -> Currency

 func description() -> Bolt11InvoiceDescription

 func expiryTimeSeconds() -> UInt64

 func fallbackAddresses() -> [Address]

 func invoiceDescription() -> Bolt11InvoiceDescription

 func isExpired() -> Bool

 func minFinalCltvExpiryDelta() -> UInt64
Expand All@@ -548,6 +548,9 @@ public protocol Bolt11InvoiceProtocol : AnyObject {
}

open class Bolt11Invoice:
 CustomDebugStringConvertible,
 CustomStringConvertible,
 Equatable,
 Bolt11InvoiceProtocol {
 fileprivate let pointer: UnsafeMutableRawPointer!

Expand DownExpand Up@@ -610,13 +613,6 @@ open func currency() -> Currency {
})
}

open func description() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func expiryTimeSeconds() -> UInt64 {
 return try! FfiConverterUInt64.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_expiry_time_seconds(self.uniffiClonePointer(),$0
Expand All@@ -631,6 +627,13 @@ open func fallbackAddresses() -> [Address] {
})
}

open func invoiceDescription() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func isExpired() -> Bool {
 return try! FfiConverterBool.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_is_expired(self.uniffiClonePointer(),$0
Expand DownExpand Up@@ -709,6 +712,31 @@ open func wouldExpire(atTimeSeconds: UInt64) -> Bool {
})
}

 open var debugDescription: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_debug(self.uniffiClonePointer(),$0
 )
}
 )
 }
 open var description: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_display(self.uniffiClonePointer(),$0
 )
}
 )
 }
 public static func == (self: Bolt11Invoice, other: Bolt11Invoice) -> Bool {
 return try! FfiConverterBool.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_eq_eq(self.uniffiClonePointer(),
 FfiConverterTypeBolt11Invoice.lower(other),$0
 )
}
 )
 }

}

Expand DownExpand Up@@ -9451,15 +9479,15 @@ private var initializationResult: InitializationResult {
 if (uniffi_ldk_node_checksum_method_bolt11invoice_currency() != 32179) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_description() != 9887) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_expiry_time_seconds() != 23625) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_fallback_addresses() != 55276) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_invoice_description() != 395) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_is_expired() != 15932) {
 return InitializationResult.apiChecksumMismatch
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/ffi/types.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1262,7 +1262,7 @@ mod tests {
 let (ldk_invoice, wrapped_invoice) = create_test_bolt11_invoice();

 let ldk_description = ldk_invoice.description();
 let wrapped_description = wrapped_invoice.description();
 let wrapped_description = wrapped_invoice.invoice_description();

 match (ldk_description, &wrapped_description) {
 (
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update `main` post-0.6.1 release by tnull · Pull Request #582 · lightningdevkit/ldk-node · GitHub
Skip to content
Update main post-0.6.1 release#582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 3 commits into

from

Jun 19, 2025
 Merged


Update main post-0.6.1 release
#582
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
6b9751b

Fix test code after `Bolt11Invoice::invoice_description` rename


tnull Jun 19, 2025
efa5b73

Update `CHANGELOG.md` for v0.6.1


tnull Jun 19, 2025
ec2b24d

Update Swift files for v0.6.1


tnull Jun 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,21 @@
# 0.6.1 - Jun. 19, 2025
This patch release fixes minor issues with the recently-exposed `Bolt11Invoice`
type in bindings.

## Feature and API updates
- The `Bolt11Invoice::description` method is now exposed as
 `Bolt11Invoice::invoice_description` in bindings, to avoid collisions with a
 Swift standard method of same name (#576)
@joostjagerjoostjagerJun 19, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention the "main" versions of these prs?
@tnulltnullJun 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no, I think it still makes sense to cite the 'original' PRs, but we should probably settle on where PRs go first.

## Bug Fixes and Improvements
- The `Display` implementation of `Bolt11Invoice` is now exposed in bindings,
 (re-)allowing to render the invoice as a string. (#574)

In total, this release features 9 files changed, 549 insertions, 83 deletions,
in 8 commits from 1 author in alphabetical order:

- Elias Rohrer

# 0.6.0 - Jun. 9, 2025
This sixth minor release mainly fixes an issue that could have left the
on-chain wallet unable to spend funds if transactions that had previously been
Expand Down

4 changes: 2 additions & 2 deletions
Package.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,8 @@

import PackageDescription

let tag = "v0.6.0"
let checksum = "8bda396624134e0b592bfcc2f977b9aa5ce8c2ee359c032ae3520869ece8851c"
let tag = "v0.6.1"
let checksum = "73f53b615d5bfdf76f2e7233bde17a2a62631292ce506763a7150344230859c8"
let url = "https://github.com/lightningdevkit/ldk-node/releases/download/\(tag)/LDKNodeFFI.xcframework.zip"

let package = Package(
Expand Down

52 changes: 40 additions & 12 deletions
bindings/swift/Sources/LDKNode/LDKNode.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -517,12 +517,12 @@ public protocol Bolt11InvoiceProtocol : AnyObject {

 func currency() -> Currency

 func description() -> Bolt11InvoiceDescription

 func expiryTimeSeconds() -> UInt64

 func fallbackAddresses() -> [Address]

 func invoiceDescription() -> Bolt11InvoiceDescription

 func isExpired() -> Bool

 func minFinalCltvExpiryDelta() -> UInt64
Expand All@@ -548,6 +548,9 @@ public protocol Bolt11InvoiceProtocol : AnyObject {
}

open class Bolt11Invoice:
 CustomDebugStringConvertible,
 CustomStringConvertible,
 Equatable,
 Bolt11InvoiceProtocol {
 fileprivate let pointer: UnsafeMutableRawPointer!

Expand DownExpand Up@@ -610,13 +613,6 @@ open func currency() -> Currency {
})
}

open func description() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func expiryTimeSeconds() -> UInt64 {
 return try! FfiConverterUInt64.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_expiry_time_seconds(self.uniffiClonePointer(),$0
Expand All@@ -631,6 +627,13 @@ open func fallbackAddresses() -> [Address] {
})
}

open func invoiceDescription() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func isExpired() -> Bool {
 return try! FfiConverterBool.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_is_expired(self.uniffiClonePointer(),$0
Expand DownExpand Up@@ -709,6 +712,31 @@ open func wouldExpire(atTimeSeconds: UInt64) -> Bool {
})
}

 open var debugDescription: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_debug(self.uniffiClonePointer(),$0
 )
}
 )
 }
 open var description: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_display(self.uniffiClonePointer(),$0
 )
}
 )
 }
 public static func == (self: Bolt11Invoice, other: Bolt11Invoice) -> Bool {
 return try! FfiConverterBool.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_eq_eq(self.uniffiClonePointer(),
 FfiConverterTypeBolt11Invoice.lower(other),$0
 )
}
 )
 }

}

Expand DownExpand Up@@ -9451,15 +9479,15 @@ private var initializationResult: InitializationResult {
 if (uniffi_ldk_node_checksum_method_bolt11invoice_currency() != 32179) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_description() != 9887) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_expiry_time_seconds() != 23625) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_fallback_addresses() != 55276) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_invoice_description() != 395) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_is_expired() != 15932) {
 return InitializationResult.apiChecksumMismatch
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/ffi/types.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1262,7 +1262,7 @@ mod tests {
 let (ldk_invoice, wrapped_invoice) = create_test_bolt11_invoice();

 let ldk_description = ldk_invoice.description();
 let wrapped_description = wrapped_invoice.description();
 let wrapped_description = wrapped_invoice.invoice_description();

 match (ldk_description, &wrapped_description) {
 (
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Update `main` post-0.6.1 release by tnull · Pull Request #582 · lightningdevkit/ldk-node · GitHub
Skip to content
Update main post-0.6.1 release#582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 3 commits into

from

Jun 19, 2025
 Merged


Update main post-0.6.1 release
#582
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
6b9751b

Fix test code after `Bolt11Invoice::invoice_description` rename


tnull Jun 19, 2025
efa5b73

Update `CHANGELOG.md` for v0.6.1


tnull Jun 19, 2025
ec2b24d

Update Swift files for v0.6.1


tnull Jun 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,21 @@
# 0.6.1 - Jun. 19, 2025
This patch release fixes minor issues with the recently-exposed `Bolt11Invoice`
type in bindings.

## Feature and API updates
- The `Bolt11Invoice::description` method is now exposed as
 `Bolt11Invoice::invoice_description` in bindings, to avoid collisions with a
 Swift standard method of same name (#576)
@joostjagerjoostjagerJun 19, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention the "main" versions of these prs?
@tnulltnullJun 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no, I think it still makes sense to cite the 'original' PRs, but we should probably settle on where PRs go first.

## Bug Fixes and Improvements
- The `Display` implementation of `Bolt11Invoice` is now exposed in bindings,
 (re-)allowing to render the invoice as a string. (#574)

In total, this release features 9 files changed, 549 insertions, 83 deletions,
in 8 commits from 1 author in alphabetical order:

- Elias Rohrer

# 0.6.0 - Jun. 9, 2025
This sixth minor release mainly fixes an issue that could have left the
on-chain wallet unable to spend funds if transactions that had previously been
Expand Down

4 changes: 2 additions & 2 deletions
Package.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,8 @@

import PackageDescription

let tag = "v0.6.0"
let checksum = "8bda396624134e0b592bfcc2f977b9aa5ce8c2ee359c032ae3520869ece8851c"
let tag = "v0.6.1"
let checksum = "73f53b615d5bfdf76f2e7233bde17a2a62631292ce506763a7150344230859c8"
let url = "https://github.com/lightningdevkit/ldk-node/releases/download/\(tag)/LDKNodeFFI.xcframework.zip"

let package = Package(
Expand Down

52 changes: 40 additions & 12 deletions
bindings/swift/Sources/LDKNode/LDKNode.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -517,12 +517,12 @@ public protocol Bolt11InvoiceProtocol : AnyObject {

 func currency() -> Currency

 func description() -> Bolt11InvoiceDescription

 func expiryTimeSeconds() -> UInt64

 func fallbackAddresses() -> [Address]

 func invoiceDescription() -> Bolt11InvoiceDescription

 func isExpired() -> Bool

 func minFinalCltvExpiryDelta() -> UInt64
Expand All@@ -548,6 +548,9 @@ public protocol Bolt11InvoiceProtocol : AnyObject {
}

open class Bolt11Invoice:
 CustomDebugStringConvertible,
 CustomStringConvertible,
 Equatable,
 Bolt11InvoiceProtocol {
 fileprivate let pointer: UnsafeMutableRawPointer!

Expand DownExpand Up@@ -610,13 +613,6 @@ open func currency() -> Currency {
})
}

open func description() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func expiryTimeSeconds() -> UInt64 {
 return try! FfiConverterUInt64.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_expiry_time_seconds(self.uniffiClonePointer(),$0
Expand All@@ -631,6 +627,13 @@ open func fallbackAddresses() -> [Address] {
})
}

open func invoiceDescription() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func isExpired() -> Bool {
 return try! FfiConverterBool.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_is_expired(self.uniffiClonePointer(),$0
Expand DownExpand Up@@ -709,6 +712,31 @@ open func wouldExpire(atTimeSeconds: UInt64) -> Bool {
})
}

 open var debugDescription: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_debug(self.uniffiClonePointer(),$0
 )
}
 )
 }
 open var description: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_display(self.uniffiClonePointer(),$0
 )
}
 )
 }
 public static func == (self: Bolt11Invoice, other: Bolt11Invoice) -> Bool {
 return try! FfiConverterBool.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_eq_eq(self.uniffiClonePointer(),
 FfiConverterTypeBolt11Invoice.lower(other),$0
 )
}
 )
 }

}

Expand DownExpand Up@@ -9451,15 +9479,15 @@ private var initializationResult: InitializationResult {
 if (uniffi_ldk_node_checksum_method_bolt11invoice_currency() != 32179) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_description() != 9887) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_expiry_time_seconds() != 23625) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_fallback_addresses() != 55276) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_invoice_description() != 395) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_is_expired() != 15932) {
 return InitializationResult.apiChecksumMismatch
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/ffi/types.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1262,7 +1262,7 @@ mod tests {
 let (ldk_invoice, wrapped_invoice) = create_test_bolt11_invoice();

 let ldk_description = ldk_invoice.description();
 let wrapped_description = wrapped_invoice.description();
 let wrapped_description = wrapped_invoice.invoice_description();

 match (ldk_description, &wrapped_description) {
 (
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update `main` post-0.6.1 release by tnull · Pull Request #582 · lightningdevkit/ldk-node · GitHub
Skip to content
Update main post-0.6.1 release#582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 3 commits into

from

Jun 19, 2025
 Merged


Update main post-0.6.1 release
#582
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
6b9751b

Fix test code after `Bolt11Invoice::invoice_description` rename


tnull Jun 19, 2025
efa5b73

Update `CHANGELOG.md` for v0.6.1


tnull Jun 19, 2025
ec2b24d

Update Swift files for v0.6.1


tnull Jun 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,21 @@
# 0.6.1 - Jun. 19, 2025
This patch release fixes minor issues with the recently-exposed `Bolt11Invoice`
type in bindings.

## Feature and API updates
- The `Bolt11Invoice::description` method is now exposed as
 `Bolt11Invoice::invoice_description` in bindings, to avoid collisions with a
 Swift standard method of same name (#576)
@joostjagerjoostjagerJun 19, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention the "main" versions of these prs?
@tnulltnullJun 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no, I think it still makes sense to cite the 'original' PRs, but we should probably settle on where PRs go first.

## Bug Fixes and Improvements
- The `Display` implementation of `Bolt11Invoice` is now exposed in bindings,
 (re-)allowing to render the invoice as a string. (#574)

In total, this release features 9 files changed, 549 insertions, 83 deletions,
in 8 commits from 1 author in alphabetical order:

- Elias Rohrer

# 0.6.0 - Jun. 9, 2025
This sixth minor release mainly fixes an issue that could have left the
on-chain wallet unable to spend funds if transactions that had previously been
Expand Down

4 changes: 2 additions & 2 deletions
Package.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,8 @@

import PackageDescription

let tag = "v0.6.0"
let checksum = "8bda396624134e0b592bfcc2f977b9aa5ce8c2ee359c032ae3520869ece8851c"
let tag = "v0.6.1"
let checksum = "73f53b615d5bfdf76f2e7233bde17a2a62631292ce506763a7150344230859c8"
let url = "https://github.com/lightningdevkit/ldk-node/releases/download/\(tag)/LDKNodeFFI.xcframework.zip"

let package = Package(
Expand Down

52 changes: 40 additions & 12 deletions
bindings/swift/Sources/LDKNode/LDKNode.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -517,12 +517,12 @@ public protocol Bolt11InvoiceProtocol : AnyObject {

 func currency() -> Currency

 func description() -> Bolt11InvoiceDescription

 func expiryTimeSeconds() -> UInt64

 func fallbackAddresses() -> [Address]

 func invoiceDescription() -> Bolt11InvoiceDescription

 func isExpired() -> Bool

 func minFinalCltvExpiryDelta() -> UInt64
Expand All@@ -548,6 +548,9 @@ public protocol Bolt11InvoiceProtocol : AnyObject {
}

open class Bolt11Invoice:
 CustomDebugStringConvertible,
 CustomStringConvertible,
 Equatable,
 Bolt11InvoiceProtocol {
 fileprivate let pointer: UnsafeMutableRawPointer!

Expand DownExpand Up@@ -610,13 +613,6 @@ open func currency() -> Currency {
})
}

open func description() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func expiryTimeSeconds() -> UInt64 {
 return try! FfiConverterUInt64.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_expiry_time_seconds(self.uniffiClonePointer(),$0
Expand All@@ -631,6 +627,13 @@ open func fallbackAddresses() -> [Address] {
})
}

open func invoiceDescription() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func isExpired() -> Bool {
 return try! FfiConverterBool.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_is_expired(self.uniffiClonePointer(),$0
Expand DownExpand Up@@ -709,6 +712,31 @@ open func wouldExpire(atTimeSeconds: UInt64) -> Bool {
})
}

 open var debugDescription: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_debug(self.uniffiClonePointer(),$0
 )
}
 )
 }
 open var description: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_display(self.uniffiClonePointer(),$0
 )
}
 )
 }
 public static func == (self: Bolt11Invoice, other: Bolt11Invoice) -> Bool {
 return try! FfiConverterBool.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_eq_eq(self.uniffiClonePointer(),
 FfiConverterTypeBolt11Invoice.lower(other),$0
 )
}
 )
 }

}

Expand DownExpand Up@@ -9451,15 +9479,15 @@ private var initializationResult: InitializationResult {
 if (uniffi_ldk_node_checksum_method_bolt11invoice_currency() != 32179) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_description() != 9887) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_expiry_time_seconds() != 23625) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_fallback_addresses() != 55276) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_invoice_description() != 395) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_is_expired() != 15932) {
 return InitializationResult.apiChecksumMismatch
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/ffi/types.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1262,7 +1262,7 @@ mod tests {
 let (ldk_invoice, wrapped_invoice) = create_test_bolt11_invoice();

 let ldk_description = ldk_invoice.description();
 let wrapped_description = wrapped_invoice.description();
 let wrapped_description = wrapped_invoice.invoice_description();

 match (ldk_description, &wrapped_description) {
 (
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Update `main` post-0.6.1 release by tnull · Pull Request #582 · lightningdevkit/ldk-node · GitHub
Skip to content
Update main post-0.6.1 release#582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tnull
merged 3 commits into

from

Jun 19, 2025
 Merged


Update main post-0.6.1 release
#582
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
6b9751b

Fix test code after `Bolt11Invoice::invoice_description` rename


tnull Jun 19, 2025
efa5b73

Update `CHANGELOG.md` for v0.6.1


tnull Jun 19, 2025
ec2b24d

Update Swift files for v0.6.1


tnull Jun 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,21 @@
# 0.6.1 - Jun. 19, 2025
This patch release fixes minor issues with the recently-exposed `Bolt11Invoice`
type in bindings.

## Feature and API updates
- The `Bolt11Invoice::description` method is now exposed as
 `Bolt11Invoice::invoice_description` in bindings, to avoid collisions with a
 Swift standard method of same name (#576)
@joostjagerjoostjagerJun 19, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention the "main" versions of these prs?
@tnulltnullJun 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no, I think it still makes sense to cite the 'original' PRs, but we should probably settle on where PRs go first.

## Bug Fixes and Improvements
- The `Display` implementation of `Bolt11Invoice` is now exposed in bindings,
 (re-)allowing to render the invoice as a string. (#574)

In total, this release features 9 files changed, 549 insertions, 83 deletions,
in 8 commits from 1 author in alphabetical order:

- Elias Rohrer

# 0.6.0 - Jun. 9, 2025
This sixth minor release mainly fixes an issue that could have left the
on-chain wallet unable to spend funds if transactions that had previously been
Expand Down

4 changes: 2 additions & 2 deletions
Package.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,8 @@

import PackageDescription

let tag = "v0.6.0"
let checksum = "8bda396624134e0b592bfcc2f977b9aa5ce8c2ee359c032ae3520869ece8851c"
let tag = "v0.6.1"
let checksum = "73f53b615d5bfdf76f2e7233bde17a2a62631292ce506763a7150344230859c8"
let url = "https://github.com/lightningdevkit/ldk-node/releases/download/\(tag)/LDKNodeFFI.xcframework.zip"

let package = Package(
Expand Down

52 changes: 40 additions & 12 deletions
bindings/swift/Sources/LDKNode/LDKNode.swift

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -517,12 +517,12 @@ public protocol Bolt11InvoiceProtocol : AnyObject {

 func currency() -> Currency

 func description() -> Bolt11InvoiceDescription

 func expiryTimeSeconds() -> UInt64

 func fallbackAddresses() -> [Address]

 func invoiceDescription() -> Bolt11InvoiceDescription

 func isExpired() -> Bool

 func minFinalCltvExpiryDelta() -> UInt64
Expand All@@ -548,6 +548,9 @@ public protocol Bolt11InvoiceProtocol : AnyObject {
}

open class Bolt11Invoice:
 CustomDebugStringConvertible,
 CustomStringConvertible,
 Equatable,
 Bolt11InvoiceProtocol {
 fileprivate let pointer: UnsafeMutableRawPointer!

Expand DownExpand Up@@ -610,13 +613,6 @@ open func currency() -> Currency {
})
}

open func description() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func expiryTimeSeconds() -> UInt64 {
 return try! FfiConverterUInt64.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_expiry_time_seconds(self.uniffiClonePointer(),$0
Expand All@@ -631,6 +627,13 @@ open func fallbackAddresses() -> [Address] {
})
}

open func invoiceDescription() -> Bolt11InvoiceDescription {
 return try! FfiConverterTypeBolt11InvoiceDescription.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_invoice_description(self.uniffiClonePointer(),$0
 )
})
}

open func isExpired() -> Bool {
 return try! FfiConverterBool.lift(try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_is_expired(self.uniffiClonePointer(),$0
Expand DownExpand Up@@ -709,6 +712,31 @@ open func wouldExpire(atTimeSeconds: UInt64) -> Bool {
})
}

 open var debugDescription: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_debug(self.uniffiClonePointer(),$0
 )
}
 )
 }
 open var description: String {
 return try! FfiConverterString.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_display(self.uniffiClonePointer(),$0
 )
}
 )
 }
 public static func == (self: Bolt11Invoice, other: Bolt11Invoice) -> Bool {
 return try! FfiConverterBool.lift(
 try! rustCall() {
 uniffi_ldk_node_fn_method_bolt11invoice_uniffi_trait_eq_eq(self.uniffiClonePointer(),
 FfiConverterTypeBolt11Invoice.lower(other),$0
 )
}
 )
 }

}

Expand DownExpand Up@@ -9451,15 +9479,15 @@ private var initializationResult: InitializationResult {
 if (uniffi_ldk_node_checksum_method_bolt11invoice_currency() != 32179) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_description() != 9887) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_expiry_time_seconds() != 23625) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_fallback_addresses() != 55276) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_invoice_description() != 395) {
 return InitializationResult.apiChecksumMismatch
 }
 if (uniffi_ldk_node_checksum_method_bolt11invoice_is_expired() != 15932) {
 return InitializationResult.apiChecksumMismatch
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/ffi/types.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1262,7 +1262,7 @@ mod tests {
 let (ldk_invoice, wrapped_invoice) = create_test_bolt11_invoice();

 let ldk_description = ldk_invoice.description();
 let wrapped_description = wrapped_invoice.description();
 let wrapped_description = wrapped_invoice.invoice_description();

 match (ldk_description, &wrapped_description) {
 (
Expand Down