Skip to content

Bump MSRV to rustc 1.85 - #606

Merged
tnull merged 1 commit into
lightningdevkit:mainfrom
tnull:2025-08-bump-msrv-to-1.85
Aug 11, 2025
Merged

Bump MSRV to rustc 1.85#606
tnull merged 1 commit into
lightningdevkit:mainfrom
tnull:2025-08-bump-msrv-to-1.85

Conversation

@tnull

@tnulltnull commented Aug 11, 2025

Copy link
Copy Markdown
Collaborator

We generally align our MSRV with Debian's stable channel. Debian 13 'Trixie' was just released, shipping rustc 1.85. We therefore bump our MSRV on the main branch here.

@ldk-reviews-bot

ldk-reviews-bot commented Aug 11, 2025•
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @jkczyz as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull
tnull requested a review from jkczyzAugust 11, 2025 09:20
This was referenced Aug 11, 2025
Merged
Merged
jkczyz
jkczyz reviewed Aug 11, 2025
View reviewed changes
Comment thread.github/workflows/rust.yml Outdated
Comment on lines +45 to +47
# - name: Pin packages to allow for MSRV
# if: matrix.msrv
# run:

@jkczyzjkczyzAug 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop this?

@tnulltnullAug 11, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, I mainly left it in because I expect that some dependencies will require pinning again soon. Now dropped it.

Comment thread.github/workflows/rust.yml
stable,
beta,
1.75.0, # Our MSRV
1.85.0, # Our MSRV

@jkczyzjkczyzAug 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we were already at 1.75.0, I take it is ok that we are ahead of rust-bitcoin and rust-lightning? IIRC, those used 1.63.0 as the MSRV. We're we just ahead back we had some other dependency that required a higher MSRV?

@tnulltnullAug 11, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's mostly the HTTP stack depedencies that had us at 1.75. However, I generally like the concept of following Debian stable rustc (which it's pretty conservative).

@tnull
Bump MSRV to rustc 1.85
1af27ac
We generally align our MSRV with Debian's stable channel. Debian 13
'Trixie' was just released, shipping rustc 1.85. We therefore bump our
MSRV on the `main` branch here.
@tnull
tnullforce-pushed the 2025-08-bump-msrv-to-1.85 branch from f7a29f4 to 1af27acCompareAugust 11, 2025 16:29
@tnull

tnull commented Aug 11, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Also rebased to fix CI.

@tnull
tnull merged commit 241b12b into lightningdevkit:mainAug 11, 2025
9 of 15 checks passed
@thesimplekidthesimplekid mentioned this pull request Aug 12, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tnull@ldk-reviews-bot@jkczyz
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Bump MSRV to rustc 1.85 by tnull · Pull Request #606 · lightningdevkit/ldk-node · GitHub
Skip to content
Bump MSRV to rustc 1.85 - #606
Merged
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Aug 11, 2025
Merged
Bump MSRV to rustc 1.85#606
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Conversation
@tnull
@tnulltnull
commented
Aug 11, 2025

Copy link


Copy Markdown

Collaborator
We generally align our MSRV with Debian's stable channel. Debian 13 'Trixie' was just released, shipping rustc 1.85. We therefore bump our MSRV on the main branch here.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 11, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @jkczyz as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@tnull
tnull
requested a review
from jkczyzAugust 11, 2025 09:20

This was referenced Aug 11, 2025
 Merged

 Merged

jkczyz
jkczyz
reviewed
Aug 11, 2025
View reviewed changes
Comment thread.github/workflows/rust.yml
Outdated


Comment on lines

+45
 to 
+47

# - name: Pin packages to allow for MSRV
# if: matrix.msrv
# run: 
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop this?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, I mainly left it in because I expect that some dependencies will require pinning again soon. Now dropped it.
Comment thread.github/workflows/rust.yml
 stable,
 beta,
 1.75.0, # Our MSRV
 1.85.0, # Our MSRV
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we were already at 1.75.0, I take it is ok that we are ahead of rust-bitcoin and rust-lightning? IIRC, those used 1.63.0 as the MSRV. We're we just ahead back we had some other dependency that required a higher MSRV?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's mostly the HTTP stack depedencies that had us at 1.75. However, I generally like the concept of following Debian stable rustc (which it's pretty conservative).
@tnull
Bump MSRV to rustc 1.85
1af27ac
We generally align our MSRV with Debian's stable channel. Debian 13
'Trixie' was just released, shipping rustc 1.85. We therefore bump our
MSRV on the `main` branch here.
@tnull
tnullforce-pushed
the
2025-08-bump-msrv-to-1.85
branch
from
f7a29f4 to
1af27acCompareAugust 11, 2025 16:29
@tnull
tnull
commented
Aug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Also rebased to fix CI.
@tnull
tnull
merged commit 241b12b
into
lightningdevkit:mainAug 11, 2025

9 of 15 checks passed

@thesimplekidthesimplekid
mentioned this pull request
Aug 12, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tnull@ldk-reviews-bot@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Bump MSRV to rustc 1.85 by tnull · Pull Request #606 · lightningdevkit/ldk-node · GitHub
Skip to content
Bump MSRV to rustc 1.85 - #606
Merged
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Aug 11, 2025
Merged
Bump MSRV to rustc 1.85#606
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Conversation
@tnull
@tnulltnull
commented
Aug 11, 2025

Copy link


Copy Markdown

Collaborator
We generally align our MSRV with Debian's stable channel. Debian 13 'Trixie' was just released, shipping rustc 1.85. We therefore bump our MSRV on the main branch here.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 11, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @jkczyz as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@tnull
tnull
requested a review
from jkczyzAugust 11, 2025 09:20

This was referenced Aug 11, 2025
 Merged

 Merged

jkczyz
jkczyz
reviewed
Aug 11, 2025
View reviewed changes
Comment thread.github/workflows/rust.yml
Outdated


Comment on lines

+45
 to 
+47

# - name: Pin packages to allow for MSRV
# if: matrix.msrv
# run: 
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop this?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, I mainly left it in because I expect that some dependencies will require pinning again soon. Now dropped it.
Comment thread.github/workflows/rust.yml
 stable,
 beta,
 1.75.0, # Our MSRV
 1.85.0, # Our MSRV
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we were already at 1.75.0, I take it is ok that we are ahead of rust-bitcoin and rust-lightning? IIRC, those used 1.63.0 as the MSRV. We're we just ahead back we had some other dependency that required a higher MSRV?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's mostly the HTTP stack depedencies that had us at 1.75. However, I generally like the concept of following Debian stable rustc (which it's pretty conservative).
@tnull
Bump MSRV to rustc 1.85
1af27ac
We generally align our MSRV with Debian's stable channel. Debian 13
'Trixie' was just released, shipping rustc 1.85. We therefore bump our
MSRV on the `main` branch here.
@tnull
tnullforce-pushed
the
2025-08-bump-msrv-to-1.85
branch
from
f7a29f4 to
1af27acCompareAugust 11, 2025 16:29
@tnull
tnull
commented
Aug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Also rebased to fix CI.
@tnull
tnull
merged commit 241b12b
into
lightningdevkit:mainAug 11, 2025

9 of 15 checks passed

@thesimplekidthesimplekid
mentioned this pull request
Aug 12, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tnull@ldk-reviews-bot@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Bump MSRV to rustc 1.85 by tnull · Pull Request #606 · lightningdevkit/ldk-node · GitHub
Skip to content
Bump MSRV to rustc 1.85 - #606
Merged
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Aug 11, 2025
Merged
Bump MSRV to rustc 1.85#606
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Conversation
@tnull
@tnulltnull
commented
Aug 11, 2025

Copy link


Copy Markdown

Collaborator
We generally align our MSRV with Debian's stable channel. Debian 13 'Trixie' was just released, shipping rustc 1.85. We therefore bump our MSRV on the main branch here.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 11, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @jkczyz as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@tnull
tnull
requested a review
from jkczyzAugust 11, 2025 09:20

This was referenced Aug 11, 2025
 Merged

 Merged

jkczyz
jkczyz
reviewed
Aug 11, 2025
View reviewed changes
Comment thread.github/workflows/rust.yml
Outdated


Comment on lines

+45
 to 
+47

# - name: Pin packages to allow for MSRV
# if: matrix.msrv
# run: 
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop this?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, I mainly left it in because I expect that some dependencies will require pinning again soon. Now dropped it.
Comment thread.github/workflows/rust.yml
 stable,
 beta,
 1.75.0, # Our MSRV
 1.85.0, # Our MSRV
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we were already at 1.75.0, I take it is ok that we are ahead of rust-bitcoin and rust-lightning? IIRC, those used 1.63.0 as the MSRV. We're we just ahead back we had some other dependency that required a higher MSRV?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's mostly the HTTP stack depedencies that had us at 1.75. However, I generally like the concept of following Debian stable rustc (which it's pretty conservative).
@tnull
Bump MSRV to rustc 1.85
1af27ac
We generally align our MSRV with Debian's stable channel. Debian 13
'Trixie' was just released, shipping rustc 1.85. We therefore bump our
MSRV on the `main` branch here.
@tnull
tnullforce-pushed
the
2025-08-bump-msrv-to-1.85
branch
from
f7a29f4 to
1af27acCompareAugust 11, 2025 16:29
@tnull
tnull
commented
Aug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Also rebased to fix CI.
@tnull
tnull
merged commit 241b12b
into
lightningdevkit:mainAug 11, 2025

9 of 15 checks passed

@thesimplekidthesimplekid
mentioned this pull request
Aug 12, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tnull@ldk-reviews-bot@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Bump MSRV to rustc 1.85 by tnull · Pull Request #606 · lightningdevkit/ldk-node · GitHub
Skip to content
Bump MSRV to rustc 1.85 - #606
Merged
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Aug 11, 2025
Merged
Bump MSRV to rustc 1.85#606
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Conversation
@tnull
@tnulltnull
commented
Aug 11, 2025

Copy link


Copy Markdown

Collaborator
We generally align our MSRV with Debian's stable channel. Debian 13 'Trixie' was just released, shipping rustc 1.85. We therefore bump our MSRV on the main branch here.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 11, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @jkczyz as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@tnull
tnull
requested a review
from jkczyzAugust 11, 2025 09:20

This was referenced Aug 11, 2025
 Merged

 Merged

jkczyz
jkczyz
reviewed
Aug 11, 2025
View reviewed changes
Comment thread.github/workflows/rust.yml
Outdated


Comment on lines

+45
 to 
+47

# - name: Pin packages to allow for MSRV
# if: matrix.msrv
# run: 
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop this?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, I mainly left it in because I expect that some dependencies will require pinning again soon. Now dropped it.
Comment thread.github/workflows/rust.yml
 stable,
 beta,
 1.75.0, # Our MSRV
 1.85.0, # Our MSRV
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we were already at 1.75.0, I take it is ok that we are ahead of rust-bitcoin and rust-lightning? IIRC, those used 1.63.0 as the MSRV. We're we just ahead back we had some other dependency that required a higher MSRV?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's mostly the HTTP stack depedencies that had us at 1.75. However, I generally like the concept of following Debian stable rustc (which it's pretty conservative).
@tnull
Bump MSRV to rustc 1.85
1af27ac
We generally align our MSRV with Debian's stable channel. Debian 13
'Trixie' was just released, shipping rustc 1.85. We therefore bump our
MSRV on the `main` branch here.
@tnull
tnullforce-pushed
the
2025-08-bump-msrv-to-1.85
branch
from
f7a29f4 to
1af27acCompareAugust 11, 2025 16:29
@tnull
tnull
commented
Aug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Also rebased to fix CI.
@tnull
tnull
merged commit 241b12b
into
lightningdevkit:mainAug 11, 2025

9 of 15 checks passed

@thesimplekidthesimplekid
mentioned this pull request
Aug 12, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tnull@ldk-reviews-bot@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Bump MSRV to rustc 1.85 by tnull · Pull Request #606 · lightningdevkit/ldk-node · GitHub
Skip to content
Bump MSRV to rustc 1.85 - #606
Merged
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Aug 11, 2025
Merged
Bump MSRV to rustc 1.85#606
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Conversation
@tnull
@tnulltnull
commented
Aug 11, 2025

Copy link


Copy Markdown

Collaborator
We generally align our MSRV with Debian's stable channel. Debian 13 'Trixie' was just released, shipping rustc 1.85. We therefore bump our MSRV on the main branch here.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 11, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @jkczyz as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@tnull
tnull
requested a review
from jkczyzAugust 11, 2025 09:20

This was referenced Aug 11, 2025
 Merged

 Merged

jkczyz
jkczyz
reviewed
Aug 11, 2025
View reviewed changes
Comment thread.github/workflows/rust.yml
Outdated


Comment on lines

+45
 to 
+47

# - name: Pin packages to allow for MSRV
# if: matrix.msrv
# run: 
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop this?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, I mainly left it in because I expect that some dependencies will require pinning again soon. Now dropped it.
Comment thread.github/workflows/rust.yml
 stable,
 beta,
 1.75.0, # Our MSRV
 1.85.0, # Our MSRV
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we were already at 1.75.0, I take it is ok that we are ahead of rust-bitcoin and rust-lightning? IIRC, those used 1.63.0 as the MSRV. We're we just ahead back we had some other dependency that required a higher MSRV?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's mostly the HTTP stack depedencies that had us at 1.75. However, I generally like the concept of following Debian stable rustc (which it's pretty conservative).
@tnull
Bump MSRV to rustc 1.85
1af27ac
We generally align our MSRV with Debian's stable channel. Debian 13
'Trixie' was just released, shipping rustc 1.85. We therefore bump our
MSRV on the `main` branch here.
@tnull
tnullforce-pushed
the
2025-08-bump-msrv-to-1.85
branch
from
f7a29f4 to
1af27acCompareAugust 11, 2025 16:29
@tnull
tnull
commented
Aug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Also rebased to fix CI.
@tnull
tnull
merged commit 241b12b
into
lightningdevkit:mainAug 11, 2025

9 of 15 checks passed

@thesimplekidthesimplekid
mentioned this pull request
Aug 12, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tnull@ldk-reviews-bot@jkczyz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Bump MSRV to rustc 1.85 by tnull · Pull Request #606 · lightningdevkit/ldk-node · GitHub
Skip to content
Bump MSRV to rustc 1.85 - #606
Merged
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Aug 11, 2025
Merged
Bump MSRV to rustc 1.85#606
tnull merged 1 commit into
lightningdevkit:mainfrom 
tnull:2025-08-bump-msrv-to-1.85
Conversation
@tnull
@tnulltnull
commented
Aug 11, 2025

Copy link


Copy Markdown

Collaborator
We generally align our MSRV with Debian's stable channel. Debian 13 'Trixie' was just released, shipping rustc 1.85. We therefore bump our MSRV on the main branch here.
@ldk-reviews-bot
ldk-reviews-bot
commented
Aug 11, 2025•

edited

Loading

Copy link


Copy Markdown

👋 Thanks for assigning @jkczyz as a reviewer!

I'll wait for their review and will help manage the review process.

Once they submit their review, I'll check if a second reviewer would be helpful.
@tnull
tnull
requested a review
from jkczyzAugust 11, 2025 09:20

This was referenced Aug 11, 2025
 Merged

 Merged

jkczyz
jkczyz
reviewed
Aug 11, 2025
View reviewed changes
Comment thread.github/workflows/rust.yml
Outdated


Comment on lines

+45
 to 
+47

# - name: Pin packages to allow for MSRV
# if: matrix.msrv
# run: 
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop this?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, I mainly left it in because I expect that some dependencies will require pinning again soon. Now dropped it.
Comment thread.github/workflows/rust.yml
 stable,
 beta,
 1.75.0, # Our MSRV
 1.85.0, # Our MSRV
@jkczyzjkczyzAug 11, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we were already at 1.75.0, I take it is ok that we are ahead of rust-bitcoin and rust-lightning? IIRC, those used 1.63.0 as the MSRV. We're we just ahead back we had some other dependency that required a higher MSRV?
@tnulltnullAug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's mostly the HTTP stack depedencies that had us at 1.75. However, I generally like the concept of following Debian stable rustc (which it's pretty conservative).
@tnull
Bump MSRV to rustc 1.85
1af27ac
We generally align our MSRV with Debian's stable channel. Debian 13
'Trixie' was just released, shipping rustc 1.85. We therefore bump our
MSRV on the `main` branch here.
@tnull
tnullforce-pushed
the
2025-08-bump-msrv-to-1.85
branch
from
f7a29f4 to
1af27acCompareAugust 11, 2025 16:29
@tnull
tnull
commented
Aug 11, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Also rebased to fix CI.
@tnull
tnull
merged commit 241b12b
into
lightningdevkit:mainAug 11, 2025

9 of 15 checks passed

@thesimplekidthesimplekid
mentioned this pull request
Aug 12, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tnull@ldk-reviews-bot@jkczyz