Skip to content

Fix wait_for_tx/outpoint exponential backoff - #641

Merged
tnull merged 1 commit into
lightningdevkit:developfrom
joostjager:backoff-fix
Sep 22, 2025
Merged

Fix wait_for_tx/outpoint exponential backoff#641
tnull merged 1 commit into
lightningdevkit:developfrom
joostjager:backoff-fix

Conversation

@joostjager

@joostjagerjoostjager commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Backoff wasn't actually working and polling would happen without any delay at all.

@ldk-reviews-bot

ldk-reviews-bot commented Sep 19, 2025•
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull
tnull reviewed Sep 19, 2025
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems like wait_for_outpoint_spend might benefit from the same fix?

Comment threadtests/common/mod.rs
}

pub(crate) fn wait_for_tx<E: ElectrumApi>(electrs: &E, txid: Txid) {
let mut tx_res = electrs.transaction_get(&txid);

@tnulltnullSep 19, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth to keep the pattern to avoid the unnecessary ping if the result is immediately available.

@joostjagerjoostjagerSep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. What is the ping for actually?

@tnulltnullSep 22, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://docs.rs/electrum-client/latest/electrum_client/trait.ElectrumApi.html#tymethod.ping

ping might trigger electrs to process new data before we actually attempt the lookup.

@joostjager
Fix wait_for_tx exponential backoff
3df1477
Backoff wasn't actually working and polling would happen without any
delay at all.
@joostjagerjoostjager changed the title Fix wait_for_tx exponential backoffFix wait_for_tx/outpoint exponential backoffSep 19, 2025
@ldk-reviews-bot

ldk-reviews-bot commented Sep 22, 2025

Copy link
Copy Markdown

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull
tnull approved these changes Sep 22, 2025
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnull
tnull merged commit 65945f8 into lightningdevkit:developSep 22, 2025
10 of 15 checks passed
@joostjagerjoostjager mentioned this pull request Nov 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joostjager@ldk-reviews-bot@tnull