') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [develop] Upgrade to latest RL and drop BOLT 12 quantity by TheBlueMatt · Pull Request #642 · lightningdevkit/ldk-node · GitHub
Skip to content

[develop] Upgrade to latest RL and drop BOLT 12 quantity - #642

Closed
TheBlueMatt wants to merge 2 commits into
lightningdevkit:mainfrom
TheBlueMatt:2025-09-upgrade-ldk
Closed

[develop] Upgrade to latest RL and drop BOLT 12 quantity#642
TheBlueMatt wants to merge 2 commits into
lightningdevkit:mainfrom
TheBlueMatt:2025-09-upgrade-ldk

Conversation

@TheBlueMatt

@TheBlueMattTheBlueMatt commented Sep 20, 2025

Copy link
Copy Markdown
Contributor
The BOLT 12 `quantity` field is incredibly unlikely to get any use
in practice (it assumes an online store which places some kind of
static offer for each item on its site, assuming that the merchant
doesn't want structured customer information nor the ability to
sell more than one item in a single order, both of which do not
exist in practice). Worse, supporting it requires an entire UI
flow built around the "quantity" concept, something which is a
nontrivial investment for downstream users of ldk-node.
Because the cost/utility tradeoff isn't nearly worth it, it was
dropped from the main offer-payment API in the upstream `lightning`
crate (requiring a separate
`ChannelManager::pay_for_offer_with_quantity` call).
For the same reason, we simply drop it from our API entirely here.
Absent someone who actually wants to use the `quantity` logic,
there is really no reason to support it.

Also upgrades to latest RL.

@ldk-reviews-bot

ldk-reviews-bot commented Sep 20, 2025•
edited
Loading

Copy link
Copy Markdown

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@TheBlueMatt

TheBlueMatt commented Sep 20, 2025

Copy link
Copy Markdown
ContributorAuthor

Oops, I missed #639. Anyway, I think we should drop the quantity arguments.

@TheBlueMatt
Drop quantity support from BOLT 12 logic
f07d15b
The BOLT 12 `quantity` field is incredibly unlikely to get any use
in practice (it assumes an online store which places some kind of
static offer for each item on its site, assuming that the merchant
doesn't want structured customer information nor the ability to
sell more than one item in a single order, both of which do not
exist in practice). Worse, supporting it requires an entire UI
flow built around the "quantity" concept, something which is a
nontrivial investment for downstream users of ldk-node.
Because the cost/utility tradeoff isn't nearly worth it, it was
dropped from the main offer-payment API in the upstream `lightning`
crate (requiring a separate
`ChannelManager::pay_for_offer_with_quantity` call).
For the same reason, we simply drop it from our API entirely here.
Absent someone who actually wants to use the `quantity` logic,
there is really no reason to support it.
@TheBlueMatt
TheBlueMattforce-pushed the 2025-09-upgrade-ldk branch 2 times, most recently from 7be11c3 to 938ac6dCompareSeptember 21, 2025 00:07
tnull
tnull reviewed Sep 22, 2025
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I agree that quantity is very confusing, but given it's a BOLT12 feature that other implementations might use, I'm not fully sure if we can get rid of it? Are we certain this doesn't lead to even more interop issues / confusion down the line?

Also added a few comments, this will also need a rebase since we landed #639 first as per @joostjager's request to fix develop breakage ASAP to be able to make progress.

Comment threadbindings/swift/Sources/LDKNode/LDKNode.swift

@tnulltnullSep 22, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop these changes to the static Swift files. These will only be updated/regenerated during release (though here on develop it doesn't matter as much as on main, which are actually part of the SwiftPM dependency).

Comment threadsrc/payment/bolt12.rs
if let Some(qty) = quantity {
if qty == 0 {
log_error!(self.logger, "Failed to create offer: quantity can't be zero.");
return Err(Error::InvalidQuantity);

@tnulltnullSep 22, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now also drop the InvalidQuantity error variant.

Comment threadsrc/payment/bolt12.rs Outdated
match self.channel_manager.pay_for_offer(
&offer,
quantity,
if offer.expects_quantity() { Some(1) } else { None },

@tnulltnullSep 22, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this do the right thing internally w.r.t Quantity::One vs Quantity::Bounded(1)?

@tnull
tnull changed the base branch from develop to mainOctober 7, 2025 08:52
@tnull

tnull commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

We decided to make the develop behavior (tracking more-recent LDK main) the default behavior. With #655 we merged develop into main and now deleted the develop branch. Hence the base branch is changed to main here, too.

@tnull

tnull commented Jan 12, 2026

Copy link
Copy Markdown
Collaborator

@TheBlueMatt do you still think this is worth? If so, it would need a rebase, otherwise we can close it - your call!

@tnull

tnull commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

Closing as abandoned.

@tnulltnull closed this Jan 26, 2026
@tnulltnull mentioned this pull request Apr 8, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt@ldk-reviews-bot@tnull